| Message ID | 20240219075720.640529-1-quic_kriskura@quicinc.com |
|---|---|
| State | New |
| Headers | show |
| Series | arm64: dts: qcom: sc8280xp: Add missing hs_phy_irq in USB nodes | expand |
On 2/19/2024 1:27 PM, Krishna Kurapati wrote: > Recent binding update [1] indicates that there are hs_phy_irq > present in primary and secondary usb controllers of sc8280xp. > > Add the missing hs_phy_irq for these controllers. Since the driver > doesn't use this interrupt, this change has been only compile > tested. > > [1]: https://lore.kernel.org/all/20231227091951.685-2-quic_kriskura@quicinc.com/ > > Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com> > --- > arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > index a5b194813079..62e2b99915af 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > @@ -3361,10 +3361,12 @@ usb_0: usb@a6f8800 { > assigned-clock-rates = <19200000>, <200000000>; > > interrupts-extended = <&intc GIC_SPI 804 IRQ_TYPE_LEVEL_HIGH>, > + <&intc GIC_SPI 805 IRQ_TYPE_LEVEL_HIGH>, > <&pdc 14 IRQ_TYPE_EDGE_BOTH>, > <&pdc 15 IRQ_TYPE_EDGE_BOTH>, > <&pdc 138 IRQ_TYPE_LEVEL_HIGH>; > interrupt-names = "pwr_event", > + "hs_phy_irq", > "dp_hs_phy_irq", > "dm_hs_phy_irq", > "ss_phy_irq"; > @@ -3421,10 +3423,12 @@ usb_1: usb@a8f8800 { > assigned-clock-rates = <19200000>, <200000000>; > > interrupts-extended = <&intc GIC_SPI 811 IRQ_TYPE_LEVEL_HIGH>, > + <&intc GIC_SPI 790 IRQ_TYPE_LEVEL_HIGH>, > <&pdc 12 IRQ_TYPE_EDGE_BOTH>, > <&pdc 13 IRQ_TYPE_EDGE_BOTH>, > <&pdc 136 IRQ_TYPE_LEVEL_HIGH>; > interrupt-names = "pwr_event", > + "hs_phy_irq", > "dp_hs_phy_irq", > "dm_hs_phy_irq", > "ss_phy_irq"; Gentle ping for review. Thanks in advance. - Krishna
On 2/19/24 08:57, Krishna Kurapati wrote: > Recent binding update [1] indicates that there are hs_phy_irq > present in primary and secondary usb controllers of sc8280xp. > > Add the missing hs_phy_irq for these controllers. Since the driver > doesn't use this interrupt, this change has been only compile > tested. > > [1]: https://lore.kernel.org/all/20231227091951.685-2-quic_kriskura@quicinc.com/ > > Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com> > --- I don't have the docs to back it up, but I trust you do.. Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad
On Mon, 19 Feb 2024 13:27:20 +0530, Krishna Kurapati wrote: > Recent binding update [1] indicates that there are hs_phy_irq > present in primary and secondary usb controllers of sc8280xp. > > Add the missing hs_phy_irq for these controllers. Since the driver > doesn't use this interrupt, this change has been only compile > tested. > > [...] Applied, thanks! [1/1] arm64: dts: qcom: sc8280xp: Add missing hs_phy_irq in USB nodes commit: 343dfe6206b2793f7f5196b849dfbb4efcc5c048 Best regards,
diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi index a5b194813079..62e2b99915af 100644 --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi @@ -3361,10 +3361,12 @@ usb_0: usb@a6f8800 { assigned-clock-rates = <19200000>, <200000000>; interrupts-extended = <&intc GIC_SPI 804 IRQ_TYPE_LEVEL_HIGH>, + <&intc GIC_SPI 805 IRQ_TYPE_LEVEL_HIGH>, <&pdc 14 IRQ_TYPE_EDGE_BOTH>, <&pdc 15 IRQ_TYPE_EDGE_BOTH>, <&pdc 138 IRQ_TYPE_LEVEL_HIGH>; interrupt-names = "pwr_event", + "hs_phy_irq", "dp_hs_phy_irq", "dm_hs_phy_irq", "ss_phy_irq"; @@ -3421,10 +3423,12 @@ usb_1: usb@a8f8800 { assigned-clock-rates = <19200000>, <200000000>; interrupts-extended = <&intc GIC_SPI 811 IRQ_TYPE_LEVEL_HIGH>, + <&intc GIC_SPI 790 IRQ_TYPE_LEVEL_HIGH>, <&pdc 12 IRQ_TYPE_EDGE_BOTH>, <&pdc 13 IRQ_TYPE_EDGE_BOTH>, <&pdc 136 IRQ_TYPE_LEVEL_HIGH>; interrupt-names = "pwr_event", + "hs_phy_irq", "dp_hs_phy_irq", "dm_hs_phy_irq", "ss_phy_irq";
Recent binding update [1] indicates that there are hs_phy_irq present in primary and secondary usb controllers of sc8280xp. Add the missing hs_phy_irq for these controllers. Since the driver doesn't use this interrupt, this change has been only compile tested. [1]: https://lore.kernel.org/all/20231227091951.685-2-quic_kriskura@quicinc.com/ Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com> --- arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 4 ++++ 1 file changed, 4 insertions(+)