| Message ID | 20240220081205.135063-1-raychi@google.com |
|---|---|
| State | New |
| Headers | show |
| Series | usb: dwc3: gadget: remove warning during kernel boot | expand |
On Tue, Feb 20, 2024 at 9:56 PM Greg KH <gregkh@linuxfoundation.org> wrote: > > On Tue, Feb 20, 2024 at 05:42:56PM +0800, Ray Chi wrote: > > Hi Krishna, > > > > I verified the Thinh's patch and the warning could be > > fixed. Thanks for the information. > > Can you provide a tested-by for that one? Since the solution has been merged, do I still need to provide tested-by? If tested-by is required, should I reply to the email thread for the merged patch or the reported patch? > And please do not top post :( Thanks for the tips and your patience. Regards, Ray
diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index 28f49400f3e8..de987cffe1ec 100644 --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -4708,6 +4708,9 @@ int dwc3_gadget_suspend(struct dwc3 *dwc) unsigned long flags; int ret; + if (!dwc->gadget_driver) + return 0; + ret = dwc3_gadget_soft_disconnect(dwc); if (ret) goto err;
The dwc3->gadget_driver is not initialized during the dwc3 probe process. This leads to a warning when the runtime power management (PM) attempts to suspend the gadget using dwc3_gadget_suspend(). This patch adds a check to prevent the warning. Cc: stable@vger.kernel.org Fixes: 61a348857e86 ("usb: dwc3: gadget: Fix NULL pointer dereference in dwc3_gadget_suspend") Signed-off-by: Ray Chi <raychi@google.com> --- drivers/usb/dwc3/gadget.c | 3 +++ 1 file changed, 3 insertions(+)