| Message ID | 93143410af20807c8451539db7fca7cddf31e7b4.1708551850.git.quic_uchalich@quicinc.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | LLCC: Support for Broadcast_AND region | expand |
On 23/02/2024 00:07, Unnathi Chalicheemala wrote: > The LLCC block in SM8450, SM8550 and SM8650 have a new register > space for Broadcast_AND region. This is used to check that all > channels have bit set to "1", mainly in SCID activation/deactivation. > > Previously we were mapping only the Broadcast_OR region assuming > there was only one broadcast register region. Now we also map > Broadcast_AND region. > > Signed-off-by: Unnathi Chalicheemala <quic_uchalich@quicinc.com> Why did you ignore the tags? Qualcomm upstreaming guide covers this case, so please read it before sending patches. Best regards, Krzysztof
On 28/02/2024 02:04, Unnathi Chalicheemala wrote: > On 2/27/2024 7:47 AM, Krzysztof Kozlowski wrote: >> On 23/02/2024 00:07, Unnathi Chalicheemala wrote: >>> The LLCC block in SM8450, SM8550 and SM8650 have a new register >>> space for Broadcast_AND region. This is used to check that all >>> channels have bit set to "1", mainly in SCID activation/deactivation. >>> >>> Previously we were mapping only the Broadcast_OR region assuming >>> there was only one broadcast register region. Now we also map >>> Broadcast_AND region. >>> >>> Signed-off-by: Unnathi Chalicheemala <quic_uchalich@quicinc.com> >> >> Why did you ignore the tags? Qualcomm upstreaming guide covers this >> case, so please read it before sending patches. >> > > I was asked to remove the Reviewed-by tag as the previous version of the > patch gave errors on running 'make DT_CHECKER_FLAGS=-m dt_binding_check', > that's why I dropped it. > It was sometime ago, https://lore.kernel.org/all/d78b4bce-7bcd-4ab0-a76b-135cee3ec9b0@linaro.org/ And where is it explained/mentioned? Every tag drop should be documented. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/cache/qcom,llcc.yaml b/Documentation/devicetree/bindings/cache/qcom,llcc.yaml index 07ccbda4a0ab..a6237028957f 100644 --- a/Documentation/devicetree/bindings/cache/qcom,llcc.yaml +++ b/Documentation/devicetree/bindings/cache/qcom,llcc.yaml @@ -141,8 +141,31 @@ allOf: - qcom,sm8150-llcc - qcom,sm8250-llcc - qcom,sm8350-llcc + then: + properties: + reg: + items: + - description: LLCC0 base register region + - description: LLCC1 base register region + - description: LLCC2 base register region + - description: LLCC3 base register region + - description: LLCC broadcast base register region + reg-names: + items: + - const: llcc0_base + - const: llcc1_base + - const: llcc2_base + - const: llcc3_base + - const: llcc_broadcast_base + + - if: + properties: + compatible: + contains: + enum: - qcom,sm8450-llcc - qcom,sm8550-llcc + - qcom,sm8650-llcc then: properties: reg: @@ -151,7 +174,8 @@ allOf: - description: LLCC1 base register region - description: LLCC2 base register region - description: LLCC3 base register region - - description: LLCC broadcast base register region + - description: LLCC broadcast OR register region + - description: LLCC broadcast AND register region reg-names: items: - const: llcc0_base @@ -159,6 +183,7 @@ allOf: - const: llcc2_base - const: llcc3_base - const: llcc_broadcast_base + - const: llcc_broadcast_and_base additionalProperties: false
The LLCC block in SM8450, SM8550 and SM8650 have a new register space for Broadcast_AND region. This is used to check that all channels have bit set to "1", mainly in SCID activation/deactivation. Previously we were mapping only the Broadcast_OR region assuming there was only one broadcast register region. Now we also map Broadcast_AND region. Signed-off-by: Unnathi Chalicheemala <quic_uchalich@quicinc.com> --- .../devicetree/bindings/cache/qcom,llcc.yaml | 27 ++++++++++++++++++- 1 file changed, 26 insertions(+), 1 deletion(-)