| Message ID | 20240222101811.18921-1-yaro330@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2] HID: logitech-dj: allow mice to report multimedia keycodes | expand |
On Thu, 22 Feb 2024, Yaraslau Furman wrote: > Multimedia buttons can be bound to the mouse's extra keys in Windows application. > Let Linux receive those keycodes. > > Signed-off-by: Yaraslau Furman <yaro330@gmail.com> > --- > drivers/hid/hid-logitech-dj.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/hid/hid-logitech-dj.c b/drivers/hid/hid-logitech-dj.c > index e6a8b6d8eab7..3c3c497b6b91 100644 > --- a/drivers/hid/hid-logitech-dj.c > +++ b/drivers/hid/hid-logitech-dj.c > @@ -965,9 +965,7 @@ static void logi_hidpp_dev_conn_notif_equad(struct hid_device *hdev, > } > break; > case REPORT_TYPE_MOUSE: > - workitem->reports_supported |= STD_MOUSE | HIDPP; > - if (djrcv_dev->type == recvr_type_mouse_only) > - workitem->reports_supported |= MULTIMEDIA; > + workitem->reports_supported |= STD_MOUSE | HIDPP | MULTIMEDIA; > break; CCing Hans who introduced this explicit check back in 3ed224e273ac ("HID: logitech-dj: Fix 064d:c52f receiver support"). Should it be made device-specific?
Hi All, On 4/3/24 1:38 PM, Jiri Kosina wrote: > On Thu, 22 Feb 2024, Yaraslau Furman wrote: > >> Multimedia buttons can be bound to the mouse's extra keys in Windows application. >> Let Linux receive those keycodes. >> >> Signed-off-by: Yaraslau Furman <yaro330@gmail.com> >> --- >> drivers/hid/hid-logitech-dj.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/drivers/hid/hid-logitech-dj.c b/drivers/hid/hid-logitech-dj.c >> index e6a8b6d8eab7..3c3c497b6b91 100644 >> --- a/drivers/hid/hid-logitech-dj.c >> +++ b/drivers/hid/hid-logitech-dj.c >> @@ -965,9 +965,7 @@ static void logi_hidpp_dev_conn_notif_equad(struct hid_device *hdev, >> } >> break; >> case REPORT_TYPE_MOUSE: >> - workitem->reports_supported |= STD_MOUSE | HIDPP; >> - if (djrcv_dev->type == recvr_type_mouse_only) >> - workitem->reports_supported |= MULTIMEDIA; >> + workitem->reports_supported |= STD_MOUSE | HIDPP | MULTIMEDIA; >> break; > > CCing Hans who introduced this explicit check back in 3ed224e273ac > ("HID: logitech-dj: Fix 064d:c52f receiver support"). > Should it be made device-specific? Jiri, thank you for bringing this to my attention. If mice attached to other receivers can send multi-media key presses too, then I believe that dropping the if (djrcv_dev->type == recvr_type_mouse_only) check is fine. IOW, the patch looks good to me: Reviewed-by: Hans de Goede <hdegoede@redhat.com> Regards, Hans
diff --git a/drivers/hid/hid-logitech-dj.c b/drivers/hid/hid-logitech-dj.c index e6a8b6d8eab7..3c3c497b6b91 100644 --- a/drivers/hid/hid-logitech-dj.c +++ b/drivers/hid/hid-logitech-dj.c @@ -965,9 +965,7 @@ static void logi_hidpp_dev_conn_notif_equad(struct hid_device *hdev, } break; case REPORT_TYPE_MOUSE: - workitem->reports_supported |= STD_MOUSE | HIDPP; - if (djrcv_dev->type == recvr_type_mouse_only) - workitem->reports_supported |= MULTIMEDIA; + workitem->reports_supported |= STD_MOUSE | HIDPP | MULTIMEDIA; break; } }
Multimedia buttons can be bound to the mouse's extra keys in Windows application. Let Linux receive those keycodes. Signed-off-by: Yaraslau Furman <yaro330@gmail.com> --- drivers/hid/hid-logitech-dj.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)