| Message ID | 20240223-topic-sm8550-upstream-ucsi-no-pdos-v1-1-8900ad510944@linaro.org |
|---|---|
| State | Accepted |
| Commit | 4a30dcac38c2b34f5b4f358630774bc2c2c104b0 |
| Headers | show |
| Series | usb: typec: ucsi: fix UCSI on SM8550 & SM8650 Qualcomm devices | expand |
On Fri, Feb 23, 2024 at 10:40:40AM +0100, Neil Armstrong wrote: > On SM8550 and SM8650 Qualcomm platforms a call to UCSI_GET_PDOS for > non-PD partners will cause a firmware crash with no > easy way to recover from it. > > Add UCSI_NO_PARTNER_PDOS quirk for those platform until we find > a way to properly handle the crash. > > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > --- > drivers/usb/typec/ucsi/ucsi_glink.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/typec/ucsi/ucsi_glink.c b/drivers/usb/typec/ucsi/ucsi_glink.c > index 0bd3f6dee678..932e7bf69447 100644 > --- a/drivers/usb/typec/ucsi/ucsi_glink.c > +++ b/drivers/usb/typec/ucsi/ucsi_glink.c > @@ -302,6 +302,7 @@ static const struct of_device_id pmic_glink_ucsi_of_quirks[] = { > { .compatible = "qcom,sc8180x-pmic-glink", .data = (void *)UCSI_NO_PARTNER_PDOS, }, > { .compatible = "qcom,sc8280xp-pmic-glink", .data = (void *)UCSI_NO_PARTNER_PDOS, }, > { .compatible = "qcom,sm8350-pmic-glink", .data = (void *)UCSI_NO_PARTNER_PDOS, }, > + { .compatible = "qcom,sm8550-pmic-glink", .data = (void *)UCSI_NO_PARTNER_PDOS, }, > {} > }; > > > --- > base-commit: 33e1d31873f87d119e5120b88cd350efa68ef276 > change-id: 20240223-topic-sm8550-upstream-ucsi-no-pdos-62fdad669f90 > > Best regards, > -- > Neil Armstrong <neil.armstrong@linaro.org>
diff --git a/drivers/usb/typec/ucsi/ucsi_glink.c b/drivers/usb/typec/ucsi/ucsi_glink.c index 0bd3f6dee678..932e7bf69447 100644 --- a/drivers/usb/typec/ucsi/ucsi_glink.c +++ b/drivers/usb/typec/ucsi/ucsi_glink.c @@ -302,6 +302,7 @@ static const struct of_device_id pmic_glink_ucsi_of_quirks[] = { { .compatible = "qcom,sc8180x-pmic-glink", .data = (void *)UCSI_NO_PARTNER_PDOS, }, { .compatible = "qcom,sc8280xp-pmic-glink", .data = (void *)UCSI_NO_PARTNER_PDOS, }, { .compatible = "qcom,sm8350-pmic-glink", .data = (void *)UCSI_NO_PARTNER_PDOS, }, + { .compatible = "qcom,sm8550-pmic-glink", .data = (void *)UCSI_NO_PARTNER_PDOS, }, {} };
On SM8550 and SM8650 Qualcomm platforms a call to UCSI_GET_PDOS for non-PD partners will cause a firmware crash with no easy way to recover from it. Add UCSI_NO_PARTNER_PDOS quirk for those platform until we find a way to properly handle the crash. Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> --- drivers/usb/typec/ucsi/ucsi_glink.c | 1 + 1 file changed, 1 insertion(+) --- base-commit: 33e1d31873f87d119e5120b88cd350efa68ef276 change-id: 20240223-topic-sm8550-upstream-ucsi-no-pdos-62fdad669f90 Best regards,