diff mbox series

pinctrl: aw9523: allow building as loadable module

Message ID 20240307140729.2278907-1-arnd@kernel.org
State New
Headers show
Series pinctrl: aw9523: allow building as loadable module | expand

Commit Message

Arnd Bergmann March 7, 2024, 2:06 p.m. UTC 
From: Arnd Bergmann <arnd@arndb.de>

When CONFIG_I2C is set to =m, the new aw9523 driver fails to link:

arm-linux-gnueabi-ld: drivers/pinctrl/pinctrl-aw9523.o: in function `aw9523_probe':
pinctrl-aw9523.c:(.text+0x9f8): undefined reference to `__devm_regmap_init_i2c'
arm-linux-gnueabi-ld: drivers/pinctrl/pinctrl-aw9523.o: in function `aw9523_driver_init':
pinctrl-aw9523.c:(.init.text+0x4): undefined reference to `i2c_register_driver'
arm-linux-gnueabi-ld: drivers/pinctrl/pinctrl-aw9523.o: in function `aw9523_driver_exit':
pinctrl-aw9523.c:(.exit.text+0x2): undefined reference to `i2c_del_driver'

Make it a tristate symbol so the dependency is correctly honored.

Fixes: bfa5aa367a82 ("pinctrl: Add driver for Awinic AW9523/B I2C GPIO Expander")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/pinctrl/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Linus Walleij March 7, 2024, 2:34 p.m. UTC | #1 
On Thu, Mar 7, 2024 at 3:07 PM Arnd Bergmann <arnd@kernel.org> wrote:


> When CONFIG_I2C is set to =m, the new aw9523 driver fails to link:
>
> arm-linux-gnueabi-ld: drivers/pinctrl/pinctrl-aw9523.o: in function `aw9523_probe':
> pinctrl-aw9523.c:(.text+0x9f8): undefined reference to `__devm_regmap_init_i2c'
> arm-linux-gnueabi-ld: drivers/pinctrl/pinctrl-aw9523.o: in function `aw9523_driver_init':
> pinctrl-aw9523.c:(.init.text+0x4): undefined reference to `i2c_register_driver'
> arm-linux-gnueabi-ld: drivers/pinctrl/pinctrl-aw9523.o: in function `aw9523_driver_exit':
> pinctrl-aw9523.c:(.exit.text+0x2): undefined reference to `i2c_del_driver'
>
> Make it a tristate symbol so the dependency is correctly honored.
>
> Fixes: bfa5aa367a82 ("pinctrl: Add driver for Awinic AW9523/B I2C GPIO Expander")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

I sent something similar yesterday:
https://lore.kernel.org/linux-gpio/20240305-fix-aw9523-v2-1-2dc50bab2b17@linaro.org/

Thanks anyway!

Yours,
Linus Walleij
diff mbox series

Patch

diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index 21d38bf2d1ca..d45657aa986a 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -128,7 +128,7 @@  config PINCTRL_AXP209
 	  Say Y to enable pinctrl and GPIO support for the AXP209 PMIC.
 
 config PINCTRL_AW9523
-	bool "Awinic AW9523/AW9523B I2C GPIO expander pinctrl driver"
+	tristate "Awinic AW9523/AW9523B I2C GPIO expander pinctrl driver"
 	depends on OF && I2C
 	select PINMUX
 	select PINCONF