| Message ID | 20240312110815.116992-1-peter.maydell@linaro.org |
|---|---|
| State | Accepted |
| Commit | 55f7c6a5f2bd82e1d2d0eac6eee0185ce0451815 |
| Headers | show |
| Series | tests: Raise timeouts for bufferiszero and crypto-tlscredsx509 | expand |
On Tue, Mar 12, 2024 at 11:08:15AM +0000, Peter Maydell wrote: > On our gcov CI job, the bufferiszero and crypto-tlscredsx509 > tests time out occasionally, making the job flaky. Double the > timeout on these two tests. > > Cc: qemu-stable@nongnu.org > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2221 > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> > --- > cc stable just because it probably helps CI reliability there too > --- > tests/unit/meson.build | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tests/unit/meson.build b/tests/unit/meson.build > index cae925c1325..30db3c418fa 100644 > --- a/tests/unit/meson.build > +++ b/tests/unit/meson.build > @@ -173,8 +173,9 @@ test_env.set('G_TEST_BUILDDIR', meson.current_build_dir()) > > slow_tests = { > 'test-aio-multithread' : 120, > + 'test-bufferiszero': 60, > 'test-crypto-block' : 300, > - 'test-crypto-tlscredsx509': 45, > + 'test-crypto-tlscredsx509': 90, > 'test-crypto-tlssession': 45, I'd probably suggest bumping this to 90 too, as it is a similar order to CPU burn complexity to the other tls test - both of them create a huge number of certs for testing many scenarios. Either way, Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> With regards, Daniel
On Tue, 12 Mar 2024 at 11:18, Daniel P. Berrangé <berrange@redhat.com> wrote: > > On Tue, Mar 12, 2024 at 11:08:15AM +0000, Peter Maydell wrote: > > On our gcov CI job, the bufferiszero and crypto-tlscredsx509 > > tests time out occasionally, making the job flaky. Double the > > timeout on these two tests. > > > > Cc: qemu-stable@nongnu.org > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2221 > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> > > --- > > cc stable just because it probably helps CI reliability there too > > --- > > tests/unit/meson.build | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/tests/unit/meson.build b/tests/unit/meson.build > > index cae925c1325..30db3c418fa 100644 > > --- a/tests/unit/meson.build > > +++ b/tests/unit/meson.build > > @@ -173,8 +173,9 @@ test_env.set('G_TEST_BUILDDIR', meson.current_build_dir()) > > > > slow_tests = { > > 'test-aio-multithread' : 120, > > + 'test-bufferiszero': 60, > > 'test-crypto-block' : 300, > > - 'test-crypto-tlscredsx509': 45, > > + 'test-crypto-tlscredsx509': 90, > > 'test-crypto-tlssession': 45, > > I'd probably suggest bumping this to 90 too, as it is a similar order > to CPU burn complexity to the other tls test - both of them create > a huge number of certs for testing many scenarios. > > Either way, > > Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Thanks; I'm going to apply this directly with the tlssession timeout also raised to 90. -- PMM
diff --git a/tests/unit/meson.build b/tests/unit/meson.build index cae925c1325..30db3c418fa 100644 --- a/tests/unit/meson.build +++ b/tests/unit/meson.build @@ -173,8 +173,9 @@ test_env.set('G_TEST_BUILDDIR', meson.current_build_dir()) slow_tests = { 'test-aio-multithread' : 120, + 'test-bufferiszero': 60, 'test-crypto-block' : 300, - 'test-crypto-tlscredsx509': 45, + 'test-crypto-tlscredsx509': 90, 'test-crypto-tlssession': 45, 'test-replication': 60, }
On our gcov CI job, the bufferiszero and crypto-tlscredsx509 tests time out occasionally, making the job flaky. Double the timeout on these two tests. Cc: qemu-stable@nongnu.org Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2221 Signed-off-by: Peter Maydell <peter.maydell@linaro.org> --- cc stable just because it probably helps CI reliability there too --- tests/unit/meson.build | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)