| Message ID | 20240314-sbsa-ref-firmware-update-v2-2-b557c56559cd@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | tests/avocado: update sbsa-ref firmware to latest | expand |
Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org> writes: > sbsa-ref is supposed to emulate real hardware so virtio-rng-pci > does not fit here What is real anyway ;-) VirtIO devices exist in real life and I would argue for PCI the device appears very much like a normal PCI device. I could see the argument for avoiding virtio-mmio devices which are a lot more VM-only in flavour. > > Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org> > --- > tests/avocado/machine_aarch64_sbsaref.py | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/tests/avocado/machine_aarch64_sbsaref.py b/tests/avocado/machine_aarch64_sbsaref.py > index cbab793455..259225f15f 100644 > --- a/tests/avocado/machine_aarch64_sbsaref.py > +++ b/tests/avocado/machine_aarch64_sbsaref.py > @@ -132,10 +132,6 @@ def boot_alpine_linux(self, cpu): > cpu, > "-drive", > f"file={iso_path},format=raw", > - "-device", > - "virtio-rng-pci,rng=rng0", > - "-object", > - "rng-random,id=rng0,filename=/dev/urandom", > ) > > self.vm.launch() > @@ -179,10 +175,6 @@ def boot_openbsd73(self, cpu): > cpu, > "-drive", > f"file={img_path},format=raw", > - "-device", > - "virtio-rng-pci,rng=rng0", > - "-object", > - "rng-random,id=rng0,filename=/dev/urandom", > ) > > self.vm.launch()
On Thu, 14 Mar 2024 at 12:11, Alex Bennée <alex.bennee@linaro.org> wrote: > > Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org> writes: > > > sbsa-ref is supposed to emulate real hardware so virtio-rng-pci > > does not fit here > > What is real anyway ;-) > > VirtIO devices exist in real life and I would argue for PCI the device > appears very much like a normal PCI device. I could see the argument for > avoiding virtio-mmio devices which are a lot more VM-only in flavour. But our platform for testing virtio-rng-pci should be the 'virt' board (and our avocado test for virt does indeed have that device). What exactly are we adding by testing it also in sbsa-ref, where the typical user will *not* be using it (if they wanted a virtio setup they would be using 'virt')? thanks -- PMM
Peter Maydell <peter.maydell@linaro.org> writes: > On Thu, 14 Mar 2024 at 12:11, Alex Bennée <alex.bennee@linaro.org> wrote: >> >> Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org> writes: >> >> > sbsa-ref is supposed to emulate real hardware so virtio-rng-pci >> > does not fit here >> >> What is real anyway ;-) >> >> VirtIO devices exist in real life and I would argue for PCI the device >> appears very much like a normal PCI device. I could see the argument for >> avoiding virtio-mmio devices which are a lot more VM-only in flavour. > > But our platform for testing virtio-rng-pci should be the 'virt' > board (and our avocado test for virt does indeed have that device). > What exactly are we adding by testing it also in sbsa-ref, > where the typical user will *not* be using it (if they wanted > a virtio setup they would be using 'virt')? I assume just ensuring the board has enough entropy to boot cleanly. If it doesn't need it then it doesn't matter I guess. > > thanks > -- PMM
diff --git a/tests/avocado/machine_aarch64_sbsaref.py b/tests/avocado/machine_aarch64_sbsaref.py index cbab793455..259225f15f 100644 --- a/tests/avocado/machine_aarch64_sbsaref.py +++ b/tests/avocado/machine_aarch64_sbsaref.py @@ -132,10 +132,6 @@ def boot_alpine_linux(self, cpu): cpu, "-drive", f"file={iso_path},format=raw", - "-device", - "virtio-rng-pci,rng=rng0", - "-object", - "rng-random,id=rng0,filename=/dev/urandom", ) self.vm.launch() @@ -179,10 +175,6 @@ def boot_openbsd73(self, cpu): cpu, "-drive", f"file={img_path},format=raw", - "-device", - "virtio-rng-pci,rng=rng0", - "-object", - "rng-random,id=rng0,filename=/dev/urandom", ) self.vm.launch()
sbsa-ref is supposed to emulate real hardware so virtio-rng-pci does not fit here Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org> --- tests/avocado/machine_aarch64_sbsaref.py | 8 -------- 1 file changed, 8 deletions(-)