| Message ID | 20240314200419.4733-6-quic_amelende@quicinc.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add GPIO support for various PMICs | expand |
On 14/03/2024 21:04, Anjelique Melendez wrote: > Update the Qualcomm Technologies, Inc. PMIC GPIO binding documentation > to include compatible strings for PMIH010x and PMD802x PMICs. > > Signed-off-by: Anjelique Melendez <quic_amelende@quicinc.com> > --- > .../bindings/pinctrl/qcom,pmic-gpio.yaml | 20 +++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml > index 2b17d244f051..5cc04c016b25 100644 > --- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml > @@ -57,10 +57,12 @@ properties: > - qcom,pma8084-gpio > - qcom,pmc8180-gpio > - qcom,pmc8180c-gpio > + - qcom,pmd802x-gpio Is the "x" some sort of wildcard or actual PMIC model/version name? Wildcards are in general discouraged. Best regards, Krzysztof
On 3/14/2024 2:20 PM, Krzysztof Kozlowski wrote: > On 14/03/2024 21:04, Anjelique Melendez wrote: >> Update the Qualcomm Technologies, Inc. PMIC GPIO binding documentation >> to include compatible strings for PMIH010x and PMD802x PMICs. >> >> Signed-off-by: Anjelique Melendez <quic_amelende@quicinc.com> >> --- >> .../bindings/pinctrl/qcom,pmic-gpio.yaml | 20 +++++++++++++++++++ >> 1 file changed, 20 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml >> index 2b17d244f051..5cc04c016b25 100644 >> --- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml >> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml >> @@ -57,10 +57,12 @@ properties: >> - qcom,pma8084-gpio >> - qcom,pmc8180-gpio >> - qcom,pmc8180c-gpio >> + - qcom,pmd802x-gpio > > Is the "x" some sort of wildcard or actual PMIC model/version name? > Wildcards are in general discouraged. > "x" is being used as a wildcard here so can update with actual PMIC version in next version. Thanks, Anjelique
On 19/03/2024 04:57, Anjelique Melendez wrote: > > > On 3/14/2024 2:20 PM, Krzysztof Kozlowski wrote: >> On 14/03/2024 21:04, Anjelique Melendez wrote: >>> Update the Qualcomm Technologies, Inc. PMIC GPIO binding documentation >>> to include compatible strings for PMIH010x and PMD802x PMICs. >>> >>> Signed-off-by: Anjelique Melendez <quic_amelende@quicinc.com> >>> --- >>> .../bindings/pinctrl/qcom,pmic-gpio.yaml | 20 +++++++++++++++++++ >>> 1 file changed, 20 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml >>> index 2b17d244f051..5cc04c016b25 100644 >>> --- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml >>> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml >>> @@ -57,10 +57,12 @@ properties: >>> - qcom,pma8084-gpio >>> - qcom,pmc8180-gpio >>> - qcom,pmc8180c-gpio >>> + - qcom,pmd802x-gpio >> >> Is the "x" some sort of wildcard or actual PMIC model/version name? >> Wildcards are in general discouraged. >> > > "x" is being used as a wildcard here so can update with actual PMIC version > in next version. > Then please drop it also in all future submissions, as asked by writing bindings. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml index 2b17d244f051..5cc04c016b25 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml @@ -57,10 +57,12 @@ properties: - qcom,pma8084-gpio - qcom,pmc8180-gpio - qcom,pmc8180c-gpio + - qcom,pmd802x-gpio - qcom,pmi632-gpio - qcom,pmi8950-gpio - qcom,pmi8994-gpio - qcom,pmi8998-gpio + - qcom,pmih010x-gpio - qcom,pmk8350-gpio - qcom,pmk8550-gpio - qcom,pmm8155au-gpio @@ -143,6 +145,7 @@ allOf: - qcom,pm8005-gpio - qcom,pm8450-gpio - qcom,pm8916-gpio + - qcom,pmd802x-gpio - qcom,pmk8350-gpio - qcom,pmr735a-gpio - qcom,pmr735b-gpio @@ -304,6 +307,21 @@ allOf: minItems: 1 maxItems: 7 + - if: + properties: + comptaible: + contains: + enum: + - qcom,pmih010x-gpio + then: + properties: + gpio-line-names: + minItems: 18 + maxItems: 18 + gpio-reserved-ranges: + minItems: 1 + maxItems: 9 + - if: properties: compatible: @@ -452,9 +470,11 @@ $defs: - gpio1-gpio22 for pm8994 - gpio1-gpio26 for pm8998 - gpio1-gpio22 for pma8084 + - gpio1-gpio4 for pmd802x - gpio1-gpio8 for pmi632 - gpio1-gpio2 for pmi8950 - gpio1-gpio10 for pmi8994 + - gpio1-gpio18 for pmih010x - gpio1-gpio4 for pmk8350 - gpio1-gpio6 for pmk8550 - gpio1-gpio10 for pmm8155au
Update the Qualcomm Technologies, Inc. PMIC GPIO binding documentation to include compatible strings for PMIH010x and PMD802x PMICs. Signed-off-by: Anjelique Melendez <quic_amelende@quicinc.com> --- .../bindings/pinctrl/qcom,pmic-gpio.yaml | 20 +++++++++++++++++++ 1 file changed, 20 insertions(+)