| Message ID | 20240314232201.2102178-20-jan.dakinevich@salutedevices.com |
|---|---|
| State | New |
| Headers | show |
| Series | Introduce support of audio for Amlogic A1 SoC family | expand |
On Fri 15 Mar 2024 at 02:21, Jan Dakinevich <jan.dakinevich@salutedevices.com> wrote: > Add "amlogic,a1-sound-card" compatible string alias to > "amlogic,axg-sound-card". > > Signed-off-by: Jan Dakinevich <jan.dakinevich@salutedevices.com> > --- > .../devicetree/bindings/sound/amlogic,axg-sound-card.yaml | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/sound/amlogic,axg-sound-card.yaml b/Documentation/devicetree/bindings/sound/amlogic,axg-sound-card.yaml > index 5db718e4d0e7..492b41cc8ccd 100644 > --- a/Documentation/devicetree/bindings/sound/amlogic,axg-sound-card.yaml > +++ b/Documentation/devicetree/bindings/sound/amlogic,axg-sound-card.yaml > @@ -14,7 +14,11 @@ allOf: > > properties: > compatible: > - const: amlogic,axg-sound-card > + oneOf: > + - const: amlogic,axg-sound-card > + - items: > + - const: amlogic,a1-sound-card > + - const: amlogic,axg-sound-card I know the rule about SoC related name but it is different here. This does not describe HW in the SoC. The axg sound card is just a name, much like simple-card or audio-graph-card. I could have named it "amlogic,my-awesome-card" We would not add "amlogic,a1-simple-card", would we ? It is purely a software component, which aggregate HW ones. > audio-aux-devs: > $ref: /schemas/types.yaml#/definitions/phandle-array
On 3/15/24 13:06, Jerome Brunet wrote: > > On Fri 15 Mar 2024 at 02:21, Jan Dakinevich <jan.dakinevich@salutedevices.com> wrote: > >> Add "amlogic,a1-sound-card" compatible string alias to >> "amlogic,axg-sound-card". >> >> Signed-off-by: Jan Dakinevich <jan.dakinevich@salutedevices.com> >> --- >> .../devicetree/bindings/sound/amlogic,axg-sound-card.yaml | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/sound/amlogic,axg-sound-card.yaml b/Documentation/devicetree/bindings/sound/amlogic,axg-sound-card.yaml >> index 5db718e4d0e7..492b41cc8ccd 100644 >> --- a/Documentation/devicetree/bindings/sound/amlogic,axg-sound-card.yaml >> +++ b/Documentation/devicetree/bindings/sound/amlogic,axg-sound-card.yaml >> @@ -14,7 +14,11 @@ allOf: >> >> properties: >> compatible: >> - const: amlogic,axg-sound-card >> + oneOf: >> + - const: amlogic,axg-sound-card >> + - items: >> + - const: amlogic,a1-sound-card >> + - const: amlogic,axg-sound-card > > I know the rule about SoC related name but it is different here. > This does not describe HW in the SoC. > > The axg sound card is just a name, much like simple-card or > audio-graph-card. I could have named it "amlogic,my-awesome-card" > > We would not add "amlogic,a1-simple-card", would we ? > > It is purely a software component, which aggregate HW ones. > > >> audio-aux-devs: >> $ref: /schemas/types.yaml#/definitions/phandle-array > > So, I can drop a couple of commits like this. Right?
diff --git a/Documentation/devicetree/bindings/sound/amlogic,axg-sound-card.yaml b/Documentation/devicetree/bindings/sound/amlogic,axg-sound-card.yaml index 5db718e4d0e7..492b41cc8ccd 100644 --- a/Documentation/devicetree/bindings/sound/amlogic,axg-sound-card.yaml +++ b/Documentation/devicetree/bindings/sound/amlogic,axg-sound-card.yaml @@ -14,7 +14,11 @@ allOf: properties: compatible: - const: amlogic,axg-sound-card + oneOf: + - const: amlogic,axg-sound-card + - items: + - const: amlogic,a1-sound-card + - const: amlogic,axg-sound-card audio-aux-devs: $ref: /schemas/types.yaml#/definitions/phandle-array
Add "amlogic,a1-sound-card" compatible string alias to "amlogic,axg-sound-card". Signed-off-by: Jan Dakinevich <jan.dakinevich@salutedevices.com> --- .../devicetree/bindings/sound/amlogic,axg-sound-card.yaml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)