@@ -522,7 +522,7 @@ show_sas_device_type(struct device *dev,
struct sas_phy *phy = transport_class_to_phy(dev);
if (!phy->identify.device_type)
- return snprintf(buf, 20, "none\n");
+ return sysfs_emit(buf, "none\n");
return get_sas_device_type_names(phy->identify.device_type, buf);
}
static DEVICE_ATTR(device_type, S_IRUGO, show_sas_device_type, NULL);
@@ -569,7 +569,7 @@ show_sas_phy_enable(struct device *dev, struct device_attribute *attr,
{
struct sas_phy *phy = transport_class_to_phy(dev);
- return snprintf(buf, 20, "%d\n", phy->enabled);
+ return sysfs_emit(buf, "%d\n", phy->enabled);
}
static DEVICE_ATTR(enable, S_IRUGO | S_IWUSR, show_sas_phy_enable,
@@ -1177,7 +1177,7 @@ show_sas_rphy_device_type(struct device *dev,
struct sas_rphy *rphy = transport_class_to_rphy(dev);
if (!rphy->identify.device_type)
- return snprintf(buf, 20, "none\n");
+ return sysfs_emit(buf, "none\n");
return get_sas_device_type_names(
rphy->identify.device_type, buf);
}
@@ -1199,7 +1199,7 @@ show_sas_rphy_enclosure_identifier(struct device *dev,
error = i->f->get_enclosure_identifier(rphy, &identifier);
if (error)
return error;
- return sprintf(buf, "0x%llx\n", (unsigned long long)identifier);
+ return sysfs_emit(buf, "0x%llx\n", (unsigned long long)identifier);
}
static SAS_DEVICE_ATTR(rphy, enclosure_identifier, S_IRUGO,
@@ -1218,7 +1218,7 @@ show_sas_rphy_bay_identifier(struct device *dev,
val = i->f->get_bay_identifier(rphy);
if (val < 0)
return val;
- return sprintf(buf, "%d\n", val);
+ return sysfs_emit(buf, "%d\n", val);
}
static SAS_DEVICE_ATTR(rphy, bay_identifier, S_IRUGO,
Per filesystems/sysfs.rst, show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. coccinelle complains that there are still a couple of functions that use snprintf(). Convert them to sysfs_emit(). sprintf() and scnprintf() will be converted as well if they have. Generally, this patch is generated by make coccicheck M=<path/to/file> MODE=patch \ COCCI=scripts/coccinelle/api/device_attr_show.cocci No functional change intended CC: "James E.J. Bottomley" <jejb@linux.ibm.com> CC: "Martin K. Petersen" <martin.petersen@oracle.com> CC: linux-scsi@vger.kernel.org Signed-off-by: Li Zhijian <lizhijian@fujitsu.com> --- This is a part of the work "Fix coccicheck device_attr_show warnings"[1] Split them per subsystem so that the maintainer can review it easily [1] https://lore.kernel.org/lkml/20240116041129.3937800-1-lizhijian@fujitsu.com/ --- drivers/scsi/scsi_transport_sas.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)