| Message ID | 20240318052600.671908-1-dankamongmen@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | usb: always print reset/new device message | expand |
On Mon, Mar 18, 2024 at 01:25:23AM -0400, nick black wrote: > Since usb_speed_string() always returns a valid string > (invalid speeds turn into "UNKNOWN"), go ahead and > always print this diagnostic, rather than checking the > speed here (which wasn't up to date for SPEED_SUPER_PLUS, > and looks like it had an off-by-one error anyway). This change isn't needed. For speeds >= SPEED_SUPER, the corresponding information is printed in the vicinity of line 5027. Alan Stern > Signed-off-by: nick black <dankamongmen@gmail.com> > --- > drivers/usb/core/hub.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c > index e38a4124f610..7325e5420900 100644 > --- a/drivers/usb/core/hub.c > +++ b/drivers/usb/core/hub.c > @@ -4909,11 +4909,10 @@ hub_port_init(struct usb_hub *hub, struct usb_device *udev, int port1, > else > driver_name = udev->bus->sysdev->driver->name; > > - if (udev->speed < USB_SPEED_SUPER) > - dev_info(&udev->dev, > - "%s %s USB device number %d using %s\n", > - (initial ? "new" : "reset"), speed, > - devnum, driver_name); > + dev_info(&udev->dev, > + "%s %s USB device number %d using %s\n", > + (initial ? "new" : "reset"), speed, > + devnum, driver_name); > > if (initial) { > /* Set up TT records, if needed */ > -- > 2.43.0 >
diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index e38a4124f610..7325e5420900 100644 --- a/drivers/usb/core/hub.c +++ b/drivers/usb/core/hub.c @@ -4909,11 +4909,10 @@ hub_port_init(struct usb_hub *hub, struct usb_device *udev, int port1, else driver_name = udev->bus->sysdev->driver->name; - if (udev->speed < USB_SPEED_SUPER) - dev_info(&udev->dev, - "%s %s USB device number %d using %s\n", - (initial ? "new" : "reset"), speed, - devnum, driver_name); + dev_info(&udev->dev, + "%s %s USB device number %d using %s\n", + (initial ? "new" : "reset"), speed, + devnum, driver_name); if (initial) { /* Set up TT records, if needed */
Since usb_speed_string() always returns a valid string (invalid speeds turn into "UNKNOWN"), go ahead and always print this diagnostic, rather than checking the speed here (which wasn't up to date for SPEED_SUPER_PLUS, and looks like it had an off-by-one error anyway). Signed-off-by: nick black <dankamongmen@gmail.com> --- drivers/usb/core/hub.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)