| Message ID | afc30fd4d201bdd92ffbc682ac66f472ce837814.1711389066.git.pav@iki.fi |
|---|---|
| State | New |
| Headers | show |
| Series | [BlueZ,v3,1/2] shared/bap: add bt_bap_cancel_select to cancel ongoing pac select | expand |
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=838006
---Test result---
Test Summary:
CheckPatch PASS 0.92 seconds
GitLint PASS 0.61 seconds
BuildEll PASS 25.79 seconds
BluezMake PASS 1832.67 seconds
MakeCheck PASS 13.67 seconds
MakeDistcheck PASS 188.76 seconds
CheckValgrind PASS 260.94 seconds
CheckSmatch WARNING 370.41 seconds
bluezmakeextell PASS 129.74 seconds
IncrementalBuild PASS 3157.23 seconds
ScanBuild WARNING 1070.47 seconds
Details
##############################
Test: CheckSmatch - WARNING
Desc: Run smatch tool with source
Output:
src/shared/bap.c:282:25: warning: array of flexible structuressrc/shared/bap.c: note: in included file:./src/shared/ascs.h:88:25: warning: array of flexible structuressrc/shared/bap.c:282:25: warning: array of flexible structuressrc/shared/bap.c: note: in included file:./src/shared/ascs.h:88:25: warning: array of flexible structuressrc/shared/bap.c:282:25: warning: array of flexible structuressrc/shared/bap.c: note: in included file:./src/shared/ascs.h:88:25: warning: array of flexible structures
##############################
Test: ScanBuild - WARNING
Desc: Run Scan Build
Output:
profiles/audio/media.c:1046:7: warning: Use of memory after it is freed
if (req->cb != pac_select_cb) {
^~~~~~~
1 warning generated.
---
Regards,
Linux Bluetooth
Hello: This series was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Mon, 25 Mar 2024 19:52:09 +0200 you wrote: > Add function and PAC ops for canceling a previously initiated > SelectProperties() call. > --- > > Notes: > v3: fix wrong usage of g_slist_next > v2: cancel the DBus request and callback, instead of ignoring stale cbs > > [...] Here is the summary with links: - [BlueZ,v3,1/2] shared/bap: add bt_bap_cancel_select to cancel ongoing pac select https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=6849c64e1fdb - [BlueZ,v3,2/2] bap: cancel ongoing SelectProperties() before freeing the ep https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=41d6c4e1c92f You are awesome, thank you!
diff --git a/src/shared/bap.c b/src/shared/bap.c index a1749153b..f553096df 100644 --- a/src/shared/bap.c +++ b/src/shared/bap.c @@ -5180,6 +5180,18 @@ int bt_bap_select(struct bt_bap_pac *lpac, struct bt_bap_pac *rpac, return 0; } +void bt_bap_cancel_select(struct bt_bap_pac *lpac, bt_bap_pac_select_t func, + void *user_data) +{ + if (!lpac || !func) + return; + + if (!lpac->ops || !lpac->ops->cancel_select) + return; + + lpac->ops->cancel_select(lpac, func, user_data, lpac->user_data); +} + static struct bt_bap_stream *bap_bcast_stream_new(struct bt_bap *bap, struct bt_bap_pac *lpac, struct bt_bap_pac *rpac, diff --git a/src/shared/bap.h b/src/shared/bap.h index 9839e3249..62e210485 100644 --- a/src/shared/bap.h +++ b/src/shared/bap.h @@ -72,6 +72,8 @@ struct bt_bap_pac_ops { int (*select)(struct bt_bap_pac *lpac, struct bt_bap_pac *rpac, uint32_t chan_alloc, struct bt_bap_pac_qos *qos, bt_bap_pac_select_t cb, void *cb_data, void *user_data); + void (*cancel_select)(struct bt_bap_pac *lpac, + bt_bap_pac_select_t cb, void *cb_data, void *user_data); int (*config)(struct bt_bap_stream *stream, struct iovec *cfg, struct bt_bap_qos *qos, bt_bap_pac_config_t cb, void *user_data); @@ -160,6 +162,9 @@ int bt_bap_select(struct bt_bap_pac *lpac, struct bt_bap_pac *rpac, int *count, bt_bap_pac_select_t func, void *user_data); +void bt_bap_cancel_select(struct bt_bap_pac *lpac, bt_bap_pac_select_t func, + void *user_data); + struct bt_bap_stream *bt_bap_stream_new(struct bt_bap *bap, struct bt_bap_pac *lpac, struct bt_bap_pac *rpac,
Add function and PAC ops for canceling a previously initiated SelectProperties() call. --- Notes: v3: fix wrong usage of g_slist_next v2: cancel the DBus request and callback, instead of ignoring stale cbs src/shared/bap.c | 12 ++++++++++++ src/shared/bap.h | 5 +++++ 2 files changed, 17 insertions(+)