| Message ID | 20240325131624.26023-5-brgl@bgdev.pl |
|---|---|
| State | Superseded |
| Headers | show |
| Series | power: sequencing: implement the subsystem and add first users | expand |
On Tue, Mar 26, 2024 at 4:12 PM Kalle Valo <kvalo@kernel.org> wrote: > > Bartosz Golaszewski <brgl@bgdev.pl> writes: > > >> >> I don't know DT well enough to know what the "required:" above means, > >> >> but does this take into account that there are normal "plug&play" type > >> >> of QCA6390 boards as well which don't need any DT settings? > >> > > >> > Do they require a DT node though for some reason? > >> > >> You can attach the device to any PCI slot, connect the WLAN antenna and > >> it just works without DT nodes. I'm trying to make sure here that basic > >> setup still works. > >> > > > > Sure, definitely. I there's no DT node, then the binding doesn't apply > > and the driver (the platform part of it) will not probe. > > > >> Adding also Johan and ath11k list. For example, I don't know what's the > >> plan with Lenovo X13s, will it use this framework? I guess in theory we > >> could have devices which use qcom,ath11k-calibration-variant from DT but > >> not any of these supply properties? > >> > > > > Good point. I will receive the X13s in a month from now. I do plan on > > upstreaming correct support for WLAN and BT for it as well. > > > > I guess we can always relax the requirements once a valid use-case appears? > > I think we have such cases already now: > > $ git grep ath11k-calibration-variant -- arch > arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts: qcom,ath11k-calibration-variant = "Fairphone_5"; > arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts: qcom,ath11k-calibration-variant = "LE_X13S"; > > But please do check that. I'm no DT expert :) > You're thinking about making the required: field depend on the value of qcom,ath11k-calibration-variant? Am I getting this right? Bart
diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml index 41d023797d7d..8675d7d0215c 100644 --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml @@ -17,6 +17,7 @@ description: | properties: compatible: enum: + - pci17cb,1101 # QCA6390 - pci17cb,1103 # WCN6855 reg: @@ -28,10 +29,55 @@ properties: string to uniquely identify variant of the calibration data for designs with colliding bus and device ids + vddrfacmn-supply: + description: VDD_RFA_CMN supply regulator handle + + vddaon-supply: + description: VDD_AON supply regulator handle + + vddwlcx-supply: + description: VDD_WL_CX supply regulator handle + + vddwlmx-supply: + description: VDD_WL_MX supply regulator handle + + vddrfa0p8-supply: + description: VDD_RFA_0P8 supply regulator handle + + vddrfa1p2-supply: + description: VDD_RFA_1P2 supply regulator handle + + vddrfa1p7-supply: + description: VDD_RFA_1P7 supply regulator handle + + vddpcie0p9-supply: + description: VDD_PCIE_0P9 supply regulator handle + + vddpcie1p8-supply: + description: VDD_PCIE_1P8 supply regulator handle + required: - compatible - reg +allOf: + - if: + properties: + compatible: + contains: + const: pci17cb,1101 + then: + required: + - vddrfacmn-supply + - vddaon-supply + - vddwlcx-supply + - vddwlmx-supply + - vddrfa0p8-supply + - vddrfa1p2-supply + - vddrfa1p7-supply + - vddpcie0p9-supply + - vddpcie1p8-supply + additionalProperties: false examples: