| Message ID | 20230911-topic-mars-v3-3-79f23b81c261@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | [v3,01/19] media: venus: pm_helpers: Only set rate of the core clock in core_clks_enable | expand |
Hi Konrad, On 4/5/2024 1:56 PM, Dikshita Agarwal wrote: > > > On 3/27/2024 11:38 PM, Konrad Dybcio wrote: >> To make it easier to understand the various clock requirements within >> this driver, add kerneldoc to venus_clk_get() explaining the fluff. >> >> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> >> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> >> --- >> drivers/media/platform/qcom/venus/pm_helpers.c | 28 ++++++++++++++++++++++++++ >> 1 file changed, 28 insertions(+) >> >> diff --git a/drivers/media/platform/qcom/venus/pm_helpers.c b/drivers/media/platform/qcom/venus/pm_helpers.c >> index ac7c83404c6e..cf91f50a33aa 100644 >> --- a/drivers/media/platform/qcom/venus/pm_helpers.c >> +++ b/drivers/media/platform/qcom/venus/pm_helpers.c >> @@ -23,6 +23,34 @@ >> >> static bool legacy_binding; >> >> +/** >> + * venus_clks_get() - Get Venus clocks that are not bound to a vcodec >> + * @core: A pointer to the venus core resource >> + * >> + * The Venus block (depending on the generation) can be split into a couple >> + * of clock domains: one for main logic and one for each video core (0-2 instances). s/main logic/controller. Applies to below places as well. >> + * >> + * MSM8916 (and possibly other HFIv1 users) only feature the "main logic" >> + * domain, so this function is the only kind if clk_get necessary there. To be checked, unable to get the clock document to see why only core clock (VENUS0_VCODEC0_CLK). Will update. >> + * >> + * MSM8996 (and other HFIv3 users) feature two video cores, with core0 being >> + * statically defined a decoder and core1 an encoder, with both having >> + * their own clock domains. >> + * >> + * SDM845 features two video cores, each one of which may or may not be s/two video cores/two identical video cores >> + * subdivided into two encoder/decoder threads. decoder cannot be split into core threads. you can keep it like "each of which is capable to do any encode or decode" >> + * >> + * Other SoCs either feature a single video core (with its own clock domain) >> + * or one video core and one CVP (Computer Vision Processor) core. In both cases >> + * we treat it the same way (CVP only happens to live near-by Venus on the SoC). >> + * >> + * Due to unfortunate developments in the past, we need to support legacy > why unfortunate? please re-phrase this. >> + * bindings (MSM8996, SDM660, SDM845) that require specifying the clocks and >> + * power-domains associated with a video core domain in a bogus sub-node, >> + * which means that additional fluff is necessary. Some background: It was done that way to support decoder core with specific clocks and similarly for encoder. Earlier architectures use to have different clock source for these specific decoder/encoder core clocks, now there is a common clock source for both the cores. Hence if any one is enabled, others gets enabled as it is derived from same source. So if we see the later bindings, the clocks were moved out of sub node to main venus node. Regards, Vikash >> + * >> + * Return: 0 on success, negative errno on failure. >> + */ >> static int venus_clks_get(struct venus_core *core) >> { >> const struct venus_resources *res = core->res; >> > > Thanks, > Dikshita
On 4/5/24 10:26, Dikshita Agarwal wrote: > > > On 3/27/2024 11:38 PM, Konrad Dybcio wrote: >> To make it easier to understand the various clock requirements within >> this driver, add kerneldoc to venus_clk_get() explaining the fluff. >> >> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> >> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> >> --- >> drivers/media/platform/qcom/venus/pm_helpers.c | 28 ++++++++++++++++++++++++++ >> 1 file changed, 28 insertions(+) >> >> diff --git a/drivers/media/platform/qcom/venus/pm_helpers.c b/drivers/media/platform/qcom/venus/pm_helpers.c >> index ac7c83404c6e..cf91f50a33aa 100644 >> --- a/drivers/media/platform/qcom/venus/pm_helpers.c >> +++ b/drivers/media/platform/qcom/venus/pm_helpers.c >> @@ -23,6 +23,34 @@ >> >> static bool legacy_binding; >> >> +/** >> + * venus_clks_get() - Get Venus clocks that are not bound to a vcodec >> + * @core: A pointer to the venus core resource >> + * >> + * The Venus block (depending on the generation) can be split into a couple >> + * of clock domains: one for main logic and one for each video core (0-2 instances). >> + * >> + * MSM8916 (and possibly other HFIv1 users) only feature the "main logic" >> + * domain, so this function is the only kind if clk_get necessary there. >> + * >> + * MSM8996 (and other HFIv3 users) feature two video cores, with core0 being >> + * statically defined a decoder and core1 an encoder, with both having >> + * their own clock domains. >> + * >> + * SDM845 features two video cores, each one of which may or may not be >> + * subdivided into two encoder/decoder threads. >> + * >> + * Other SoCs either feature a single video core (with its own clock domain) >> + * or one video core and one CVP (Computer Vision Processor) core. In both cases >> + * we treat it the same way (CVP only happens to live near-by Venus on the SoC). >> + * >> + * Due to unfortunate developments in the past, we need to support legacy > why unfortunate? please re-phrase this. It's unfortunate because another binding has been created to represent the same hardware to solve a "problem" that could have been dealt with using a couple lines of C and that we now need to carry support for. Konrad
On 4/5/24 14:44, Vikash Garodia wrote: > Hi Konrad, > > On 4/5/2024 1:56 PM, Dikshita Agarwal wrote: >> >> >> On 3/27/2024 11:38 PM, Konrad Dybcio wrote: >>> To make it easier to understand the various clock requirements within >>> this driver, add kerneldoc to venus_clk_get() explaining the fluff. >>> >>> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> >>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> >>> --- >>> drivers/media/platform/qcom/venus/pm_helpers.c | 28 ++++++++++++++++++++++++++ >>> 1 file changed, 28 insertions(+) >>> >>> diff --git a/drivers/media/platform/qcom/venus/pm_helpers.c b/drivers/media/platform/qcom/venus/pm_helpers.c >>> index ac7c83404c6e..cf91f50a33aa 100644 >>> --- a/drivers/media/platform/qcom/venus/pm_helpers.c >>> +++ b/drivers/media/platform/qcom/venus/pm_helpers.c >>> @@ -23,6 +23,34 @@ >>> >>> static bool legacy_binding; >>> >>> +/** >>> + * venus_clks_get() - Get Venus clocks that are not bound to a vcodec >>> + * @core: A pointer to the venus core resource >>> + * >>> + * The Venus block (depending on the generation) can be split into a couple >>> + * of clock domains: one for main logic and one for each video core (0-2 instances). > s/main logic/controller. Applies to below places as well. Ok - so "controller" is the cortex-m3 (m5?) that power-sequences the DSP etc.? > >>> + * >>> + * MSM8916 (and possibly other HFIv1 users) only feature the "main logic" >>> + * domain, so this function is the only kind if clk_get necessary there. > To be checked, unable to get the clock document to see why only core clocks > (VENUS0_VCODEC0_CLK). Will update. FWIW 8916 only has GCC_VENUS0_VCODEC0_CLK (and _SRC) and AHB/AXI/TBU clocks, no (currently registered) clock for the entire block. > >>> + * >>> + * MSM8996 (and other HFIv3 users) feature two video cores, with core0 being >>> + * statically defined a decoder and core1 an encoder, with both having >>> + * their own clock domains. >>> + * >>> + * SDM845 features two video cores, each one of which may or may not be > s/two video cores/two identical video cores >>> + * subdivided into two encoder/decoder threads. > decoder cannot be split into core threads. you can keep it like "each of which > is capable to do any encode or decode" So it's not about any splitting, but rather the ability to do both encode and decode, sort of like how the displayport controller can nowadays do both eDP and DP, depending on what init data you send to it? > >>> + * >>> + * Other SoCs either feature a single video core (with its own clock domain) >>> + * or one video core and one CVP (Computer Vision Processor) core. In both cases >>> + * we treat it the same way (CVP only happens to live near-by Venus on the SoC). >>> + * >>> + * Due to unfortunate developments in the past, we need to support legacy >> why unfortunate? please re-phrase this. >>> + * bindings (MSM8996, SDM660, SDM845) that require specifying the clocks and >>> + * power-domains associated with a video core domain in a bogus sub-node, >>> + * which means that additional fluff is necessary. > Some background: > It was done that way to support decoder core with specific clocks and similarly > for encoder. Earlier architectures use to have different clock source for these > specific decoder/encoder core clocks, now there is a common clock source for > both the cores. Hence if any one is enabled, others gets enabled as it is > derived from same source. > So if we see the later bindings, the clocks were moved out of sub node to main > venus node. Yeah and I don't really see the reason why the binding needed to be changed for this, you can simply get the clocks by name and poke at the specific clk* (or an array of them), no matter where they were _get()-ed from. Konrad
On 4/9/2024 11:52 PM, Konrad Dybcio wrote: > > > On 4/5/24 14:44, Vikash Garodia wrote: >> Hi Konrad, >> >> On 4/5/2024 1:56 PM, Dikshita Agarwal wrote: >>> >>> >>> On 3/27/2024 11:38 PM, Konrad Dybcio wrote: >>>> To make it easier to understand the various clock requirements within >>>> this driver, add kerneldoc to venus_clk_get() explaining the fluff. >>>> >>>> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> >>>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> >>>> --- >>>> drivers/media/platform/qcom/venus/pm_helpers.c | 28 >>>> ++++++++++++++++++++++++++ >>>> 1 file changed, 28 insertions(+) >>>> >>>> diff --git a/drivers/media/platform/qcom/venus/pm_helpers.c >>>> b/drivers/media/platform/qcom/venus/pm_helpers.c >>>> index ac7c83404c6e..cf91f50a33aa 100644 >>>> --- a/drivers/media/platform/qcom/venus/pm_helpers.c >>>> +++ b/drivers/media/platform/qcom/venus/pm_helpers.c >>>> @@ -23,6 +23,34 @@ >>>> static bool legacy_binding; >>>> +/** >>>> + * venus_clks_get() - Get Venus clocks that are not bound to a vcodec >>>> + * @core: A pointer to the venus core resource >>>> + * >>>> + * The Venus block (depending on the generation) can be split into a couple >>>> + * of clock domains: one for main logic and one for each video core (0-2 >>>> instances). >> s/main logic/controller. Applies to below places as well. > > Ok - so "controller" is the cortex-m3 (m5?) that power-sequences > the DSP etc.? Thats correct. The firmware runs on the controller and takes care of many aspects of hardware (dsp or core) programming. >> >>>> + * >>>> + * MSM8916 (and possibly other HFIv1 users) only feature the "main logic" >>>> + * domain, so this function is the only kind if clk_get necessary there. >> To be checked, unable to get the clock document to see why only core clocks >> (VENUS0_VCODEC0_CLK). Will update. > > FWIW 8916 only has GCC_VENUS0_VCODEC0_CLK (and _SRC) and AHB/AXI/TBU clocks, > no (currently registered) clock for the entire block. > >> >>>> + * >>>> + * MSM8996 (and other HFIv3 users) feature two video cores, with core0 being >>>> + * statically defined a decoder and core1 an encoder, with both having >>>> + * their own clock domains. >>>> + * >>>> + * SDM845 features two video cores, each one of which may or may not be >> s/two video cores/two identical video cores >>>> + * subdivided into two encoder/decoder threads. >> decoder cannot be split into core threads. you can keep it like "each of which >> is capable to do any encode or decode" > > So it's not about any splitting, but rather the ability to do both encode > and decode, sort of like how the displayport controller can nowadays do both > eDP and DP, depending on what init data you send to it? It is precisely that way, just that there are cases of cores with dedicated codec support, hence identical implies that each of them can do same processing. >> >>>> + * >>>> + * Other SoCs either feature a single video core (with its own clock domain) >>>> + * or one video core and one CVP (Computer Vision Processor) core. In both >>>> cases >>>> + * we treat it the same way (CVP only happens to live near-by Venus on the >>>> SoC). >>>> + * >>>> + * Due to unfortunate developments in the past, we need to support legacy >>> why unfortunate? please re-phrase this. >>>> + * bindings (MSM8996, SDM660, SDM845) that require specifying the clocks and >>>> + * power-domains associated with a video core domain in a bogus sub-node, >>>> + * which means that additional fluff is necessary. >> Some background: >> It was done that way to support decoder core with specific clocks and similarly >> for encoder. Earlier architectures use to have different clock source for these >> specific decoder/encoder core clocks, now there is a common clock source for >> both the cores. Hence if any one is enabled, others gets enabled as it is >> derived from same source. >> So if we see the later bindings, the clocks were moved out of sub node to main >> venus node. > > Yeah and I don't really see the reason why the binding needed to be changed > for this, you can simply get the clocks by name and poke at the specific clk* > (or an array of them), no matter where they were _get()-ed from. I think the reason for not doing a name based clock as it might be possible that the clock is not available or applicable to subsequent SOC. Regards, Vikash
diff --git a/drivers/media/platform/qcom/venus/pm_helpers.c b/drivers/media/platform/qcom/venus/pm_helpers.c index ac7c83404c6e..cf91f50a33aa 100644 --- a/drivers/media/platform/qcom/venus/pm_helpers.c +++ b/drivers/media/platform/qcom/venus/pm_helpers.c @@ -23,6 +23,34 @@ static bool legacy_binding; +/** + * venus_clks_get() - Get Venus clocks that are not bound to a vcodec + * @core: A pointer to the venus core resource + * + * The Venus block (depending on the generation) can be split into a couple + * of clock domains: one for main logic and one for each video core (0-2 instances). + * + * MSM8916 (and possibly other HFIv1 users) only feature the "main logic" + * domain, so this function is the only kind if clk_get necessary there. + * + * MSM8996 (and other HFIv3 users) feature two video cores, with core0 being + * statically defined a decoder and core1 an encoder, with both having + * their own clock domains. + * + * SDM845 features two video cores, each one of which may or may not be + * subdivided into two encoder/decoder threads. + * + * Other SoCs either feature a single video core (with its own clock domain) + * or one video core and one CVP (Computer Vision Processor) core. In both cases + * we treat it the same way (CVP only happens to live near-by Venus on the SoC). + * + * Due to unfortunate developments in the past, we need to support legacy + * bindings (MSM8996, SDM660, SDM845) that require specifying the clocks and + * power-domains associated with a video core domain in a bogus sub-node, + * which means that additional fluff is necessary.. + * + * Return: 0 on success, negative errno on failure. + */ static int venus_clks_get(struct venus_core *core) { const struct venus_resources *res = core->res;