| Message ID | 20240329105634.712457-12-andy.shevchenko@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | aw9523: number of cleanups | expand |
On Fri, Mar 29, 2024 at 11:56 AM Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > Driver does not dependent on OF, remove it. > While here, add missing mod_devicetable.h. > > Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com> Oh the kbuild complains about this one because the driver uses some DT-only helpers. How typical. I kept patches 1-10 and dropped this one. Yours, Linus Walleij
On Thu, Apr 4, 2024 at 2:20 PM Linus Walleij <linus.walleij@linaro.org> wrote: > On Fri, Mar 29, 2024 at 11:56 AM Andy Shevchenko > <andy.shevchenko@gmail.com> wrote: > > > Driver does not dependent on OF, remove it. > > While here, add missing mod_devicetable.h. > > > > Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com> > > Oh the kbuild complains about this one because the driver uses some > DT-only helpers. How typical. I kept patches 1-10 and dropped this > one. Thanks, you beat me to it, I was wanting to ask you to do exactly this.
diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig index d45657aa986ae..c413109b1173b 100644 --- a/drivers/pinctrl/Kconfig +++ b/drivers/pinctrl/Kconfig @@ -129,7 +129,7 @@ config PINCTRL_AXP209 config PINCTRL_AW9523 tristate "Awinic AW9523/AW9523B I2C GPIO expander pinctrl driver" - depends on OF && I2C + depends on I2C select PINMUX select PINCONF select GENERIC_PINCONF diff --git a/drivers/pinctrl/pinctrl-aw9523.c b/drivers/pinctrl/pinctrl-aw9523.c index b5e1c467625ba..1d0ce78115da7 100644 --- a/drivers/pinctrl/pinctrl-aw9523.c +++ b/drivers/pinctrl/pinctrl-aw9523.c @@ -12,6 +12,7 @@ #include <linux/init.h> #include <linux/interrupt.h> #include <linux/irq.h> +#include <linux/mod_devicetable.h> #include <linux/module.h> #include <linux/mutex.h> #include <linux/property.h>
Driver does not dependent on OF, remove it. While here, add missing mod_devicetable.h. Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com> --- drivers/pinctrl/Kconfig | 2 +- drivers/pinctrl/pinctrl-aw9523.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-)