| Message ID | 20240403165425.114844-1-Yaroslav.Furman@softeq.com |
|---|---|
| State | Accepted |
| Commit | 21f28a7eb78dea6c59be6b0a5e0b47bf3d25fcbb |
| Headers | show |
| Series | [v3] HID: logitech-dj: allow mice to use all types of reports | expand |
Hi, On 4/3/24 6:54 PM, Yaroslav Furman wrote: > From: Yaraslau Furman <yaro330@gmail.com> > > You can bind whatever action you want to the mouse's reprogrammable > buttons using Windows application. Allow Linux to receive multimedia keycodes. > > Signed-off-by: Yaraslau Furman <yaro330@gmail.com> Thanks, patch looks good to me: Reviewed-by: Hans de Goede <hdegoede@redhat.com> Regards, Hans > --- > drivers/hid/hid-logitech-dj.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/hid/hid-logitech-dj.c b/drivers/hid/hid-logitech-dj.c > index e6a8b6d8eab7..3c3c497b6b91 100644 > --- a/drivers/hid/hid-logitech-dj.c > +++ b/drivers/hid/hid-logitech-dj.c > @@ -965,9 +965,7 @@ static void logi_hidpp_dev_conn_notif_equad(struct hid_device *hdev, > } > break; > case REPORT_TYPE_MOUSE: > - workitem->reports_supported |= STD_MOUSE | HIDPP; > - if (djrcv_dev->type == recvr_type_mouse_only) > - workitem->reports_supported |= MULTIMEDIA; > + workitem->reports_supported |= STD_MOUSE | HIDPP | MULTIMEDIA; > break; > } > }
diff --git a/drivers/hid/hid-logitech-dj.c b/drivers/hid/hid-logitech-dj.c index e6a8b6d8eab7..3c3c497b6b91 100644 --- a/drivers/hid/hid-logitech-dj.c +++ b/drivers/hid/hid-logitech-dj.c @@ -965,9 +965,7 @@ static void logi_hidpp_dev_conn_notif_equad(struct hid_device *hdev, } break; case REPORT_TYPE_MOUSE: - workitem->reports_supported |= STD_MOUSE | HIDPP; - if (djrcv_dev->type == recvr_type_mouse_only) - workitem->reports_supported |= MULTIMEDIA; + workitem->reports_supported |= STD_MOUSE | HIDPP | MULTIMEDIA; break; } }