| Message ID | 20240405-topic-sm8x50-spmi-clients-v1-3-c28603ebcf18@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | qcom: support SPMI buttons on SM8550 and SM8650 | expand |
On 05/04/2024 10:27, Neil Armstrong wrote: > Finally add the entries for the qcom,pmk8350-pwrkey and qcom,pmk8350-resin > found on PMICs used with SM8350 and later SoCs. > > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > --- > drivers/button/button-qcom-pmic.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/drivers/button/button-qcom-pmic.c b/drivers/button/button-qcom-pmic.c > index f6da958097c..6153601017b 100644 > --- a/drivers/button/button-qcom-pmic.c > +++ b/drivers/button/button-qcom-pmic.c > @@ -36,6 +36,8 @@ struct qcom_pmic_btn_priv { > #define PON_INT_RT_STS 0x10 > #define PON_KPDPWR_N_SET 0 > #define PON_RESIN_N_SET 1 > +#define PON_GEN3_RESIN_N_SET 6 > +#define PON_GEN3_KPDPWR_N_SET 7 > > static enum button_state_t qcom_pwrkey_get_state(struct udevice *dev) > { > @@ -69,6 +71,18 @@ static const struct qcom_pmic_btn_data qcom_pmic_btn_data_table[] = { > .code = KEY_DOWN, > .label = "vol_down", > }, > + { > + .compatible = "qcom,pmk8350-pwrkey", > + .status_bit = PON_GEN3_KPDPWR_N_SET, > + .code = KEY_ENTER, > + .label = "pwrkey", > + }, > + { > + .compatible = "qcom,pmk8350-resin", > + .status_bit = PON_GEN3_RESIN_N_SET, > + .code = KEY_DOWN, > + .label = "vol_down", > + }, > }; > > static const struct qcom_pmic_btn_data *button_qcom_pmic_match(ofnode node) > Missing change: diff --git a/drivers/button/button-qcom-pmic.c b/drivers/button/button-qcom-pmic.c index 6153601017b..ad7fed3ddaa 100644 --- a/drivers/button/button-qcom-pmic.c +++ b/drivers/button/button-qcom-pmic.c @@ -193,6 +193,7 @@ static const struct udevice_id qcom_pwrkey_ids[] = { { .compatible = "qcom,pm8916-pon" }, { .compatible = "qcom,pm8941-pon" }, { .compatible = "qcom,pm8998-pon" }, + { .compatible = "qcom,pmk8350-pon" }, { } }; Will send a v2 in a few days. Neil
diff --git a/drivers/button/button-qcom-pmic.c b/drivers/button/button-qcom-pmic.c index f6da958097c..6153601017b 100644 --- a/drivers/button/button-qcom-pmic.c +++ b/drivers/button/button-qcom-pmic.c @@ -36,6 +36,8 @@ struct qcom_pmic_btn_priv { #define PON_INT_RT_STS 0x10 #define PON_KPDPWR_N_SET 0 #define PON_RESIN_N_SET 1 +#define PON_GEN3_RESIN_N_SET 6 +#define PON_GEN3_KPDPWR_N_SET 7 static enum button_state_t qcom_pwrkey_get_state(struct udevice *dev) { @@ -69,6 +71,18 @@ static const struct qcom_pmic_btn_data qcom_pmic_btn_data_table[] = { .code = KEY_DOWN, .label = "vol_down", }, + { + .compatible = "qcom,pmk8350-pwrkey", + .status_bit = PON_GEN3_KPDPWR_N_SET, + .code = KEY_ENTER, + .label = "pwrkey", + }, + { + .compatible = "qcom,pmk8350-resin", + .status_bit = PON_GEN3_RESIN_N_SET, + .code = KEY_DOWN, + .label = "vol_down", + }, }; static const struct qcom_pmic_btn_data *button_qcom_pmic_match(ofnode node)
Finally add the entries for the qcom,pmk8350-pwrkey and qcom,pmk8350-resin found on PMICs used with SM8350 and later SoCs. Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> --- drivers/button/button-qcom-pmic.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+)