Message ID | 20240410130557.31572-2-tzimmermann@suse.de |
---|---|
State | Superseded |
Headers | show
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6EA615B997; Wed, 10 Apr 2024 13:06:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712754365; cv=none; b=rvYZxgtFbU1S/SuNyF90jUYXOHqIhaX8R1hy5tEbHAOT8kZECJWU3vNYf0E3ww3uns3keg5T+WoWwTcSKl/WOkZyMvzF41418LZc4IlZobptuXM0MCzSd0dopw9J4dSKvFUm2HeHQ1iUMGDywwGurAjZMspDzPMpjwo9UvhSok8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712754365; c=relaxed/simple; bh=8XeOS+2rdmMOqVaFgMq5BTGGlmPf3KpMj4J2k0f6wnw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OdWoAj2Mej5Ip0gpsGYr8KqRzvTgvrk/TGmGifFQxmlDVwquVKJ/JlR2i5DPJ6XTzMXh0pbZqaQBlQfNe4iumy/nvItW4+EHRmPQyDHKLKYPG2c1wloi4YZ2kWXS6+n6LGERWgb5Lx8xpmWiIzCWi/f/yWtN3wqxg+ZspsHNjOc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=KqVB5Vh3; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=hwW4GVA7; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="KqVB5Vh3"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="hwW4GVA7" Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id AAA555CDA2; Wed, 10 Apr 2024 13:05:59 +0000 (UTC) Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1712754359; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5ThzsoWjmWhZMt413jj7Iww6DAgpDtb/wivYICCyzLo=; b=KqVB5Vh3X93sKuGNey/M4vLf4OqBI2ctp0jTruQG/uiG/bJHLWfvm8VuQTb03eJ1dPgse6 tJqXiieDkl7MTqfqOIp1yquVX4LQ4lOZTxqXSbZ1pxwIVQbyEHEy7uYtH/QZJPjq1VlYw6 bL5chmjGIwEHki6N/PQpccGKIMy+E/k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1712754359; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5ThzsoWjmWhZMt413jj7Iww6DAgpDtb/wivYICCyzLo=; b=hwW4GVA7SlaW5zzk2+vzZFLFfglkWu+L10ai+1pr4UomutOFT54m76RJbHix/sT+5oXbM7 gESE8x/gtDxyumBA== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 5396313A94; Wed, 10 Apr 2024 13:05:59 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id iCMyE7eOFmYdEgAAn2gu4w (envelope-from <tzimmermann@suse.de>); Wed, 10 Apr 2024 13:05:59 +0000 From: Thomas Zimmermann <tzimmermann@suse.de> To: javierm@redhat.com, deller@gmx.de, airlied@gmail.com, daniel@ffwll.ch Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, Thomas Zimmermann <tzimmermann@suse.de>, Zack Rusin <zackr@vmware.com>, Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>, stable@vger.kernel.org, Zack Rusin <zack.rusin@broadcom.com>, Sui Jingfeng <sui.jingfeng@linux.dev> Subject: [PATCH v2 01/43] drm/fbdev-generic: Do not set physical framebuffer address Date: Wed, 10 Apr 2024 15:01:57 +0200 Message-ID: <20240410130557.31572-2-tzimmermann@suse.de> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240410130557.31572-1-tzimmermann@suse.de> References: <20240410130557.31572-1-tzimmermann@suse.de> Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: <linux-fbdev.vger.kernel.org> List-Subscribe: <mailto:linux-fbdev+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-fbdev+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Level: X-Spamd-Result: default: False [-4.00 / 50.00]; REPLY(-4.00)[] X-Spam-Flag: NO X-Spam-Score: -4.00 X-Rspamd-Queue-Id: AAA555CDA2 X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Action: no action |
Series |
drm: Provide fbdev emulation per memory manager
|
expand
|
On Wed, 10 Apr 2024 15:01:57 +0200, Thomas Zimmermann wrote: > Framebuffer memory is allocated via vzalloc() from non-contiguous > physical pages. The physical framebuffer start address is therefore > meaningless. Do not set it. > > The value is not used within the kernel and only exported to userspace > > [ ... ] Acked-by: Maxime Ripard <mripard@kernel.org> Thanks! Maxime
diff --git a/drivers/gpu/drm/drm_fbdev_generic.c b/drivers/gpu/drm/drm_fbdev_generic.c index be357f926faec..97e579c33d84a 100644 --- a/drivers/gpu/drm/drm_fbdev_generic.c +++ b/drivers/gpu/drm/drm_fbdev_generic.c @@ -113,7 +113,6 @@ static int drm_fbdev_generic_helper_fb_probe(struct drm_fb_helper *fb_helper, /* screen */ info->flags |= FBINFO_VIRTFB | FBINFO_READS_FAST; info->screen_buffer = screen_buffer; - info->fix.smem_start = page_to_phys(vmalloc_to_page(info->screen_buffer)); info->fix.smem_len = screen_size; /* deferred I/O */