| Message ID | 1477127682-3615-1-git-send-email-baoyou.xie@linaro.org |
|---|---|
| State | Accepted |
| Commit | c20ea8fd498636b8f7408bf10a305d58a4a05927 |
| Headers | show |
On Saturday, October 22, 2016 5:14:42 PM CEST Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/gpu/drm/i2c/tda998x_drv.c:1292:5: warning: no previous prototype for 'tda998x_audio_digital_mute' [-Wmissing-prototypes] > > In fact, this function is only used in the file in which it is > declared and don't need a declaration, but can be made static. > So this patch marks this function with 'static'. > > Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org> > Reviewed-by: Arnd Bergmann <arnd@arndb.de>
On Mon, Oct 24, 2016 at 12:14:14PM +0200, Arnd Bergmann wrote: > On Saturday, October 22, 2016 5:14:42 PM CEST Baoyou Xie wrote: > > We get 1 warning when building kernel with W=1: > > drivers/gpu/drm/i2c/tda998x_drv.c:1292:5: warning: no previous prototype for 'tda998x_audio_digital_mute' [-Wmissing-prototypes] > > > > In fact, this function is only used in the file in which it is > > declared and don't need a declaration, but can be made static. > > So this patch marks this function with 'static'. > > > > Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org> > > > > Reviewed-by: Arnd Bergmann <arnd@arndb.de> Applied to drm-misc, thanks. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
On Mon, Oct 24, 2016 at 04:27:45PM +0200, Daniel Vetter wrote: > On Mon, Oct 24, 2016 at 12:14:14PM +0200, Arnd Bergmann wrote: > > On Saturday, October 22, 2016 5:14:42 PM CEST Baoyou Xie wrote: > > > We get 1 warning when building kernel with W=1: > > > drivers/gpu/drm/i2c/tda998x_drv.c:1292:5: warning: no previous prototype for 'tda998x_audio_digital_mute' [-Wmissing-prototypes] > > > > > > In fact, this function is only used in the file in which it is > > > declared and don't need a declaration, but can be made static. > > > So this patch marks this function with 'static'. > > > > > > Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org> > > > > > > > Reviewed-by: Arnd Bergmann <arnd@arndb.de> > > Applied to drm-misc, thanks. Argh. This conflicts with my patch series posted before I went away, so now we're going to end up with merge conflicts... I suppose you're happy to handle the conflict as you've bypassed waiting for an ack from the driver maintainer... -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.
diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c index 9798d40..af8683e 100644 --- a/drivers/gpu/drm/i2c/tda998x_drv.c +++ b/drivers/gpu/drm/i2c/tda998x_drv.c @@ -1289,7 +1289,8 @@ static void tda998x_audio_shutdown(struct device *dev, void *data) mutex_unlock(&priv->audio_mutex); } -int tda998x_audio_digital_mute(struct device *dev, void *data, bool enable) +static int +tda998x_audio_digital_mute(struct device *dev, void *data, bool enable) { struct tda998x_priv *priv = dev_get_drvdata(dev);
We get 1 warning when building kernel with W=1: drivers/gpu/drm/i2c/tda998x_drv.c:1292:5: warning: no previous prototype for 'tda998x_audio_digital_mute' [-Wmissing-prototypes] In fact, this function is only used in the file in which it is declared and don't need a declaration, but can be made static. So this patch marks this function with 'static'. Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org> --- drivers/gpu/drm/i2c/tda998x_drv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.7.4