| Message ID | 20240411064614.7409-1-krzk@kernel.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2,1/5] pinctrl: freescale: imx8ulp: fix module autoloading | expand |
Il 11/04/24 08:46, Krzysztof Kozlowski ha scritto: > Add MODULE_DEVICE_TABLE(), so the module could be properly autoloaded > based on the alias from of_device_id table. Pin controllers are > considered core components, so usually they are built-in, however these > can be built and used as modules on some generic kernel. > > Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
On Thu, Apr 11, 2024 at 08:46:13AM +0200, Krzysztof Kozlowski wrote: > Add MODULE_DEVICE_TABLE(), so the module could be properly autoloaded > based on the alias from of_device_id table. Pin controllers are > considered core components, so usually they are built-in, however these > can be built and used as modules on some generic kernel. > > Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > Reviewed-by: Bjorn Andersson <quic_bjorande@quicinc.com> Regards, Bjorn > --- > > Changes in v2: > 1. Add ack > --- > drivers/pinctrl/qcom/pinctrl-sm7150.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pinctrl/qcom/pinctrl-sm7150.c b/drivers/pinctrl/qcom/pinctrl-sm7150.c > index c25357ca1963..c542f9bc6bcd 100644 > --- a/drivers/pinctrl/qcom/pinctrl-sm7150.c > +++ b/drivers/pinctrl/qcom/pinctrl-sm7150.c > @@ -1246,6 +1246,7 @@ static const struct of_device_id sm7150_tlmm_of_match[] = { > { .compatible = "qcom,sm7150-tlmm", }, > { }, > }; > +MODULE_DEVICE_TABLE(of, sm7150_tlmm_of_match); > > static struct platform_driver sm7150_tlmm_driver = { > .driver = { > -- > 2.34.1 >
On Thu, Apr 11, 2024 at 8:46 AM Krzysztof Kozlowski <krzk@kernel.org> wrote: > Add MODULE_DEVICE_TABLE(), so the module could be properly autoloaded > based on the alias from of_device_id table. Pin controllers are > considered core components, so usually they are built-in, however these > can be built and used as modules on some generic kernel. > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> All five patches applied, thanks for fixing this Krzysztof! Yours, Linus Walleij
diff --git a/drivers/pinctrl/freescale/pinctrl-imx8ulp.c b/drivers/pinctrl/freescale/pinctrl-imx8ulp.c index 2e86ca9fc7ac..5632c7285147 100644 --- a/drivers/pinctrl/freescale/pinctrl-imx8ulp.c +++ b/drivers/pinctrl/freescale/pinctrl-imx8ulp.c @@ -252,6 +252,7 @@ static const struct of_device_id imx8ulp_pinctrl_of_match[] = { { .compatible = "fsl,imx8ulp-iomuxc1", }, { /* sentinel */ } }; +MODULE_DEVICE_TABLE(of, imx8ulp_pinctrl_of_match); static int imx8ulp_pinctrl_probe(struct platform_device *pdev) {
Add MODULE_DEVICE_TABLE(), so the module could be properly autoloaded based on the alias from of_device_id table. Pin controllers are considered core components, so usually they are built-in, however these can be built and used as modules on some generic kernel. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- Changes in v2: 1. None --- drivers/pinctrl/freescale/pinctrl-imx8ulp.c | 1 + 1 file changed, 1 insertion(+)