diff mbox series

[next] scsi: bnx2fc: remove redundant assignment to variable i

Message ID 20240415104311.484890-1-colin.i.king@gmail.com
State New
Headers show
Series [next] scsi: bnx2fc: remove redundant assignment to variable i | expand

Commit Message

Colin Ian King April 15, 2024, 10:43 a.m. UTC
The variable i is being assigned a value that is never read, the
following code path via the label ofld_err never refers to the
variable. The assignment is redundant and can be removed.

Cleans up clang scan warning:
drivers/scsi/bnx2fc/bnx2fc_tgt.c:132:5: warning: Value stored to 'i'
is never read [deadcode.DeadStores]

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 drivers/scsi/bnx2fc/bnx2fc_tgt.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Martin K. Petersen April 25, 2024, 1:13 a.m. UTC | #1
Colin,

> The variable i is being assigned a value that is never read, the
> following code path via the label ofld_err never refers to the
> variable. The assignment is redundant and can be removed.

Applied to 6.10/scsi-staging, thanks!
diff mbox series

Patch

diff --git a/drivers/scsi/bnx2fc/bnx2fc_tgt.c b/drivers/scsi/bnx2fc/bnx2fc_tgt.c
index d91659811eb3..eb3209103312 100644
--- a/drivers/scsi/bnx2fc/bnx2fc_tgt.c
+++ b/drivers/scsi/bnx2fc/bnx2fc_tgt.c
@@ -128,10 +128,8 @@  static void bnx2fc_offload_session(struct fcoe_port *port,
 			BNX2FC_TGT_DBG(tgt, "ctx_alloc_failure, "
 				"retry ofld..%d\n", i++);
 			msleep_interruptible(1000);
-			if (i > 3) {
-				i = 0;
+			if (i > 3)
 				goto ofld_err;
-			}
 			goto retry_ofld;
 		}
 		goto ofld_err;