| Message ID | 20240502052356.2630798-1-kiran.k@intel.com |
|---|---|
| State | Accepted |
| Commit | c0fa7f2e6a561942dd1dce7ab4ec5e0163f23f48 |
| Headers | show |
| Series | [v1,1/2] Bluetooth: btintel: Add support for BlazarI | expand |
Dear Kiran, Thank you for your patch. Am 02.05.24 um 07:23 schrieb Kiran K: > Add support for BlazarI (cnvi) bluetooth core. It’d be great if you documented the datasheet name and revision. Also, it’d help people reading the diff, if you added what the support entails. In this case a note, that it’s a “standard device” and only the new id needs to be added, would be nice. > Signed-off-by: Kiran K <kiran.k@intel.com> > --- > drivers/bluetooth/btintel.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c > index dc48352166a5..4f4bd5538b6e 100644 > --- a/drivers/bluetooth/btintel.c > +++ b/drivers/bluetooth/btintel.c > @@ -481,6 +481,7 @@ static int btintel_version_info_tlv(struct hci_dev *hdev, > case 0x19: /* Slr-F */ > case 0x1b: /* Mgr */ > case 0x1c: /* Gale Peak (GaP) */ > + case 0x1e: /* BlazarI (Bzr) */ > break; > default: > bt_dev_err(hdev, "Unsupported Intel hardware variant (0x%x)", > @@ -2698,6 +2699,7 @@ static void btintel_set_msft_opcode(struct hci_dev *hdev, u8 hw_variant) > case 0x19: > case 0x1b: > case 0x1c: > + case 0x1e: > hci_set_msft_opcode(hdev, 0xFC1E); > break; > default: > @@ -3037,6 +3039,7 @@ static int btintel_setup_combined(struct hci_dev *hdev) > case 0x19: > case 0x1b: > case 0x1c: > + case 0x1e: > /* Display version information of TLV type */ > btintel_version_info_tlv(hdev, &ver_tlv); Kind regards, Paul
Hello: This series was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Thu, 2 May 2024 10:53:55 +0530 you wrote: > Add support for BlazarI (cnvi) bluetooth core. > > Signed-off-by: Kiran K <kiran.k@intel.com> > --- > drivers/bluetooth/btintel.c | 3 +++ > 1 file changed, 3 insertions(+) Here is the summary with links: - [v1,1/2] Bluetooth: btintel: Add support for BlazarI https://git.kernel.org/bluetooth/bluetooth-next/c/d250f0cced62 - [v1,2/2] Bluetooth: btintel: Add support for Filmore Peak2 (BE201) https://git.kernel.org/bluetooth/bluetooth-next/c/93ff8ae40fcc You are awesome, thank you!
Hi Paul, Appreciate your comments. > -----Original Message----- > From: Paul Menzel <pmenzel@molgen.mpg.de> > Sent: Thursday, May 2, 2024 11:24 AM > To: K, Kiran <kiran.k@intel.com> > Cc: linux-bluetooth@vger.kernel.org; Srivatsa, Ravishankar > <ravishankar.srivatsa@intel.com>; Tumkur Narayan, Chethan > <chethan.tumkur.narayan@intel.com>; Devegowda, Chandrashekar > <chandrashekar.devegowda@intel.com> > Subject: Re: [PATCH v1 1/2] Bluetooth: btintel: Add support for BlazarI > > Dear Kiran, > > > Thank you for your patch. > > Am 02.05.24 um 07:23 schrieb Kiran K: > > Add support for BlazarI (cnvi) bluetooth core. > > It’d be great if you documented the datasheet name and revision. I am afraid to provide these details as these data is internal. > > Also, it’d help people reading the diff, if you added what the support entails. > In this case a note, that it’s a “standard device” and only the new id needs to > be added, would be nice. Ack. > > > Signed-off-by: Kiran K <kiran.k@intel.com> > > --- > > drivers/bluetooth/btintel.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c > > index dc48352166a5..4f4bd5538b6e 100644 > > --- a/drivers/bluetooth/btintel.c > > +++ b/drivers/bluetooth/btintel.c > > @@ -481,6 +481,7 @@ static int btintel_version_info_tlv(struct hci_dev > *hdev, > > case 0x19: /* Slr-F */ > > case 0x1b: /* Mgr */ > > case 0x1c: /* Gale Peak (GaP) */ > > + case 0x1e: /* BlazarI (Bzr) */ > > break; > > default: > > bt_dev_err(hdev, "Unsupported Intel hardware variant > (0x%x)", @@ > > -2698,6 +2699,7 @@ static void btintel_set_msft_opcode(struct hci_dev > *hdev, u8 hw_variant) > > case 0x19: > > case 0x1b: > > case 0x1c: > > + case 0x1e: > > hci_set_msft_opcode(hdev, 0xFC1E); > > break; > > default: > > @@ -3037,6 +3039,7 @@ static int btintel_setup_combined(struct hci_dev > *hdev) > > case 0x19: > > case 0x1b: > > case 0x1c: > > + case 0x1e: > > /* Display version information of TLV type */ > > btintel_version_info_tlv(hdev, &ver_tlv); > > > Kind regards, > > Paul Thanks, Kiran
diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c index dc48352166a5..4f4bd5538b6e 100644 --- a/drivers/bluetooth/btintel.c +++ b/drivers/bluetooth/btintel.c @@ -481,6 +481,7 @@ static int btintel_version_info_tlv(struct hci_dev *hdev, case 0x19: /* Slr-F */ case 0x1b: /* Mgr */ case 0x1c: /* Gale Peak (GaP) */ + case 0x1e: /* BlazarI (Bzr) */ break; default: bt_dev_err(hdev, "Unsupported Intel hardware variant (0x%x)", @@ -2698,6 +2699,7 @@ static void btintel_set_msft_opcode(struct hci_dev *hdev, u8 hw_variant) case 0x19: case 0x1b: case 0x1c: + case 0x1e: hci_set_msft_opcode(hdev, 0xFC1E); break; default: @@ -3037,6 +3039,7 @@ static int btintel_setup_combined(struct hci_dev *hdev) case 0x19: case 0x1b: case 0x1c: + case 0x1e: /* Display version information of TLV type */ btintel_version_info_tlv(hdev, &ver_tlv);
Add support for BlazarI (cnvi) bluetooth core. Signed-off-by: Kiran K <kiran.k@intel.com> --- drivers/bluetooth/btintel.c | 3 +++ 1 file changed, 3 insertions(+)