diff mbox

[edk2,07/47] NetworkPkg/IpsecConfig: remove module-local ARRAY_SIZE macro

Message ID 20161026190504.9888-8-lersek@redhat.com
State Accepted
Commit de69024c83558412ad6159488d40a36005f1dc14
Headers show

Commit Message

Laszlo Ersek Oct. 26, 2016, 7:04 p.m. UTC
Rely on the central macro definition from "MdePkg/Include/Base.h" instead.

Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>

---
 NetworkPkg/Application/IpsecConfig/IpSecConfig.h | 4 ----
 1 file changed, 4 deletions(-)

-- 
2.9.2


_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Fu, Siyuan Oct. 27, 2016, 1:59 a.m. UTC | #1
Reviewed-by: Fu Siyuan siyuan.fu@intel.com





> -----Original Message-----

> From: Laszlo Ersek [mailto:lersek@redhat.com]

> Sent: Thursday, October 27, 2016 3:04 AM

> To: edk2-devel-01 <edk2-devel@ml01.01.org>

> Cc: Wu, Jiaxin <jiaxin.wu@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>

> Subject: [PATCH 07/47] NetworkPkg/IpsecConfig: remove module-local

> ARRAY_SIZE macro

> 

> Rely on the central macro definition from "MdePkg/Include/Base.h" instead.

> 

> Cc: Jiaxin Wu <jiaxin.wu@intel.com>

> Cc: Siyuan Fu <siyuan.fu@intel.com>

> Contributed-under: TianoCore Contribution Agreement 1.0

> Signed-off-by: Laszlo Ersek <lersek@redhat.com>

> ---

>  NetworkPkg/Application/IpsecConfig/IpSecConfig.h | 4 ----

>  1 file changed, 4 deletions(-)

> 

> diff --git a/NetworkPkg/Application/IpsecConfig/IpSecConfig.h

> b/NetworkPkg/Application/IpsecConfig/IpSecConfig.h

> index 79a436a7b3b2..95bb6961136d 100644

> --- a/NetworkPkg/Application/IpsecConfig/IpSecConfig.h

> +++ b/NetworkPkg/Application/IpsecConfig/IpSecConfig.h

> @@ -27,10 +27,6 @@

> 

>  #include <Protocol/IpSecConfig.h>

> 

> -#ifndef ARRAY_SIZE

> -#define ARRAY_SIZE(x) (sizeof(x) / sizeof(x[0]))

> -#endif

> -

>  #define IPSECCONFIG_STATUS_NAME    L"IpSecStatus"

> 

>  #define BIT(x)   (UINT32) (1 << (x))

> --

> 2.9.2

> 


_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Wu, Jiaxin Oct. 27, 2016, 2:31 a.m. UTC | #2
Reviewed-By: Wu Jiaxin <jiaxin.wu@intel.com>


Best Regards!
Jiaxin

> -----Original Message-----

> From: Laszlo Ersek [mailto:lersek@redhat.com]

> Sent: Thursday, October 27, 2016 3:04 AM

> To: edk2-devel-01 <edk2-devel@ml01.01.org>

> Cc: Wu, Jiaxin <jiaxin.wu@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>

> Subject: [PATCH 07/47] NetworkPkg/IpsecConfig: remove module-local

> ARRAY_SIZE macro

> 

> Rely on the central macro definition from "MdePkg/Include/Base.h" instead.

> 

> Cc: Jiaxin Wu <jiaxin.wu@intel.com>

> Cc: Siyuan Fu <siyuan.fu@intel.com>

> Contributed-under: TianoCore Contribution Agreement 1.0

> Signed-off-by: Laszlo Ersek <lersek@redhat.com>

> ---

>  NetworkPkg/Application/IpsecConfig/IpSecConfig.h | 4 ----

>  1 file changed, 4 deletions(-)

> 

> diff --git a/NetworkPkg/Application/IpsecConfig/IpSecConfig.h

> b/NetworkPkg/Application/IpsecConfig/IpSecConfig.h

> index 79a436a7b3b2..95bb6961136d 100644

> --- a/NetworkPkg/Application/IpsecConfig/IpSecConfig.h

> +++ b/NetworkPkg/Application/IpsecConfig/IpSecConfig.h

> @@ -27,10 +27,6 @@

> 

>  #include <Protocol/IpSecConfig.h>

> 

> -#ifndef ARRAY_SIZE

> -#define ARRAY_SIZE(x) (sizeof(x) / sizeof(x[0])) -#endif

> -

>  #define IPSECCONFIG_STATUS_NAME    L"IpSecStatus"

> 

>  #define BIT(x)   (UINT32) (1 << (x))

> --

> 2.9.2

> 


_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
diff mbox

Patch

diff --git a/NetworkPkg/Application/IpsecConfig/IpSecConfig.h b/NetworkPkg/Application/IpsecConfig/IpSecConfig.h
index 79a436a7b3b2..95bb6961136d 100644
--- a/NetworkPkg/Application/IpsecConfig/IpSecConfig.h
+++ b/NetworkPkg/Application/IpsecConfig/IpSecConfig.h
@@ -27,10 +27,6 @@ 
 
 #include <Protocol/IpSecConfig.h>
 
-#ifndef ARRAY_SIZE
-#define ARRAY_SIZE(x) (sizeof(x) / sizeof(x[0]))
-#endif
-
 #define IPSECCONFIG_STATUS_NAME    L"IpSecStatus"
 
 #define BIT(x)   (UINT32) (1 << (x))