[Linaro-uefi,04/26] D02/D03/Dsdt: add media-type property for hns

Message ID 1477538129-118465-3-git-send-email-heyi.guo@linaro.org
State Superseded
Headers show

Commit Message

gary guo Oct. 27, 2016, 3:15 a.m.
It is PORT_TP type if the service port is GE mode. It is wrong to
judge the port type by using if it is service port. Adding the media
type to know port type.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Kejian Yan <yankejian@huawei.com>
---
 Chips/Hisilicon/Pv660/Pv660AcpiTables/Dsdt/D03Hns.asl | 4 ++++
 Chips/Hisilicon/Pv660/Pv660AcpiTables/Dsdt/Hns.asl    | 4 ++++
 2 files changed, 8 insertions(+)

Comments

Leif Lindholm Nov. 5, 2016, 4:40 p.m. | #1
Finally getting back to this, apologies for the delay.

Looks fine to me, but a nod from Graeme would be preferable.

Regards,

Leif

On Thu, Oct 27, 2016 at 11:15:07AM +0800, Heyi Guo wrote:
> It is PORT_TP type if the service port is GE mode. It is wrong to
> judge the port type by using if it is service port. Adding the media
> type to know port type.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Kejian Yan <yankejian@huawei.com>
> ---
>  Chips/Hisilicon/Pv660/Pv660AcpiTables/Dsdt/D03Hns.asl | 4 ++++
>  Chips/Hisilicon/Pv660/Pv660AcpiTables/Dsdt/Hns.asl    | 4 ++++
>  2 files changed, 8 insertions(+)
> 
> diff --git a/Chips/Hisilicon/Pv660/Pv660AcpiTables/Dsdt/D03Hns.asl b/Chips/Hisilicon/Pv660/Pv660AcpiTables/Dsdt/D03Hns.asl
> index aa83489..b62ee45 100644
> --- a/Chips/Hisilicon/Pv660/Pv660AcpiTables/Dsdt/D03Hns.asl
> +++ b/Chips/Hisilicon/Pv660/Pv660AcpiTables/Dsdt/D03Hns.asl
> @@ -466,6 +466,7 @@ Scope(_SB)
>                          ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
>              Package () {
>                  Package () {"reg", 0},
> +                Package () {"media-type", "fiber"},
>                          }
>                  })
>      }
> @@ -476,6 +477,7 @@ Scope(_SB)
>                          ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
>              Package () {
>                  Package () {"reg", 1},
> +                Package () {"media-type", "fiber"},
>                          }
>                  })
>      }
> @@ -489,6 +491,7 @@ Scope(_SB)
>                                  Package () {"phy-mode", "sgmii"},
>                  Package () {"phy-addr", 0},
>                  Package () {"mdio-node", Package (){\_SB.MDIO}},
> +                Package () {"media-type", "copper"},
>                          }
>                  })
>      }
> @@ -502,6 +505,7 @@ Scope(_SB)
>                                  Package () {"phy-mode", "sgmii"},
>                  Package () {"phy-addr", 1},
>                  Package () {"mdio-node", Package (){\_SB.MDIO}},
> +                Package () {"media-type", "copper"},
>                          }
>                  })
>      }
> diff --git a/Chips/Hisilicon/Pv660/Pv660AcpiTables/Dsdt/Hns.asl b/Chips/Hisilicon/Pv660/Pv660AcpiTables/Dsdt/Hns.asl
> index 5945fc3..2b08a1f 100644
> --- a/Chips/Hisilicon/Pv660/Pv660AcpiTables/Dsdt/Hns.asl
> +++ b/Chips/Hisilicon/Pv660/Pv660AcpiTables/Dsdt/Hns.asl
> @@ -439,6 +439,7 @@ Scope(_SB)
>                          ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
>          Package () {
>            Package () {"reg", 0},
> +          Package () {"media-type", "fiber"},
>                          }
>                  })
>      }
> @@ -449,6 +450,7 @@ Scope(_SB)
>                          ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
>          Package () {
>            Package () {"reg", 1},
> +          Package () {"media-type", "fiber"},
>                          }
>                  })
>      }
> @@ -462,6 +464,7 @@ Scope(_SB)
>            Package () {"phy-mode", "sgmii"},
>            Package () {"phy-addr", 0},
>            Package () {"mdio-node", Package (){\_SB.MDIO}},
> +          Package () {"media-type", "copper"},
>                          }
>                  })
>      }
> @@ -475,6 +478,7 @@ Scope(_SB)
>            Package () {"phy-mode", "sgmii"},
>            Package () {"phy-addr", 1},
>            Package () {"mdio-node", Package (){\_SB.MDIO}},
> +          Package () {"media-type", "copper"},
>                          }
>                  })
>      }
> -- 
> 1.9.1
>
gary guo Nov. 11, 2016, 3:12 a.m. | #2
Hi Graeme,

Could you help to review the D02/D03 ACPI related patches?

Thanks and Regards.



在 11/6/2016 12:40 AM, Leif Lindholm 写道:
> Finally getting back to this, apologies for the delay.
>
> Looks fine to me, but a nod from Graeme would be preferable.
>
> Regards,
>
> Leif
>
> On Thu, Oct 27, 2016 at 11:15:07AM +0800, Heyi Guo wrote:
>> It is PORT_TP type if the service port is GE mode. It is wrong to
>> judge the port type by using if it is service port. Adding the media
>> type to know port type.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Signed-off-by: Kejian Yan <yankejian@huawei.com>
>> ---
>>   Chips/Hisilicon/Pv660/Pv660AcpiTables/Dsdt/D03Hns.asl | 4 ++++
>>   Chips/Hisilicon/Pv660/Pv660AcpiTables/Dsdt/Hns.asl    | 4 ++++
>>   2 files changed, 8 insertions(+)
>>
>> diff --git a/Chips/Hisilicon/Pv660/Pv660AcpiTables/Dsdt/D03Hns.asl b/Chips/Hisilicon/Pv660/Pv660AcpiTables/Dsdt/D03Hns.asl
>> index aa83489..b62ee45 100644
>> --- a/Chips/Hisilicon/Pv660/Pv660AcpiTables/Dsdt/D03Hns.asl
>> +++ b/Chips/Hisilicon/Pv660/Pv660AcpiTables/Dsdt/D03Hns.asl
>> @@ -466,6 +466,7 @@ Scope(_SB)
>>                           ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
>>               Package () {
>>                   Package () {"reg", 0},
>> +                Package () {"media-type", "fiber"},
>>                           }
>>                   })
>>       }
>> @@ -476,6 +477,7 @@ Scope(_SB)
>>                           ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
>>               Package () {
>>                   Package () {"reg", 1},
>> +                Package () {"media-type", "fiber"},
>>                           }
>>                   })
>>       }
>> @@ -489,6 +491,7 @@ Scope(_SB)
>>                                   Package () {"phy-mode", "sgmii"},
>>                   Package () {"phy-addr", 0},
>>                   Package () {"mdio-node", Package (){\_SB.MDIO}},
>> +                Package () {"media-type", "copper"},
>>                           }
>>                   })
>>       }
>> @@ -502,6 +505,7 @@ Scope(_SB)
>>                                   Package () {"phy-mode", "sgmii"},
>>                   Package () {"phy-addr", 1},
>>                   Package () {"mdio-node", Package (){\_SB.MDIO}},
>> +                Package () {"media-type", "copper"},
>>                           }
>>                   })
>>       }
>> diff --git a/Chips/Hisilicon/Pv660/Pv660AcpiTables/Dsdt/Hns.asl b/Chips/Hisilicon/Pv660/Pv660AcpiTables/Dsdt/Hns.asl
>> index 5945fc3..2b08a1f 100644
>> --- a/Chips/Hisilicon/Pv660/Pv660AcpiTables/Dsdt/Hns.asl
>> +++ b/Chips/Hisilicon/Pv660/Pv660AcpiTables/Dsdt/Hns.asl
>> @@ -439,6 +439,7 @@ Scope(_SB)
>>                           ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
>>           Package () {
>>             Package () {"reg", 0},
>> +          Package () {"media-type", "fiber"},
>>                           }
>>                   })
>>       }
>> @@ -449,6 +450,7 @@ Scope(_SB)
>>                           ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
>>           Package () {
>>             Package () {"reg", 1},
>> +          Package () {"media-type", "fiber"},
>>                           }
>>                   })
>>       }
>> @@ -462,6 +464,7 @@ Scope(_SB)
>>             Package () {"phy-mode", "sgmii"},
>>             Package () {"phy-addr", 0},
>>             Package () {"mdio-node", Package (){\_SB.MDIO}},
>> +          Package () {"media-type", "copper"},
>>                           }
>>                   })
>>       }
>> @@ -475,6 +478,7 @@ Scope(_SB)
>>             Package () {"phy-mode", "sgmii"},
>>             Package () {"phy-addr", 1},
>>             Package () {"mdio-node", Package (){\_SB.MDIO}},
>> +          Package () {"media-type", "copper"},
>>                           }
>>                   })
>>       }
>> -- 
>> 1.9.1
>>

Patch

diff --git a/Chips/Hisilicon/Pv660/Pv660AcpiTables/Dsdt/D03Hns.asl b/Chips/Hisilicon/Pv660/Pv660AcpiTables/Dsdt/D03Hns.asl
index aa83489..b62ee45 100644
--- a/Chips/Hisilicon/Pv660/Pv660AcpiTables/Dsdt/D03Hns.asl
+++ b/Chips/Hisilicon/Pv660/Pv660AcpiTables/Dsdt/D03Hns.asl
@@ -466,6 +466,7 @@  Scope(_SB)
                         ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
             Package () {
                 Package () {"reg", 0},
+                Package () {"media-type", "fiber"},
                         }
                 })
     }
@@ -476,6 +477,7 @@  Scope(_SB)
                         ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
             Package () {
                 Package () {"reg", 1},
+                Package () {"media-type", "fiber"},
                         }
                 })
     }
@@ -489,6 +491,7 @@  Scope(_SB)
                                 Package () {"phy-mode", "sgmii"},
                 Package () {"phy-addr", 0},
                 Package () {"mdio-node", Package (){\_SB.MDIO}},
+                Package () {"media-type", "copper"},
                         }
                 })
     }
@@ -502,6 +505,7 @@  Scope(_SB)
                                 Package () {"phy-mode", "sgmii"},
                 Package () {"phy-addr", 1},
                 Package () {"mdio-node", Package (){\_SB.MDIO}},
+                Package () {"media-type", "copper"},
                         }
                 })
     }
diff --git a/Chips/Hisilicon/Pv660/Pv660AcpiTables/Dsdt/Hns.asl b/Chips/Hisilicon/Pv660/Pv660AcpiTables/Dsdt/Hns.asl
index 5945fc3..2b08a1f 100644
--- a/Chips/Hisilicon/Pv660/Pv660AcpiTables/Dsdt/Hns.asl
+++ b/Chips/Hisilicon/Pv660/Pv660AcpiTables/Dsdt/Hns.asl
@@ -439,6 +439,7 @@  Scope(_SB)
                         ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
         Package () {
           Package () {"reg", 0},
+          Package () {"media-type", "fiber"},
                         }
                 })
     }
@@ -449,6 +450,7 @@  Scope(_SB)
                         ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
         Package () {
           Package () {"reg", 1},
+          Package () {"media-type", "fiber"},
                         }
                 })
     }
@@ -462,6 +464,7 @@  Scope(_SB)
           Package () {"phy-mode", "sgmii"},
           Package () {"phy-addr", 0},
           Package () {"mdio-node", Package (){\_SB.MDIO}},
+          Package () {"media-type", "copper"},
                         }
                 })
     }
@@ -475,6 +478,7 @@  Scope(_SB)
           Package () {"phy-mode", "sgmii"},
           Package () {"phy-addr", 1},
           Package () {"mdio-node", Package (){\_SB.MDIO}},
+          Package () {"media-type", "copper"},
                         }
                 })
     }