diff mbox series

ACPI: PCI: Remove unused struct 'acpi_handle_node'

Message ID 20240509000858.204114-1-linux@treblig.org
State New
Headers show
Series ACPI: PCI: Remove unused struct 'acpi_handle_node' | expand

Commit Message

Dr. David Alan Gilbert May 9, 2024, 12:08 a.m. UTC
From: "Dr. David Alan Gilbert" <linux@treblig.org>

'acpi_handle_node' is unused since
Commit 63f534b8bad9 ("ACPI: PCI: Rework acpi_get_pci_dev()")
Remove it.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
 drivers/acpi/pci_root.c | 5 -----
 1 file changed, 5 deletions(-)

Comments

Dr. David Alan Gilbert May 23, 2024, 3:10 p.m. UTC | #1
* Jonathan Cameron (Jonathan.Cameron@Huawei.com) wrote:
> On Thu,  9 May 2024 01:08:58 +0100
> linux@treblig.org wrote:
> 
> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > 
> > 'acpi_handle_node' is unused since
> > Commit 63f534b8bad9 ("ACPI: PCI: Rework acpi_get_pci_dev()")
> > Remove it.
> > 
> > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> 
> FWIW, indeed unused.
> 
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Thanks; any idea who would pick this up?

Dave

> > ---
> >  drivers/acpi/pci_root.c | 5 -----
> >  1 file changed, 5 deletions(-)
> > 
> > diff --git a/drivers/acpi/pci_root.c b/drivers/acpi/pci_root.c
> > index 58b89b8d950ed..59e6955e24edb 100644
> > --- a/drivers/acpi/pci_root.c
> > +++ b/drivers/acpi/pci_root.c
> > @@ -293,11 +293,6 @@ struct acpi_pci_root *acpi_pci_find_root(acpi_handle handle)
> >  }
> >  EXPORT_SYMBOL_GPL(acpi_pci_find_root);
> >  
> > -struct acpi_handle_node {
> > -	struct list_head node;
> > -	acpi_handle handle;
> > -};
> > -
> >  /**
> >   * acpi_get_pci_dev - convert ACPI CA handle to struct pci_dev
> >   * @handle: the handle in question
> 
>
Bjorn Helgaas June 6, 2024, 7:55 p.m. UTC | #2
On Thu, May 23, 2024 at 03:10:05PM +0000, Dr. David Alan Gilbert wrote:
> * Jonathan Cameron (Jonathan.Cameron@Huawei.com) wrote:
> > On Thu,  9 May 2024 01:08:58 +0100
> > linux@treblig.org wrote:
> > 
> > > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > > 
> > > 'acpi_handle_node' is unused since
> > > Commit 63f534b8bad9 ("ACPI: PCI: Rework acpi_get_pci_dev()")
> > > Remove it.
> > > 
> > > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> > 
> > FWIW, indeed unused.
> > 
> > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
> Thanks; any idea who would pick this up?

Applied with Jonathan's reviewed-by to pci/misc for v6.11, thanks!

Rafael, let me know if you want this instead.  Easy for me to drop if
you do.

> > > ---
> > >  drivers/acpi/pci_root.c | 5 -----
> > >  1 file changed, 5 deletions(-)
> > > 
> > > diff --git a/drivers/acpi/pci_root.c b/drivers/acpi/pci_root.c
> > > index 58b89b8d950ed..59e6955e24edb 100644
> > > --- a/drivers/acpi/pci_root.c
> > > +++ b/drivers/acpi/pci_root.c
> > > @@ -293,11 +293,6 @@ struct acpi_pci_root *acpi_pci_find_root(acpi_handle handle)
> > >  }
> > >  EXPORT_SYMBOL_GPL(acpi_pci_find_root);
> > >  
> > > -struct acpi_handle_node {
> > > -	struct list_head node;
> > > -	acpi_handle handle;
> > > -};
> > > -
> > >  /**
> > >   * acpi_get_pci_dev - convert ACPI CA handle to struct pci_dev
> > >   * @handle: the handle in question
> > 
> > 
> -- 
>  -----Open up your eyes, open up your mind, open up your code -------   
> / Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
> \        dave @ treblig.org |                               | In Hex /
>  \ _________________________|_____ http://www.treblig.org   |_______/
diff mbox series

Patch

diff --git a/drivers/acpi/pci_root.c b/drivers/acpi/pci_root.c
index 58b89b8d950ed..59e6955e24edb 100644
--- a/drivers/acpi/pci_root.c
+++ b/drivers/acpi/pci_root.c
@@ -293,11 +293,6 @@  struct acpi_pci_root *acpi_pci_find_root(acpi_handle handle)
 }
 EXPORT_SYMBOL_GPL(acpi_pci_find_root);
 
-struct acpi_handle_node {
-	struct list_head node;
-	acpi_handle handle;
-};
-
 /**
  * acpi_get_pci_dev - convert ACPI CA handle to struct pci_dev
  * @handle: the handle in question