| Message ID | 20240520073207.9600-1-sakari.ailus@linux.intel.com |
|---|---|
| State | Accepted |
| Commit | 7d30b8efae814bc73541720ca188dc205cd7d2b8 |
| Headers | show |
| Series | [1/1] media: async: Warn on attept to create an ancillary link to a non-subdev | expand |
diff --git a/drivers/media/v4l2-core/v4l2-async.c b/drivers/media/v4l2-core/v4l2-async.c index c477723c07bf..81a9b5473969 100644 --- a/drivers/media/v4l2-core/v4l2-async.c +++ b/drivers/media/v4l2-core/v4l2-async.c @@ -323,8 +323,12 @@ static int v4l2_async_create_ancillary_links(struct v4l2_async_notifier *n, sd->entity.function != MEDIA_ENT_F_FLASH) return 0; - if (!n->sd) + if (!n->sd) { + dev_warn(notifier_dev(n), + "not a sub-device notifier, not creating an ancillary link for %s!\n", + dev_name(sd->dev)); return 0; + } link = media_create_ancillary_link(&n->sd->entity, &sd->entity);
Warn if a lens or a flash async sub-device is bound to a non-sub-device notifier. This isn't meaningful and unlikely to happen in practice but print a warning as we nevertheless won't consider this an error. Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> --- drivers/media/v4l2-core/v4l2-async.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)