diff mbox series

loongarch: Remove duplicate strnlen in libc.a (BZ 31785)

Message ID 20240522132115.596912-1-adhemerval.zanella@linaro.org
State Accepted
Commit 62eaa4673923bd8b91a5f961828b75bcce10beb7
Headers show
Series loongarch: Remove duplicate strnlen in libc.a (BZ 31785) | expand

Commit Message

Adhemerval Zanella May 22, 2024, 1:21 p.m. UTC 
The generic version provides weak definitions of strnlen,
which are already provided by the ifunc resolver.
---
 sysdeps/loongarch/lp64/multiarch/strnlen-aligned.S | 2 ++
 1 file changed, 2 insertions(+)

Comments

H.J. Lu May 22, 2024, 1:30 p.m. UTC | #1 
On Wed, May 22, 2024 at 6:21 AM Adhemerval Zanella
<adhemerval.zanella@linaro.org> wrote:
>
> The generic version provides weak definitions of strnlen,
> which are already provided by the ifunc resolver.
> ---
>  sysdeps/loongarch/lp64/multiarch/strnlen-aligned.S | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/sysdeps/loongarch/lp64/multiarch/strnlen-aligned.S b/sysdeps/loongarch/lp64/multiarch/strnlen-aligned.S
> index 9826d21c2e..3606225ca2 100644
> --- a/sysdeps/loongarch/lp64/multiarch/strnlen-aligned.S
> +++ b/sysdeps/loongarch/lp64/multiarch/strnlen-aligned.S
> @@ -98,5 +98,7 @@ L(out):
>      jr          ra
>  END(STRNLEN)
>
> +#if !IS_IN (libc)
>  weak_alias (STRNLEN, strnlen)
>  libc_hidden_builtin_def (STRNLEN)
> +#endif
> --
> 2.43.0
>

LGTM.

Reviewed-by: H.J. Lu <hjl.tools@gmail.com>

Thanks.
diff mbox series

Patch

diff --git a/sysdeps/loongarch/lp64/multiarch/strnlen-aligned.S b/sysdeps/loongarch/lp64/multiarch/strnlen-aligned.S
index 9826d21c2e..3606225ca2 100644
--- a/sysdeps/loongarch/lp64/multiarch/strnlen-aligned.S
+++ b/sysdeps/loongarch/lp64/multiarch/strnlen-aligned.S
@@ -98,5 +98,7 @@  L(out):
     jr          ra
 END(STRNLEN)
 
+#if !IS_IN (libc)
 weak_alias (STRNLEN, strnlen)
 libc_hidden_builtin_def (STRNLEN)
+#endif