diff mbox series

powerpc: Remove duplicated llrintf and llrintf32 from libm.a (BZ 31787)

Message ID 20240522144916.1196297-1-adhemerval.zanella@linaro.org
State Accepted
Commit d8ebde14fbf713ef1d91e4250ad8aa97c7df8128
Headers show
Series powerpc: Remove duplicated llrintf and llrintf32 from libm.a (BZ 31787) | expand

Commit Message

Adhemerval Zanella May 22, 2024, 2:49 p.m. UTC
Both the generic and POWER6 versions provide definitions of the
symbol, which are already provided by the ifunc resolver.

Checked on powerpc-linux-gnu-power4.
---
 .../powerpc/powerpc32/power4/fpu/multiarch/s_llrintf-power6.c | 4 ++++
 .../powerpc/powerpc32/power4/fpu/multiarch/s_llrintf-ppc32.c  | 4 ++++
 2 files changed, 8 insertions(+)

Comments

H.J. Lu May 22, 2024, 3:13 p.m. UTC | #1
On Wed, May 22, 2024 at 7:49 AM Adhemerval Zanella
<adhemerval.zanella@linaro.org> wrote:
>
> Both the generic and POWER6 versions provide definitions of the
> symbol, which are already provided by the ifunc resolver.
>
> Checked on powerpc-linux-gnu-power4.
> ---
>  .../powerpc/powerpc32/power4/fpu/multiarch/s_llrintf-power6.c | 4 ++++
>  .../powerpc/powerpc32/power4/fpu/multiarch/s_llrintf-ppc32.c  | 4 ++++
>  2 files changed, 8 insertions(+)
>
> diff --git a/sysdeps/powerpc/powerpc32/power4/fpu/multiarch/s_llrintf-power6.c b/sysdeps/powerpc/powerpc32/power4/fpu/multiarch/s_llrintf-power6.c
> index 5b1a5a8cf0..3c279ddd1a 100644
> --- a/sysdeps/powerpc/powerpc32/power4/fpu/multiarch/s_llrintf-power6.c
> +++ b/sysdeps/powerpc/powerpc32/power4/fpu/multiarch/s_llrintf-power6.c
> @@ -1,2 +1,6 @@
> +#include <libm-alias-float.h>
> +
>  #define __llrintf __llrintf_power6
> +#undef libm_alias_float
> +#define libm_alias_float(a, b)
>  #include <sysdeps/powerpc/powerpc32/fpu/s_llrintf.c>
> diff --git a/sysdeps/powerpc/powerpc32/power4/fpu/multiarch/s_llrintf-ppc32.c b/sysdeps/powerpc/powerpc32/power4/fpu/multiarch/s_llrintf-ppc32.c
> index 061962b84d..bce8f4564f 100644
> --- a/sysdeps/powerpc/powerpc32/power4/fpu/multiarch/s_llrintf-ppc32.c
> +++ b/sysdeps/powerpc/powerpc32/power4/fpu/multiarch/s_llrintf-ppc32.c
> @@ -1,2 +1,6 @@
> +#include <libm-alias-float.h>
> +
>  #define __llrintf __llrintf_ppc32
> +#undef libm_alias_float
> +#define libm_alias_float(a, b)
>  #include <sysdeps/powerpc/powerpc32/fpu/s_llrintf.c>
> --
> 2.43.0
>

LGTM.

Reviewed-by: H.J. Lu <hjl.tools@gmail.com>

Thanks.
diff mbox series

Patch

diff --git a/sysdeps/powerpc/powerpc32/power4/fpu/multiarch/s_llrintf-power6.c b/sysdeps/powerpc/powerpc32/power4/fpu/multiarch/s_llrintf-power6.c
index 5b1a5a8cf0..3c279ddd1a 100644
--- a/sysdeps/powerpc/powerpc32/power4/fpu/multiarch/s_llrintf-power6.c
+++ b/sysdeps/powerpc/powerpc32/power4/fpu/multiarch/s_llrintf-power6.c
@@ -1,2 +1,6 @@ 
+#include <libm-alias-float.h>
+
 #define __llrintf __llrintf_power6
+#undef libm_alias_float
+#define libm_alias_float(a, b)
 #include <sysdeps/powerpc/powerpc32/fpu/s_llrintf.c>
diff --git a/sysdeps/powerpc/powerpc32/power4/fpu/multiarch/s_llrintf-ppc32.c b/sysdeps/powerpc/powerpc32/power4/fpu/multiarch/s_llrintf-ppc32.c
index 061962b84d..bce8f4564f 100644
--- a/sysdeps/powerpc/powerpc32/power4/fpu/multiarch/s_llrintf-ppc32.c
+++ b/sysdeps/powerpc/powerpc32/power4/fpu/multiarch/s_llrintf-ppc32.c
@@ -1,2 +1,6 @@ 
+#include <libm-alias-float.h>
+
 #define __llrintf __llrintf_ppc32
+#undef libm_alias_float
+#define libm_alias_float(a, b)
 #include <sysdeps/powerpc/powerpc32/fpu/s_llrintf.c>