| Message ID | 1477651478-16830-5-git-send-email-ard.biesheuvel@linaro.org |
|---|---|
| State | Accepted |
| Commit | 15d8747a5f0fea5f30d6d4f812f6aa3bbd4c5ba8 |
| Headers | show |
On Fri, Oct 28, 2016 at 11:44:33AM +0100, Ard Biesheuvel wrote: > The result of PcdGet64() can only be cast to VOID* on 64-bit platforms, > so add an intermediate UINTN cast to make this code build again on 32 bit. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > Reviewed-by: Laszlo Ersek <lersek@redhat.com> > --- > EmbeddedPkg/Library/GdbDebugAgent/Arm/Processor.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/EmbeddedPkg/Library/GdbDebugAgent/Arm/Processor.c b/EmbeddedPkg/Library/GdbDebugAgent/Arm/Processor.c > index 8226c80ab466..a43ff95d03a3 100644 > --- a/EmbeddedPkg/Library/GdbDebugAgent/Arm/Processor.c > +++ b/EmbeddedPkg/Library/GdbDebugAgent/Arm/Processor.c > @@ -657,7 +657,7 @@ InitializeDebugAgent ( > *(UINTN *) (((UINT8 *)VectorBase) + Offset) = (UINTN)AsmCommonExceptionEntry; Yes, I know this is just context, but *twitch*. > > // Flush Caches since we updated executable stuff > - InvalidateInstructionCacheRange ((VOID *)PcdGet64(PcdCpuVectorBaseAddress), Length); > + InvalidateInstructionCacheRange ((VOID *)(UINTN)PcdGet64(PcdCpuVectorBaseAddress), Length); > > // setup a timer so gdb can break in via ctrl-c > DebugAgentTimerIntialize (); > -- > 2.7.4 Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org> _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
diff --git a/EmbeddedPkg/Library/GdbDebugAgent/Arm/Processor.c b/EmbeddedPkg/Library/GdbDebugAgent/Arm/Processor.c index 8226c80ab466..a43ff95d03a3 100644 --- a/EmbeddedPkg/Library/GdbDebugAgent/Arm/Processor.c +++ b/EmbeddedPkg/Library/GdbDebugAgent/Arm/Processor.c @@ -657,7 +657,7 @@ InitializeDebugAgent ( *(UINTN *) (((UINT8 *)VectorBase) + Offset) = (UINTN)AsmCommonExceptionEntry; // Flush Caches since we updated executable stuff - InvalidateInstructionCacheRange ((VOID *)PcdGet64(PcdCpuVectorBaseAddress), Length); + InvalidateInstructionCacheRange ((VOID *)(UINTN)PcdGet64(PcdCpuVectorBaseAddress), Length); // setup a timer so gdb can break in via ctrl-c DebugAgentTimerIntialize ();