diff mbox

[edk2,2/3] ArmPlatformPkg/PrePi RVCT: use relative reference to mSystemMemoryEnd

Message ID 1477654974-5598-3-git-send-email-ard.biesheuvel@linaro.org
State Accepted
Commit b0609e4f02fc1af93b849e48b225ca5e2c315fc0
Headers show

Commit Message

Ard Biesheuvel Oct. 28, 2016, 11:42 a.m. UTC
Bring the RVCT version of the PrePi entry point code in line with the
GCC version, by using a relative rather than an absolute reference to
the mSystemMemoryEnd variable.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

---
 ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.asm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.7.4

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Leif Lindholm Oct. 28, 2016, 3:21 p.m. UTC | #1
On Fri, Oct 28, 2016 at 12:42:53PM +0100, Ard Biesheuvel wrote:
> Bring the RVCT version of the PrePi entry point code in line with the

> GCC version, by using a relative rather than an absolute reference to

> the mSystemMemoryEnd variable.

> 

> Contributed-under: TianoCore Contribution Agreement 1.0

> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>


Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>


> ---

>  ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.asm | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.asm b/ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.asm

> index 1e9daf563bb6..80c2877cbdbf 100644

> --- a/ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.asm

> +++ b/ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.asm

> @@ -48,7 +48,7 @@ _SetSVCMode

>  // to install the stacks at the bottom of the Firmware Device (case the FD is located

>  // at the top of the DRAM)

>  _SystemMemoryEndInit

> -  mov32 r1, mSystemMemoryEnd

> +  adrll r1, mSystemMemoryEnd

>    ldrd  r2, r3, [r1]

>    teq   r3, #0

>    moveq r1, r2

> -- 

> 2.7.4

> 

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
diff mbox

Patch

diff --git a/ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.asm b/ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.asm
index 1e9daf563bb6..80c2877cbdbf 100644
--- a/ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.asm
+++ b/ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.asm
@@ -48,7 +48,7 @@  _SetSVCMode
 // to install the stacks at the bottom of the Firmware Device (case the FD is located
 // at the top of the DRAM)
 _SystemMemoryEndInit
-  mov32 r1, mSystemMemoryEnd
+  adrll r1, mSystemMemoryEnd
   ldrd  r2, r3, [r1]
   teq   r3, #0
   moveq r1, r2