diff mbox series

[RFC,28/31] cmd: bdinfo: only dump the current LMB memory

Message ID 20240607185240.1892031-29-sughosh.ganu@linaro.org
State New
Headers show
Series Make U-Boot memory reservations coherent | expand

Commit Message

Sughosh Ganu June 7, 2024, 6:52 p.m. UTC
The LMB memory map is now persistent and global. There is therefore no
need to add memory to the LMB memory map as part of the bdinfo
command. Only dump the current available and reserved memory as part
of the bdinfo command.

Signed-off-by: Sughosh Ganu <sughosh.ganu@linaro.org>
---
 cmd/bdinfo.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Heinrich Schuchardt June 8, 2024, 3:59 a.m. UTC | #1
Am 7. Juni 2024 20:52:37 MESZ schrieb Sughosh Ganu <sughosh.ganu@linaro.org>:
>The LMB memory map is now persistent and global. There is therefore no
>need to add memory to the LMB memory map as part of the bdinfo
>command. Only dump the current available and reserved memory as part
>of the bdinfo command.

Would it make sense to move printing lmb memory to a separate command instead?

Best regards

Heinrich

>
>Signed-off-by: Sughosh Ganu <sughosh.ganu@linaro.org>
>---
> cmd/bdinfo.c | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/cmd/bdinfo.c b/cmd/bdinfo.c
>index fc408e9820..0f343203ef 100644
>--- a/cmd/bdinfo.c
>+++ b/cmd/bdinfo.c
>@@ -163,7 +163,6 @@ static int bdinfo_print_all(struct bd_info *bd)
> 	bdinfo_print_num_l("multi_dtb_fit", (ulong)gd->multi_dtb_fit);
> #endif
> 	if (IS_ENABLED(CONFIG_LMB) && gd->fdt_blob) {
>-		lmb_add_memory(gd->bd);
> 		lmb_dump_all_force();
> 		if (IS_ENABLED(CONFIG_OF_REAL))
> 			printf("devicetree  = %s\n", fdtdec_get_srcname());
Ilias Apalodimas June 10, 2024, 11:42 a.m. UTC | #2
On Sat, 8 Jun 2024 at 06:59, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>
>
>
> Am 7. Juni 2024 20:52:37 MESZ schrieb Sughosh Ganu <sughosh.ganu@linaro.org>:
> >The LMB memory map is now persistent and global. There is therefore no
> >need to add memory to the LMB memory map as part of the bdinfo
> >command. Only dump the current available and reserved memory as part
> >of the bdinfo command.
>
> Would it make sense to move printing lmb memory to a separate command instead?

Yes. Since are permanently reserving memory regions now we should have
a command to dump them.
Perhaps re-use cmd/mem.c?

Regards
/Ilias
>
> Best regards
>
> Heinrich
>
> >
> >Signed-off-by: Sughosh Ganu <sughosh.ganu@linaro.org>
> >---
> > cmd/bdinfo.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> >diff --git a/cmd/bdinfo.c b/cmd/bdinfo.c
> >index fc408e9820..0f343203ef 100644
> >--- a/cmd/bdinfo.c
> >+++ b/cmd/bdinfo.c
> >@@ -163,7 +163,6 @@ static int bdinfo_print_all(struct bd_info *bd)
> >       bdinfo_print_num_l("multi_dtb_fit", (ulong)gd->multi_dtb_fit);
> > #endif
> >       if (IS_ENABLED(CONFIG_LMB) && gd->fdt_blob) {
> >-              lmb_add_memory(gd->bd);
> >               lmb_dump_all_force();
> >               if (IS_ENABLED(CONFIG_OF_REAL))
> >                       printf("devicetree  = %s\n", fdtdec_get_srcname());
diff mbox series

Patch

diff --git a/cmd/bdinfo.c b/cmd/bdinfo.c
index fc408e9820..0f343203ef 100644
--- a/cmd/bdinfo.c
+++ b/cmd/bdinfo.c
@@ -163,7 +163,6 @@  static int bdinfo_print_all(struct bd_info *bd)
 	bdinfo_print_num_l("multi_dtb_fit", (ulong)gd->multi_dtb_fit);
 #endif
 	if (IS_ENABLED(CONFIG_LMB) && gd->fdt_blob) {
-		lmb_add_memory(gd->bd);
 		lmb_dump_all_force();
 		if (IS_ENABLED(CONFIG_OF_REAL))
 			printf("devicetree  = %s\n", fdtdec_get_srcname());