| Message ID | 20240606090050.327614-7-christian.loehle@arm.com |
|---|---|
| State | New |
| Headers | show |
| Series | cpuidle: teo: fixes and improvements | expand |
On 06/06/2024 11:00, Christian Loehle wrote: > When bailing out early, teo will not query the sleep length anymore > since commit 6da8f9ba5a87 ("cpuidle: teo: > Skip tick_nohz_get_sleep_length() call in some cases") with an > expected sleep_length_ns value of KTIME_MAX. > This lead to state0 accumulating lots of 'intercepts' because > the actually measured sleep length was < KTIME_MAX, so count KTIME_MAX > as a hit (we have to count them as something otherwise we are stuck). > > Fundamentally we can only do one of the two: > 1. Skip sleep_length_ns query when we think intercept is likely > 2. Have accurate data if sleep_length_ns is actually intercepted when > we believe it is currently intercepted. > > This patch chooses that latter as I've found the additional time it > takes to query the sleep length to be negligible and the variants of > option 1 (count all unknowns as misses or count all unknown as hits) > had significant regressions (as misses had lots of too shallow idle > state selections and as hits had terrible performance in > intercept-heavy workloads). So '2.' is the 'if (prev_intercept_idx != idx && !idx)' case ? [...] > @@ -514,6 +521,14 @@ static int teo_select(struct cpuidle_driver *drv, struct cpuidle_device *dev, > first_suitable_idx = i; > } > } > + if (prev_intercept_idx != idx && !idx) { if (!idx && prev_intercept_idx) ? > + /* > + * We have to query the sleep length here otherwise we don't > + * know after wakeup if our guess was correct. > + */ > + duration_ns = tick_nohz_get_sleep_length(&delta_tick); > + cpu_data->sleep_length_ns = duration_ns; > + } > > /* > * If there is a latency constraint, it may be necessary to select an
On 6/7/24 11:17, Dietmar Eggemann wrote: > On 06/06/2024 11:00, Christian Loehle wrote: >> When bailing out early, teo will not query the sleep length anymore >> since commit 6da8f9ba5a87 ("cpuidle: teo: >> Skip tick_nohz_get_sleep_length() call in some cases") with an >> expected sleep_length_ns value of KTIME_MAX. >> This lead to state0 accumulating lots of 'intercepts' because >> the actually measured sleep length was < KTIME_MAX, so count KTIME_MAX >> as a hit (we have to count them as something otherwise we are stuck). >> >> Fundamentally we can only do one of the two: >> 1. Skip sleep_length_ns query when we think intercept is likely >> 2. Have accurate data if sleep_length_ns is actually intercepted when >> we believe it is currently intercepted. >> >> This patch chooses that latter as I've found the additional time it >> takes to query the sleep length to be negligible and the variants of >> option 1 (count all unknowns as misses or count all unknown as hits) >> had significant regressions (as misses had lots of too shallow idle >> state selections and as hits had terrible performance in >> intercept-heavy workloads). > > So '2.' is the 'if (prev_intercept_idx != idx && !idx)' case ? > > [...] Yes, we allow the logic to bail out early, but not without querying the expected sleep length. (For idx > 0 the logic will continue to query the expected sleep length later on.) > >> @@ -514,6 +521,14 @@ static int teo_select(struct cpuidle_driver *drv, struct cpuidle_device *dev, >> first_suitable_idx = i; >> } >> } >> + if (prev_intercept_idx != idx && !idx) { > > if (!idx && prev_intercept_idx) ? > Thanks! I picked that up for the next version. >> + /* >> + * We have to query the sleep length here otherwise we don't >> + * know after wakeup if our guess was correct. >> + */ >> + duration_ns = tick_nohz_get_sleep_length(&delta_tick); >> + cpu_data->sleep_length_ns = duration_ns; >> + } >> >> /* >> * If there is a latency constraint, it may be necessary to select an >
diff --git a/drivers/cpuidle/governors/teo.c b/drivers/cpuidle/governors/teo.c index 3f4801d1e797..f41788ff0a94 100644 --- a/drivers/cpuidle/governors/teo.c +++ b/drivers/cpuidle/governors/teo.c @@ -288,8 +288,13 @@ static void teo_update(struct cpuidle_driver *drv, struct cpuidle_device *dev) * length, this is a "hit", so update the "hits" metric for that bin. * Otherwise, update the "intercepts" metric for the bin fallen into by * the measured idle duration. + * If teo_select() bailed out early, we have to count this as a hit as + * we don't know what the true sleep length would've been. Otherwise + * we accumulate lots of intercepts at the shallower state (especially + * state0) even though there weren't any intercepts due to us + * anticipating one. */ - if (idx_timer == idx_duration) + if (idx_timer == idx_duration || cpu_data->sleep_length_ns == KTIME_MAX) cpu_data->state_bins[idx_timer].hits += PULSE; else cpu_data->state_bins[idx_duration].intercepts += PULSE; @@ -349,6 +354,7 @@ static int teo_select(struct cpuidle_driver *drv, struct cpuidle_device *dev, unsigned int hit_sum = 0; int constraint_idx = 0; int idx0 = 0, idx = -1; + int prev_intercept_idx; bool cpu_utilized; s64 duration_ns; int i; @@ -463,6 +469,7 @@ static int teo_select(struct cpuidle_driver *drv, struct cpuidle_device *dev, * all of the deeper states a shallower idle state is likely to be a * better choice. */ + prev_intercept_idx = idx; if (2 * idx_intercept_sum > cpu_data->total - idx_hit_sum) { int first_suitable_idx = idx; @@ -514,6 +521,14 @@ static int teo_select(struct cpuidle_driver *drv, struct cpuidle_device *dev, first_suitable_idx = i; } } + if (prev_intercept_idx != idx && !idx) { + /* + * We have to query the sleep length here otherwise we don't + * know after wakeup if our guess was correct. + */ + duration_ns = tick_nohz_get_sleep_length(&delta_tick); + cpu_data->sleep_length_ns = duration_ns; + } /* * If there is a latency constraint, it may be necessary to select an
When bailing out early, teo will not query the sleep length anymore since commit 6da8f9ba5a87 ("cpuidle: teo: Skip tick_nohz_get_sleep_length() call in some cases") with an expected sleep_length_ns value of KTIME_MAX. This lead to state0 accumulating lots of 'intercepts' because the actually measured sleep length was < KTIME_MAX, so count KTIME_MAX as a hit (we have to count them as something otherwise we are stuck). Fundamentally we can only do one of the two: 1. Skip sleep_length_ns query when we think intercept is likely 2. Have accurate data if sleep_length_ns is actually intercepted when we believe it is currently intercepted. This patch chooses that latter as I've found the additional time it takes to query the sleep length to be negligible and the variants of option 1 (count all unknowns as misses or count all unknown as hits) had significant regressions (as misses had lots of too shallow idle state selections and as hits had terrible performance in intercept-heavy workloads). Fixes: 6da8f9ba5a87 ("cpuidle: teo: Skip tick_nohz_get_sleep_length() call in some cases") Signed-off-by: Christian Loehle <christian.loehle@arm.com> --- drivers/cpuidle/governors/teo.c | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-)