| Message ID | 20240610-md-drivers-pmdomain-amlogic-v1-1-b49ddb1a8bdf@quicinc.com |
|---|---|
| State | Accepted |
| Commit | cc647e931a249605e06d3eb3ec89a7e320fc28cc |
| Headers | show |
| Series | pmdomain: amlogic: add missing MODULE_DESCRIPTION() macros | expand |
On Tue, 11 Jun 2024 at 01:13, Jeff Johnson <quic_jjohnson@quicinc.com> wrote: > > On x86, make allmodconfig && make W=1 C=1 reports: > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pmdomain/amlogic/meson-gx-pwrc-vpu.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pmdomain/amlogic/meson-ee-pwrc.o > > Add the missing invocation of the MODULE_DESCRIPTION() macro to all > files which have a MODULE_LICENSE(). > > This includes meson-secure-pwrc.c which, although it did not produce a > warning with the x86 allmodconfig configuration, may cause this > warning with other configurations where CONFIG_MESON_SM is enabled. > > Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> Applied for next, thanks! Kind regards Uffe > --- > drivers/pmdomain/amlogic/meson-ee-pwrc.c | 1 + > drivers/pmdomain/amlogic/meson-gx-pwrc-vpu.c | 1 + > drivers/pmdomain/amlogic/meson-secure-pwrc.c | 1 + > 3 files changed, 3 insertions(+) > > diff --git a/drivers/pmdomain/amlogic/meson-ee-pwrc.c b/drivers/pmdomain/amlogic/meson-ee-pwrc.c > index fcec6eb610e4..fbb2b4103930 100644 > --- a/drivers/pmdomain/amlogic/meson-ee-pwrc.c > +++ b/drivers/pmdomain/amlogic/meson-ee-pwrc.c > @@ -648,4 +648,5 @@ static struct platform_driver meson_ee_pwrc_driver = { > }, > }; > module_platform_driver(meson_ee_pwrc_driver); > +MODULE_DESCRIPTION("Amlogic Meson Everything-Else Power Domains driver"); > MODULE_LICENSE("GPL v2"); > diff --git a/drivers/pmdomain/amlogic/meson-gx-pwrc-vpu.c b/drivers/pmdomain/amlogic/meson-gx-pwrc-vpu.c > index 33df520eab95..6028e91664a4 100644 > --- a/drivers/pmdomain/amlogic/meson-gx-pwrc-vpu.c > +++ b/drivers/pmdomain/amlogic/meson-gx-pwrc-vpu.c > @@ -376,4 +376,5 @@ static struct platform_driver meson_gx_pwrc_vpu_driver = { > }, > }; > module_platform_driver(meson_gx_pwrc_vpu_driver); > +MODULE_DESCRIPTION("Amlogic Meson GX Power Domains driver"); > MODULE_LICENSE("GPL v2"); > diff --git a/drivers/pmdomain/amlogic/meson-secure-pwrc.c b/drivers/pmdomain/amlogic/meson-secure-pwrc.c > index 4d5bda0d60fc..b50e5678abe3 100644 > --- a/drivers/pmdomain/amlogic/meson-secure-pwrc.c > +++ b/drivers/pmdomain/amlogic/meson-secure-pwrc.c > @@ -355,4 +355,5 @@ static struct platform_driver meson_secure_pwrc_driver = { > }, > }; > module_platform_driver(meson_secure_pwrc_driver); > +MODULE_DESCRIPTION("Amlogic Meson Secure Power Domains driver"); > MODULE_LICENSE("Dual MIT/GPL"); > > --- > base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670 > change-id: 20240610-md-drivers-pmdomain-amlogic-f117930600ea >
diff --git a/drivers/pmdomain/amlogic/meson-ee-pwrc.c b/drivers/pmdomain/amlogic/meson-ee-pwrc.c index fcec6eb610e4..fbb2b4103930 100644 --- a/drivers/pmdomain/amlogic/meson-ee-pwrc.c +++ b/drivers/pmdomain/amlogic/meson-ee-pwrc.c @@ -648,4 +648,5 @@ static struct platform_driver meson_ee_pwrc_driver = { }, }; module_platform_driver(meson_ee_pwrc_driver); +MODULE_DESCRIPTION("Amlogic Meson Everything-Else Power Domains driver"); MODULE_LICENSE("GPL v2"); diff --git a/drivers/pmdomain/amlogic/meson-gx-pwrc-vpu.c b/drivers/pmdomain/amlogic/meson-gx-pwrc-vpu.c index 33df520eab95..6028e91664a4 100644 --- a/drivers/pmdomain/amlogic/meson-gx-pwrc-vpu.c +++ b/drivers/pmdomain/amlogic/meson-gx-pwrc-vpu.c @@ -376,4 +376,5 @@ static struct platform_driver meson_gx_pwrc_vpu_driver = { }, }; module_platform_driver(meson_gx_pwrc_vpu_driver); +MODULE_DESCRIPTION("Amlogic Meson GX Power Domains driver"); MODULE_LICENSE("GPL v2"); diff --git a/drivers/pmdomain/amlogic/meson-secure-pwrc.c b/drivers/pmdomain/amlogic/meson-secure-pwrc.c index 4d5bda0d60fc..b50e5678abe3 100644 --- a/drivers/pmdomain/amlogic/meson-secure-pwrc.c +++ b/drivers/pmdomain/amlogic/meson-secure-pwrc.c @@ -355,4 +355,5 @@ static struct platform_driver meson_secure_pwrc_driver = { }, }; module_platform_driver(meson_secure_pwrc_driver); +MODULE_DESCRIPTION("Amlogic Meson Secure Power Domains driver"); MODULE_LICENSE("Dual MIT/GPL");
On x86, make allmodconfig && make W=1 C=1 reports: WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pmdomain/amlogic/meson-gx-pwrc-vpu.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pmdomain/amlogic/meson-ee-pwrc.o Add the missing invocation of the MODULE_DESCRIPTION() macro to all files which have a MODULE_LICENSE(). This includes meson-secure-pwrc.c which, although it did not produce a warning with the x86 allmodconfig configuration, may cause this warning with other configurations where CONFIG_MESON_SM is enabled. Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> --- drivers/pmdomain/amlogic/meson-ee-pwrc.c | 1 + drivers/pmdomain/amlogic/meson-gx-pwrc-vpu.c | 1 + drivers/pmdomain/amlogic/meson-secure-pwrc.c | 1 + 3 files changed, 3 insertions(+) --- base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670 change-id: 20240610-md-drivers-pmdomain-amlogic-f117930600ea