mbox series

[GIT,PULL,FOR,6.11] Imagination E5010 JPEG encoder

Message ID 20240611155528.mqmekz42cgs6jpdi@basti-XPS-13-9310
State New
Headers show
Series [GIT,PULL,FOR,6.11] Imagination E5010 JPEG encoder | expand

Pull-request

https://gitlab.collabora.com/sebastianfricke/linux.git tags/for-6.11-e5010-jpeg-encoder

Message

Sebastian Fricke June 11, 2024, 3:55 p.m. UTC
Hey Hans & Mauro,

Doesn't include the math changes and
https://patchwork.linuxtv.org/project/linux-media/patch/20240607133253.3559339-1-devarsht@ti.com/
has to be taken separately, as discussed here:
https://patchwork.linuxtv.org/project/linux-media/patch/20240604105335.2257629-1-devarsht@ti.com/#158409

Please pull.

The following changes since commit 1034ead1a7333e65e516c583f757717f461eba43:

   media: amphion: Report the average QP of current encoded frame (2024-06-10 10:24:30 +0200)

are available in the Git repository at:

   https://gitlab.collabora.com/sebastianfricke/linux.git tags/for-6.11-e5010-jpeg-encoder

for you to fetch changes up to 78459ad3a98ff2a28ead2d8d750e2ef3d27d1acc:

   media: verisilicon : Use exported tables from v4l2-jpeg for hantro codec (2024-06-11 17:39:43 +0200)

----------------------------------------------------------------
Imagination E5010 JPEG encoder

----------------------------------------------------------------
Devarsh Thakkar (6):
       media: dt-bindings: Add Imagination E5010 JPEG Encoder
       media: imagination: Add E5010 JPEG Encoder driver
       media: v4l2-jpeg: Export reference quantization and huffman tables
       media: Documentation: Document v4l2-jpeg helper functions
       media: imagination: Use exported tables from v4l2-jpeg core
       media: verisilicon : Use exported tables from v4l2-jpeg for hantro codec

  .../bindings/media/img,e5010-jpeg-enc.yaml         |   75 +
  Documentation/driver-api/media/v4l2-core.rst       |    1 +
  Documentation/driver-api/media/v4l2-jpeg.rst       |   10 +
  MAINTAINERS                                        |    7 +
  drivers/media/platform/Kconfig                     |    1 +
  drivers/media/platform/Makefile                    |    1 +
  drivers/media/platform/imagination/Kconfig         |   13 +
  drivers/media/platform/imagination/Makefile        |    3 +
  .../media/platform/imagination/e5010-core-regs.h   |  585 +++++++
  .../media/platform/imagination/e5010-jpeg-enc-hw.c |  267 ++++
  .../media/platform/imagination/e5010-jpeg-enc-hw.h |   42 +
  .../media/platform/imagination/e5010-jpeg-enc.c    | 1641 ++++++++++++++++++++
  .../media/platform/imagination/e5010-jpeg-enc.h    |  168 ++
  .../media/platform/imagination/e5010-mmu-regs.h    |  311 ++++
  drivers/media/platform/verisilicon/Kconfig         |    1 +
  drivers/media/platform/verisilicon/hantro_jpeg.c   |  128 +-
  drivers/media/v4l2-core/v4l2-jpeg.c                |  162 +-
  include/media/v4l2-jpeg.h                          |   28 +
  18 files changed, 3329 insertions(+), 115 deletions(-)
  create mode 100644 Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml
  create mode 100644 Documentation/driver-api/media/v4l2-jpeg.rst
  create mode 100644 drivers/media/platform/imagination/Kconfig
  create mode 100644 drivers/media/platform/imagination/Makefile
  create mode 100644 drivers/media/platform/imagination/e5010-core-regs.h
  create mode 100644 drivers/media/platform/imagination/e5010-jpeg-enc-hw.c
  create mode 100644 drivers/media/platform/imagination/e5010-jpeg-enc-hw.h
  create mode 100644 drivers/media/platform/imagination/e5010-jpeg-enc.c
  create mode 100644 drivers/media/platform/imagination/e5010-jpeg-enc.h
  create mode 100644 drivers/media/platform/imagination/e5010-mmu-regs.h

Comments

Devarsh Thakkar July 8, 2024, 4:10 p.m. UTC | #1
Hi Sebastian, Hans,

On 13/06/24 13:45, Hans Verkuil wrote:
> On 12/06/2024 07:57, Devarsh Thakkar wrote:
>> +Andrew,
>>
>> Hi Sebastian, Hans, Andrew,
>>
>> On 11/06/24 21:25, Sebastian Fricke wrote:
>>> Hey Hans & Mauro,
>>>
>>> Doesn't include the math changes and
>>> https://patchwork.linuxtv.org/project/linux-media/patch/20240607133253.3559339-1-devarsht@ti.com/
>>> has to be taken separately, as discussed here:
>>> https://patchwork.linuxtv.org/project/linux-media/patch/20240604105335.2257629-1-devarsht@ti.com/#158409
>>>
>>
>> I see Andy mentioned here [1] that math.h is orphaned and nobody behind it.
>> And I see changes in these files getting pulled in along with subsystem
>> specific changes [2].
>>
>> So just wanted to check if it's possible to include math.h related patches too
>> directly in this PR itself since they were already reviewed/Acked and I guess
>> this be a simpler path since they need to be applied on top of current set of
>> patches in this PR.
>>
>> So, Could you please let me know if it's possible to include all the 13
>> patches sent across [3] in this PR itself or some other path need to be taken
>> for math.h related patches?
> 
> I plan to take this PR (with just the first 6 patches) first today.
> 
> Once in, post a new patch series for the second half. Mention in the cover
> letter that math.h is orphaned (I wasn't aware of that) and I expect that
> Sebastian can make a second PR.
> 

As suggested above, I have posted the math.h related changes as a separate
series here [1] as I see that imagination jpeg series already got into
media_stage tree.

Kindly let me know if it's possible to have a PR for this or any other changes
required.

[1]: https://lore.kernel.org/all/20240708155943.2314427-1-devarsht@ti.com/#r

Regards
Devarsh