| Message ID | 20240610-md-drivers-pci-controller-v1-1-b998c242df55@quicinc.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | PCI: controller: add missing MODULE_DESCRIPTION() macros | expand |
On Mon, 10 Jun 2024 18:04:34 -0700 Jeff Johnson <quic_jjohnson@quicinc.com> wrote: > When ARCH=x86, make allmodconfig && make W=1 C=1 reports: > WARNING: modpost: missing MODULE_DESCRIPTION() in > drivers/pci/controller/dwc/pci-exynos.o WARNING: modpost: missing > MODULE_DESCRIPTION() in drivers/pci/controller/pci-host-generic.o > WARNING: modpost: missing MODULE_DESCRIPTION() in > drivers/pci/controller/pcie-altera.o WARNING: modpost: missing > MODULE_DESCRIPTION() in drivers/pci/controller/pcie-altera-msi.o > WARNING: modpost: missing MODULE_DESCRIPTION() in > drivers/pci/controller/pcie-mediatek.o WARNING: modpost: missing > MODULE_DESCRIPTION() in drivers/pci/controller/pcie-mediatek-gen3.o > WARNING: modpost: missing MODULE_DESCRIPTION() in > drivers/pci/controller/vmd.o WARNING: modpost: missing > MODULE_DESCRIPTION() in drivers/pci/controller/pcie-apple.o WARNING: > modpost: missing MODULE_DESCRIPTION() in > drivers/pci/controller/pcie-mt7621.o > > Add the missing invocations of the MODULE_DESCRIPTION() macro. > > Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> > --- > Corrections to these descriptions are welcomed. I'm not an expert in > this code so in most cases I've taken these descriptions directly from > code comments, Kconfig descriptions, or git logs. History has shown > that in some cases these are originally wrong due to cut-n-paste > errors, and in other cases the drivers have evolved such that the > original information is no longer accurate. > > Also let me know if any individual changes need to be split into a > separate patch to go through a separate maintainer tree. > --- > drivers/pci/controller/dwc/pci-exynos.c | 1 + > drivers/pci/controller/pci-host-common.c | 1 + > drivers/pci/controller/pci-host-generic.c | 1 + > drivers/pci/controller/pcie-altera-msi.c | 1 + > drivers/pci/controller/pcie-altera.c | 1 + > drivers/pci/controller/pcie-apple.c | 1 + > drivers/pci/controller/pcie-mediatek-gen3.c | 1 + > drivers/pci/controller/pcie-mediatek.c | 1 + > drivers/pci/controller/pcie-mt7621.c | 1 + > drivers/pci/controller/vmd.c | 1 + > 10 files changed, 10 insertions(+) > > diff --git a/drivers/pci/controller/dwc/pci-exynos.c > b/drivers/pci/controller/dwc/pci-exynos.c index > a33fa98a252e..79d83fe85d3b 100644 --- > a/drivers/pci/controller/dwc/pci-exynos.c +++ > b/drivers/pci/controller/dwc/pci-exynos.c @@ -437,5 +437,6 @@ static > struct platform_driver exynos_pcie_driver = { }, > }; > module_platform_driver(exynos_pcie_driver); > +MODULE_DESCRIPTION("PCIe host controller driver for Samsung Exynos > SoCs"); MODULE_LICENSE("GPL v2"); > MODULE_DEVICE_TABLE(of, exynos_pcie_of_match); > diff --git a/drivers/pci/controller/pci-host-common.c > b/drivers/pci/controller/pci-host-common.c index > 45b71806182d..60f5e328314e 100644 --- > a/drivers/pci/controller/pci-host-common.c +++ > b/drivers/pci/controller/pci-host-common.c @@ -96,4 +96,5 @@ void > pci_host_common_remove(struct platform_device *pdev) } > EXPORT_SYMBOL_GPL(pci_host_common_remove); > > +MODULE_DESCRIPTION("Generic PCI host driver common code"); > MODULE_LICENSE("GPL v2"); > diff --git a/drivers/pci/controller/pci-host-generic.c > b/drivers/pci/controller/pci-host-generic.c index > 41cb6a057f6e..cb911863a3cb 100644 --- > a/drivers/pci/controller/pci-host-generic.c +++ > b/drivers/pci/controller/pci-host-generic.c @@ -86,4 +86,5 @@ static > struct platform_driver gen_pci_driver = { }; > module_platform_driver(gen_pci_driver); > > +MODULE_DESCRIPTION("Simple, generic PCI host controller driver"); > MODULE_LICENSE("GPL v2"); > diff --git a/drivers/pci/controller/pcie-altera-msi.c > b/drivers/pci/controller/pcie-altera-msi.c index > 6ad5427490b5..25ad1717f1d8 100644 --- > a/drivers/pci/controller/pcie-altera-msi.c +++ > b/drivers/pci/controller/pcie-altera-msi.c @@ -290,4 +290,5 @@ static > void __exit altera_msi_exit(void) subsys_initcall(altera_msi_init); > MODULE_DEVICE_TABLE(of, altera_msi_of_match); > module_exit(altera_msi_exit); > +MODULE_DESCRIPTION("Altera PCIe MSI support"); > MODULE_LICENSE("GPL v2"); > diff --git a/drivers/pci/controller/pcie-altera.c > b/drivers/pci/controller/pcie-altera.c index > a9536dc4bf96..ef73baefaeb9 100644 --- > a/drivers/pci/controller/pcie-altera.c +++ > b/drivers/pci/controller/pcie-altera.c @@ -826,4 +826,5 @@ static > struct platform_driver altera_pcie_driver = { > MODULE_DEVICE_TABLE(of, altera_pcie_of_match); > module_platform_driver(altera_pcie_driver); > +MODULE_DESCRIPTION("Altera PCIe host controller driver"); > MODULE_LICENSE("GPL v2"); > diff --git a/drivers/pci/controller/pcie-apple.c > b/drivers/pci/controller/pcie-apple.c index > f7a248393a8f..5850bc84d58d 100644 --- > a/drivers/pci/controller/pcie-apple.c +++ > b/drivers/pci/controller/pcie-apple.c @@ -839,4 +839,5 @@ static > struct platform_driver apple_pcie_driver = { }; > module_platform_driver(apple_pcie_driver); > > +MODULE_DESCRIPTION("PCIe host bridge driver for Apple > system-on-chips"); MODULE_LICENSE("GPL v2"); > diff --git a/drivers/pci/controller/pcie-mediatek-gen3.c > b/drivers/pci/controller/pcie-mediatek-gen3.c index > 975b3024fb08..b7e8e24f6a40 100644 --- > a/drivers/pci/controller/pcie-mediatek-gen3.c +++ > b/drivers/pci/controller/pcie-mediatek-gen3.c @@ -1091,4 +1091,5 @@ > static struct platform_driver mtk_pcie_driver = { }; > > module_platform_driver(mtk_pcie_driver); > +MODULE_DESCRIPTION("MediaTek Gen3 PCIe host controller driver"); > MODULE_LICENSE("GPL v2"); > diff --git a/drivers/pci/controller/pcie-mediatek.c > b/drivers/pci/controller/pcie-mediatek.c index > 48372013f26d..7fc0d7709b7f 100644 --- > a/drivers/pci/controller/pcie-mediatek.c +++ > b/drivers/pci/controller/pcie-mediatek.c @@ -1252,4 +1252,5 @@ static > struct platform_driver mtk_pcie_driver = { }, > }; > module_platform_driver(mtk_pcie_driver); > +MODULE_DESCRIPTION("MediaTek PCIe host controller driver"); > MODULE_LICENSE("GPL v2"); > diff --git a/drivers/pci/controller/pcie-mt7621.c > b/drivers/pci/controller/pcie-mt7621.c index > d97b956e6e57..9989e5e614b9 100644 --- > a/drivers/pci/controller/pcie-mt7621.c +++ > b/drivers/pci/controller/pcie-mt7621.c @@ -549,4 +549,5 @@ static > struct platform_driver mt7621_pcie_driver = { }; > builtin_platform_driver(mt7621_pcie_driver); > > +MODULE_DESCRIPTION("MediaTek MT7621 PCIe controller"); > MODULE_LICENSE("GPL v2"); > diff --git a/drivers/pci/controller/vmd.c > b/drivers/pci/controller/vmd.c index 87b7856f375a..e4d6ae7241fe 100644 > --- a/drivers/pci/controller/vmd.c > +++ b/drivers/pci/controller/vmd.c > @@ -1128,5 +1128,6 @@ static struct pci_driver vmd_drv = { > module_pci_driver(vmd_drv); > > MODULE_AUTHOR("Intel Corporation"); > +MODULE_DESCRIPTION("Volume Management Device driver"); > MODULE_LICENSE("GPL v2"); > MODULE_VERSION("0.6"); > > --- > base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670 > change-id: 20240610-md-drivers-pci-controller-8de8948a2b92 > For VMD Acked-by: Nirmal Patel <nirmal.patel@linux.intel.com>
diff --git a/drivers/pci/controller/dwc/pci-exynos.c b/drivers/pci/controller/dwc/pci-exynos.c index a33fa98a252e..79d83fe85d3b 100644 --- a/drivers/pci/controller/dwc/pci-exynos.c +++ b/drivers/pci/controller/dwc/pci-exynos.c @@ -437,5 +437,6 @@ static struct platform_driver exynos_pcie_driver = { }, }; module_platform_driver(exynos_pcie_driver); +MODULE_DESCRIPTION("PCIe host controller driver for Samsung Exynos SoCs"); MODULE_LICENSE("GPL v2"); MODULE_DEVICE_TABLE(of, exynos_pcie_of_match); diff --git a/drivers/pci/controller/pci-host-common.c b/drivers/pci/controller/pci-host-common.c index 45b71806182d..60f5e328314e 100644 --- a/drivers/pci/controller/pci-host-common.c +++ b/drivers/pci/controller/pci-host-common.c @@ -96,4 +96,5 @@ void pci_host_common_remove(struct platform_device *pdev) } EXPORT_SYMBOL_GPL(pci_host_common_remove); +MODULE_DESCRIPTION("Generic PCI host driver common code"); MODULE_LICENSE("GPL v2"); diff --git a/drivers/pci/controller/pci-host-generic.c b/drivers/pci/controller/pci-host-generic.c index 41cb6a057f6e..cb911863a3cb 100644 --- a/drivers/pci/controller/pci-host-generic.c +++ b/drivers/pci/controller/pci-host-generic.c @@ -86,4 +86,5 @@ static struct platform_driver gen_pci_driver = { }; module_platform_driver(gen_pci_driver); +MODULE_DESCRIPTION("Simple, generic PCI host controller driver"); MODULE_LICENSE("GPL v2"); diff --git a/drivers/pci/controller/pcie-altera-msi.c b/drivers/pci/controller/pcie-altera-msi.c index 6ad5427490b5..25ad1717f1d8 100644 --- a/drivers/pci/controller/pcie-altera-msi.c +++ b/drivers/pci/controller/pcie-altera-msi.c @@ -290,4 +290,5 @@ static void __exit altera_msi_exit(void) subsys_initcall(altera_msi_init); MODULE_DEVICE_TABLE(of, altera_msi_of_match); module_exit(altera_msi_exit); +MODULE_DESCRIPTION("Altera PCIe MSI support"); MODULE_LICENSE("GPL v2"); diff --git a/drivers/pci/controller/pcie-altera.c b/drivers/pci/controller/pcie-altera.c index a9536dc4bf96..ef73baefaeb9 100644 --- a/drivers/pci/controller/pcie-altera.c +++ b/drivers/pci/controller/pcie-altera.c @@ -826,4 +826,5 @@ static struct platform_driver altera_pcie_driver = { MODULE_DEVICE_TABLE(of, altera_pcie_of_match); module_platform_driver(altera_pcie_driver); +MODULE_DESCRIPTION("Altera PCIe host controller driver"); MODULE_LICENSE("GPL v2"); diff --git a/drivers/pci/controller/pcie-apple.c b/drivers/pci/controller/pcie-apple.c index f7a248393a8f..5850bc84d58d 100644 --- a/drivers/pci/controller/pcie-apple.c +++ b/drivers/pci/controller/pcie-apple.c @@ -839,4 +839,5 @@ static struct platform_driver apple_pcie_driver = { }; module_platform_driver(apple_pcie_driver); +MODULE_DESCRIPTION("PCIe host bridge driver for Apple system-on-chips"); MODULE_LICENSE("GPL v2"); diff --git a/drivers/pci/controller/pcie-mediatek-gen3.c b/drivers/pci/controller/pcie-mediatek-gen3.c index 975b3024fb08..b7e8e24f6a40 100644 --- a/drivers/pci/controller/pcie-mediatek-gen3.c +++ b/drivers/pci/controller/pcie-mediatek-gen3.c @@ -1091,4 +1091,5 @@ static struct platform_driver mtk_pcie_driver = { }; module_platform_driver(mtk_pcie_driver); +MODULE_DESCRIPTION("MediaTek Gen3 PCIe host controller driver"); MODULE_LICENSE("GPL v2"); diff --git a/drivers/pci/controller/pcie-mediatek.c b/drivers/pci/controller/pcie-mediatek.c index 48372013f26d..7fc0d7709b7f 100644 --- a/drivers/pci/controller/pcie-mediatek.c +++ b/drivers/pci/controller/pcie-mediatek.c @@ -1252,4 +1252,5 @@ static struct platform_driver mtk_pcie_driver = { }, }; module_platform_driver(mtk_pcie_driver); +MODULE_DESCRIPTION("MediaTek PCIe host controller driver"); MODULE_LICENSE("GPL v2"); diff --git a/drivers/pci/controller/pcie-mt7621.c b/drivers/pci/controller/pcie-mt7621.c index d97b956e6e57..9989e5e614b9 100644 --- a/drivers/pci/controller/pcie-mt7621.c +++ b/drivers/pci/controller/pcie-mt7621.c @@ -549,4 +549,5 @@ static struct platform_driver mt7621_pcie_driver = { }; builtin_platform_driver(mt7621_pcie_driver); +MODULE_DESCRIPTION("MediaTek MT7621 PCIe controller"); MODULE_LICENSE("GPL v2"); diff --git a/drivers/pci/controller/vmd.c b/drivers/pci/controller/vmd.c index 87b7856f375a..e4d6ae7241fe 100644 --- a/drivers/pci/controller/vmd.c +++ b/drivers/pci/controller/vmd.c @@ -1128,5 +1128,6 @@ static struct pci_driver vmd_drv = { module_pci_driver(vmd_drv); MODULE_AUTHOR("Intel Corporation"); +MODULE_DESCRIPTION("Volume Management Device driver"); MODULE_LICENSE("GPL v2"); MODULE_VERSION("0.6");
When ARCH=x86, make allmodconfig && make W=1 C=1 reports: WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pci/controller/dwc/pci-exynos.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pci/controller/pci-host-generic.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pci/controller/pcie-altera.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pci/controller/pcie-altera-msi.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pci/controller/pcie-mediatek.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pci/controller/pcie-mediatek-gen3.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pci/controller/vmd.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pci/controller/pcie-apple.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pci/controller/pcie-mt7621.o Add the missing invocations of the MODULE_DESCRIPTION() macro. Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> --- Corrections to these descriptions are welcomed. I'm not an expert in this code so in most cases I've taken these descriptions directly from code comments, Kconfig descriptions, or git logs. History has shown that in some cases these are originally wrong due to cut-n-paste errors, and in other cases the drivers have evolved such that the original information is no longer accurate. Also let me know if any individual changes need to be split into a separate patch to go through a separate maintainer tree. --- drivers/pci/controller/dwc/pci-exynos.c | 1 + drivers/pci/controller/pci-host-common.c | 1 + drivers/pci/controller/pci-host-generic.c | 1 + drivers/pci/controller/pcie-altera-msi.c | 1 + drivers/pci/controller/pcie-altera.c | 1 + drivers/pci/controller/pcie-apple.c | 1 + drivers/pci/controller/pcie-mediatek-gen3.c | 1 + drivers/pci/controller/pcie-mediatek.c | 1 + drivers/pci/controller/pcie-mt7621.c | 1 + drivers/pci/controller/vmd.c | 1 + 10 files changed, 10 insertions(+) --- base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670 change-id: 20240610-md-drivers-pci-controller-8de8948a2b92