| Message ID | 1478021115-22781-2-git-send-email-ard.biesheuvel@linaro.org |
|---|---|
| State | Accepted |
| Commit | 4edacd6541c22eac97098c9f68186438e775fb0c |
| Headers | show |
On Tue, Nov 01, 2016 at 05:25:08PM +0000, Ard Biesheuvel wrote: > Drop the following PCD settings from Cello and Overdrive, which > remove support for display descriptive names when listing drivers > and devices. Suggest rewording as: --- Enable displaying of descriptive names when listing drivers and devices by dropping the following overrides of default PCD values: --- With that: Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org> (No need to include for any v2 of the series, this one stands on its own.) > gEfiMdePkgTokenSpaceGuid.PcdComponentNameDisable|TRUE > gEfiMdePkgTokenSpaceGuid.PcdComponentName2Disable|TRUE > gEfiMdePkgTokenSpaceGuid.PcdDriverDiagnosticsDisable|TRUE > gEfiMdePkgTokenSpaceGuid.PcdDriverDiagnostics2Disable|TRUE > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > --- > Platforms/AMD/Styx/CelloBoard/CelloBoard.dsc | 5 ----- > Platforms/AMD/Styx/OverdriveBoard/OverdriveBoard.dsc | 5 ----- > 2 files changed, 10 deletions(-) > > diff --git a/Platforms/AMD/Styx/CelloBoard/CelloBoard.dsc b/Platforms/AMD/Styx/CelloBoard/CelloBoard.dsc > index dda107ceca06..e668b6b06d13 100644 > --- a/Platforms/AMD/Styx/CelloBoard/CelloBoard.dsc > +++ b/Platforms/AMD/Styx/CelloBoard/CelloBoard.dsc > @@ -272,11 +272,6 @@ DEFINE DO_KCS = 0 > ################################################################################ > > [PcdsFeatureFlag.common] > - gEfiMdePkgTokenSpaceGuid.PcdComponentNameDisable|TRUE > - gEfiMdePkgTokenSpaceGuid.PcdDriverDiagnosticsDisable|TRUE > - gEfiMdePkgTokenSpaceGuid.PcdComponentName2Disable|TRUE > - gEfiMdePkgTokenSpaceGuid.PcdDriverDiagnostics2Disable|TRUE > - > # All pages are cached by default > gEmbeddedTokenSpaceGuid.PcdCacheEnable|TRUE > > diff --git a/Platforms/AMD/Styx/OverdriveBoard/OverdriveBoard.dsc b/Platforms/AMD/Styx/OverdriveBoard/OverdriveBoard.dsc > index 232bab7fc888..70b94df7d6da 100644 > --- a/Platforms/AMD/Styx/OverdriveBoard/OverdriveBoard.dsc > +++ b/Platforms/AMD/Styx/OverdriveBoard/OverdriveBoard.dsc > @@ -279,11 +279,6 @@ DEFINE DO_KCS = 1 > ################################################################################ > > [PcdsFeatureFlag.common] > - gEfiMdePkgTokenSpaceGuid.PcdComponentNameDisable|TRUE > - gEfiMdePkgTokenSpaceGuid.PcdDriverDiagnosticsDisable|TRUE > - gEfiMdePkgTokenSpaceGuid.PcdComponentName2Disable|TRUE > - gEfiMdePkgTokenSpaceGuid.PcdDriverDiagnostics2Disable|TRUE > - > # All pages are cached by default > gEmbeddedTokenSpaceGuid.PcdCacheEnable|TRUE > > -- > 2.7.4 >
On 1 November 2016 at 23:16, Leif Lindholm <leif.lindholm@linaro.org> wrote: > On Tue, Nov 01, 2016 at 05:25:08PM +0000, Ard Biesheuvel wrote: >> Drop the following PCD settings from Cello and Overdrive, which >> remove support for display descriptive names when listing drivers >> and devices. > > Suggest rewording as: > --- > Enable displaying of descriptive names when listing drivers and > devices by dropping the following overrides of default PCD values: > --- > With that: > Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org> > > (No need to include for any v2 of the series, this one stands on its own.) > Pushed, thanks.
diff --git a/Platforms/AMD/Styx/CelloBoard/CelloBoard.dsc b/Platforms/AMD/Styx/CelloBoard/CelloBoard.dsc index dda107ceca06..e668b6b06d13 100644 --- a/Platforms/AMD/Styx/CelloBoard/CelloBoard.dsc +++ b/Platforms/AMD/Styx/CelloBoard/CelloBoard.dsc @@ -272,11 +272,6 @@ DEFINE DO_KCS = 0 ################################################################################ [PcdsFeatureFlag.common] - gEfiMdePkgTokenSpaceGuid.PcdComponentNameDisable|TRUE - gEfiMdePkgTokenSpaceGuid.PcdDriverDiagnosticsDisable|TRUE - gEfiMdePkgTokenSpaceGuid.PcdComponentName2Disable|TRUE - gEfiMdePkgTokenSpaceGuid.PcdDriverDiagnostics2Disable|TRUE - # All pages are cached by default gEmbeddedTokenSpaceGuid.PcdCacheEnable|TRUE diff --git a/Platforms/AMD/Styx/OverdriveBoard/OverdriveBoard.dsc b/Platforms/AMD/Styx/OverdriveBoard/OverdriveBoard.dsc index 232bab7fc888..70b94df7d6da 100644 --- a/Platforms/AMD/Styx/OverdriveBoard/OverdriveBoard.dsc +++ b/Platforms/AMD/Styx/OverdriveBoard/OverdriveBoard.dsc @@ -279,11 +279,6 @@ DEFINE DO_KCS = 1 ################################################################################ [PcdsFeatureFlag.common] - gEfiMdePkgTokenSpaceGuid.PcdComponentNameDisable|TRUE - gEfiMdePkgTokenSpaceGuid.PcdDriverDiagnosticsDisable|TRUE - gEfiMdePkgTokenSpaceGuid.PcdComponentName2Disable|TRUE - gEfiMdePkgTokenSpaceGuid.PcdDriverDiagnostics2Disable|TRUE - # All pages are cached by default gEmbeddedTokenSpaceGuid.PcdCacheEnable|TRUE
Drop the following PCD settings from Cello and Overdrive, which remove support for display descriptive names when listing drivers and devices. gEfiMdePkgTokenSpaceGuid.PcdComponentNameDisable|TRUE gEfiMdePkgTokenSpaceGuid.PcdComponentName2Disable|TRUE gEfiMdePkgTokenSpaceGuid.PcdDriverDiagnosticsDisable|TRUE gEfiMdePkgTokenSpaceGuid.PcdDriverDiagnostics2Disable|TRUE Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> --- Platforms/AMD/Styx/CelloBoard/CelloBoard.dsc | 5 ----- Platforms/AMD/Styx/OverdriveBoard/OverdriveBoard.dsc | 5 ----- 2 files changed, 10 deletions(-)