diff mbox series

[v2] Bluetooth: btnxpuart: Enable Power Save feature on startup

Message ID 20240614082039.6465-1-neeraj.sanjaykale@nxp.com
State Accepted
Commit bafd12aba679d2ec0ebb4bc362ed4cb81b36b791
Headers show
Series [v2] Bluetooth: btnxpuart: Enable Power Save feature on startup | expand

Commit Message

Neeraj Sanjay Kale June 14, 2024, 8:20 a.m. UTC
This sets the default power save mode setting to enabled.

The power save feature is now stable and stress test issues, such as the
TX timeout error, have been resolved.
commit c7ee0bc8db32 ("Bluetooth: btnxpuart: Resolve TX timeout error in
power save stress test")

With this setting, the driver will send the vendor command to FW at
startup, to enable power save feature.

User can disable this feature using the following vendor command:
hcitool cmd 3f 23 03 00 00 (HCI_NXP_AUTO_SLEEP_MODE)

Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
---
v2: Corrected subject line. Added commit reference. (Paul Menzel)
 drivers/bluetooth/btnxpuart.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

patchwork-bot+bluetooth@kernel.org June 14, 2024, 5 p.m. UTC | #1
Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Fri, 14 Jun 2024 13:50:39 +0530 you wrote:
> This sets the default power save mode setting to enabled.
> 
> The power save feature is now stable and stress test issues, such as the
> TX timeout error, have been resolved.
> commit c7ee0bc8db32 ("Bluetooth: btnxpuart: Resolve TX timeout error in
> power save stress test")
> 
> [...]

Here is the summary with links:
  - [v2] Bluetooth: btnxpuart: Enable Power Save feature on startup
    https://git.kernel.org/bluetooth/bluetooth-next/c/1db01d15e2da

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/bluetooth/btnxpuart.c b/drivers/bluetooth/btnxpuart.c
index 7f88b6f52f26..42e929f0d141 100644
--- a/drivers/bluetooth/btnxpuart.c
+++ b/drivers/bluetooth/btnxpuart.c
@@ -281,7 +281,7 @@  static u8 crc8_table[CRC8_TABLE_SIZE];
 
 /* Default configurations */
 #define DEFAULT_H2C_WAKEUP_MODE	WAKEUP_METHOD_BREAK
-#define DEFAULT_PS_MODE		PS_MODE_DISABLE
+#define DEFAULT_PS_MODE		PS_MODE_ENABLE
 #define FW_INIT_BAUDRATE	HCI_NXP_PRI_BAUDRATE
 
 static struct sk_buff *nxp_drv_send_cmd(struct hci_dev *hdev, u16 opcode,