| Message ID | 20240617184504.304211-2-dima.fedrau@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v4,1/2] dt-bindings: power: supply: add support for MAX17201/MAX17205 fuel gauge | expand |
On 17/06/2024 20:45, Dimitri Fedrau wrote: > Adding documentation for MAXIMs MAX17201/MAX17205 fuel gauge. > > Signed-off-by: Dimitri Fedrau <dima.fedrau@gmail.com> > --- > .../bindings/power/supply/maxim,max1720x.yaml | 55 +++++++++++++++++++ > 1 file changed, 55 insertions(+) > create mode 100644 Documentation/devicetree/bindings/power/supply/maxim,max1720x.yaml > > diff --git a/Documentation/devicetree/bindings/power/supply/maxim,max1720x.yaml b/Documentation/devicetree/bindings/power/supply/maxim,max1720x.yaml > new file mode 100644 > index 000000000000..52467af5388a > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/supply/maxim,max1720x.yaml > @@ -0,0 +1,55 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/power/supply/maxim,max1720x.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Maxim MAX1720x fuel gauge > + > +maintainers: > + - Dimitri Fedrau <dima.fedrau@gmail.com> > + > +allOf: > + - $ref: power-supply.yaml# > + > +properties: > + compatible: > + enum: > + - maxim,max17201 > + - maxim,max17205 Your driver suggests these are compatible, so express it in the bindings (oneOf with list and fallback). https://elixir.bootlin.com/linux/v6.3-rc6/source/Documentation/devicetree/bindings/sound/nvidia,tegra210-ope.yaml#L31 Best regards, Krzysztof
Hi, On Mon, Jun 17, 2024 at 08:45:03PM GMT, Dimitri Fedrau wrote: > Adding documentation for MAXIMs MAX17201/MAX17205 fuel gauge. > > Signed-off-by: Dimitri Fedrau <dima.fedrau@gmail.com> > --- > .../bindings/power/supply/maxim,max1720x.yaml | 55 +++++++++++++++++++ > 1 file changed, 55 insertions(+) > create mode 100644 Documentation/devicetree/bindings/power/supply/maxim,max1720x.yaml > > diff --git a/Documentation/devicetree/bindings/power/supply/maxim,max1720x.yaml b/Documentation/devicetree/bindings/power/supply/maxim,max1720x.yaml > new file mode 100644 > index 000000000000..52467af5388a > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/supply/maxim,max1720x.yaml > @@ -0,0 +1,55 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/power/supply/maxim,max1720x.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Maxim MAX1720x fuel gauge > + > +maintainers: > + - Dimitri Fedrau <dima.fedrau@gmail.com> > + > +allOf: > + - $ref: power-supply.yaml# [...] > +additionalProperties: false this needs to be "unevaluatedProperties: false", otherwise the properties from power-supply.yaml won't be allowed. Greetings, -- Sebastian
diff --git a/Documentation/devicetree/bindings/power/supply/maxim,max1720x.yaml b/Documentation/devicetree/bindings/power/supply/maxim,max1720x.yaml new file mode 100644 index 000000000000..52467af5388a --- /dev/null +++ b/Documentation/devicetree/bindings/power/supply/maxim,max1720x.yaml @@ -0,0 +1,55 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/power/supply/maxim,max1720x.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Maxim MAX1720x fuel gauge + +maintainers: + - Dimitri Fedrau <dima.fedrau@gmail.com> + +allOf: + - $ref: power-supply.yaml# + +properties: + compatible: + enum: + - maxim,max17201 + - maxim,max17205 + + reg: + items: + - description: ModelGauge m5 registers + - description: Nonvolatile registers + + reg-names: + items: + - const: m5 + - const: nvmem + + interrupts: + maxItems: 1 + +required: + - compatible + - reg + - reg-names + +additionalProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/irq.h> + i2c { + #address-cells = <1>; + #size-cells = <0>; + + fuel-gauge@36 { + compatible = "maxim,max17201"; + reg = <0x36>, <0xb>; + reg-names = "m5", "nvmem"; + interrupt-parent = <&gpio0>; + interrupts = <31 IRQ_TYPE_LEVEL_LOW>; + }; + };
Adding documentation for MAXIMs MAX17201/MAX17205 fuel gauge. Signed-off-by: Dimitri Fedrau <dima.fedrau@gmail.com> --- .../bindings/power/supply/maxim,max1720x.yaml | 55 +++++++++++++++++++ 1 file changed, 55 insertions(+) create mode 100644 Documentation/devicetree/bindings/power/supply/maxim,max1720x.yaml