| Message ID | 20240626095056.12607-1-bavishimithil@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2] ARM: dts: twl6032: Add DTS file for TWL6032 PMIC | expand |
Hello, is there anything blocking this? Previous problems have been mentioned in this v2 patch, any further reviews? Best Regards, Mithil
Am Wed, 26 Jun 2024 15:20:56 +0530 schrieb Mighty <bavishimithil@gmail.com>: > From: Mithil Bavishi <bavishimithil@gmail.com> > > Add a dedicated DTS file for the TWL6032 PMIC (Phoenix Lite). Already > has driver support with TWL6030 (Phoenix) since both of them are so > similar, some nodes can be reused from TWL6030 as well. > > This can be included in the board files like twl6030. > Example: > ... > &i2c1 { > twl: twl@48 { > reg = <0x48>; > interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>; > interrupt-controller; > interrupt-parent = <&gic>; > }; > }; > > /include/ "twl6032.dtsi" > ... > > Used in devices like samsung-espresso, amazon-jem, epson-embt2ws etc. > Well, no, the file is not used at the moment, I do not think it makes sense to have it in without an actual in-tree user. Regards, Andreas
> Well, no, the file is not used at the moment, I do not think it makes sense to have it in without an actual in-tree user.
So, I am planning to merge espresso dts (https://gitlab.postmarketos.org/postmarketOS/pmaports/-/blob/master/device/community/linux-postmarketos-omap/0002-arm-dts-Add-common-dtsi-for-espresso.patch?ref_type=heads) once this gets merged, plus it can be later used on epson-embt2ws as well.
Best Regards,
Mithil
Hi Mithil, Am Tue, 29 Oct 2024 20:30:14 +0000 schrieb MightyM17 <bavishimithil@gmail.com>: > > Well, no, the file is not used at the moment, I do not think it > > makes sense to have it in without an actual in-tree user. > > So, I am planning to merge espresso dts > (https://gitlab.postmarketos.org/postmarketOS/pmaports/-/blob/master/device/community/linux-postmarketos-omap/0002-arm-dts-Add-common-dtsi-for-espresso.patch?ref_type=heads) > once this gets merged, plus it can be later used on epson-embt2ws as > well. > well, lets merge the stuff together with a dts as an actual user, so submit a full patch set with - binding patch for board compatible - dtsi files - at least one dts file having a short look at the patch you linked, you still have some underscores in node names. Regards, Andreas
diff --git a/arch/arm/boot/dts/ti/omap/twl6032.dtsi b/arch/arm/boot/dts/ti/omap/twl6032.dtsi new file mode 100644 index 000000000..4372ce466 --- /dev/null +++ b/arch/arm/boot/dts/ti/omap/twl6032.dtsi @@ -0,0 +1,81 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Integrated Power Management Chip + * https://www.ti.com/lit/ds/symlink/twl6032.pdf + */ + +&twl { + compatible = "ti,twl6032"; + interrupt-controller; + #interrupt-cells = <1>; + + rtc { + compatible = "ti,twl4030-rtc"; + interrupts = <11>; + }; + + vana: regulator-vana { + compatible = "ti,twl6030-vana"; + }; + + vio: regulator-vio { + compatible = "ti,twl6032-vio"; + }; + + ldo1: regulator-ldo1 { + compatible = "ti,twl6032-ldo1"; + }; + + ldo2: regulator-ldo2 { + compatible = "ti,twl6032-ldo2"; + }; + + ldo3: regulator-ldo3 { + compatible = "ti,twl6032-ldo3"; + }; + + ldo4: regulator-ldo4 { + compatible = "ti,twl6032-ldo4"; + }; + + ldo5: regulator-ldo5 { + compatible = "ti,twl6032-ldo5"; + }; + + ldo6: regulator-ldo6 { + compatible = "ti,twl6032-ldo6"; + }; + + ldoln: regulator-ldoln { + compatible = "ti,twl6032-ldoln"; + }; + + ldousb: regulator-ldousb { + compatible = "ti,twl6032-ldousb"; + }; + + smps4: regulator-smps4 { + compatible = "ti,twl6032-smps4"; + }; + + gpadc: gpadc { + compatible = "ti,twl6032-gpadc"; + interrupts = <3>; + io-channel-cells = <1>; + }; + + twl_usb_comparator: usb-comparator { + compatible = "ti,twl6030-usb"; + interrupts = <4>, <10>; + }; + + twl_pwm: pwm { + compatible = "ti,twl6030-pwm"; + #pwm-cells = <2>; + }; + + twl_pwmled: pwmled { + compatible = "ti,twl6030-pwmled"; + #pwm-cells = <2>; + }; +};