| Message ID | 20240704093002.15155-1-amishin@t-argos.ru |
|---|---|
| State | Superseded |
| Headers | show |
| Series | drm/msm: Fix incorrect file name output in adreno_request_fw() | expand |
On 04/07/2024 12:30, Aleksandr Mishin wrote: > In adreno_request_fw() when debugging information is printed to the log > after firmware load, an incorrect filename is printed. 'newname' is used > instead of 'fwname', so prefix "qcom/" is being added to filename. > Looks like "copy-paste" mistake. > > Fix this mistake by replacing 'newname' with 'fwname'. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Fixes: 9fe041f6fdfe ("drm/msm: Add msm_gem_get_and_pin_iova()") Fixes tag is incorrect, LGTM otherwise. > Signed-off-by: Aleksandr Mishin <amishin@t-argos.ru> > --- > drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c > index 074fb498706f..0bb7d66047f8 100644 > --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c > +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c > @@ -475,7 +475,7 @@ adreno_request_fw(struct adreno_gpu *adreno_gpu, const char *fwname) > ret = request_firmware_direct(&fw, fwname, drm->dev); > if (!ret) { > DRM_DEV_INFO(drm->dev, "loaded %s from legacy location\n", > - newname); > + fwname); > adreno_gpu->fwloc = FW_LOCATION_LEGACY; > goto out; > } else if (adreno_gpu->fwloc != FW_LOCATION_UNKNOWN) {
diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c index 074fb498706f..0bb7d66047f8 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c @@ -475,7 +475,7 @@ adreno_request_fw(struct adreno_gpu *adreno_gpu, const char *fwname) ret = request_firmware_direct(&fw, fwname, drm->dev); if (!ret) { DRM_DEV_INFO(drm->dev, "loaded %s from legacy location\n", - newname); + fwname); adreno_gpu->fwloc = FW_LOCATION_LEGACY; goto out; } else if (adreno_gpu->fwloc != FW_LOCATION_UNKNOWN) {
In adreno_request_fw() when debugging information is printed to the log after firmware load, an incorrect filename is printed. 'newname' is used instead of 'fwname', so prefix "qcom/" is being added to filename. Looks like "copy-paste" mistake. Fix this mistake by replacing 'newname' with 'fwname'. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 9fe041f6fdfe ("drm/msm: Add msm_gem_get_and_pin_iova()") Signed-off-by: Aleksandr Mishin <amishin@t-argos.ru> --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)