| Message ID | 1478533784-29037-1-git-send-email-maxim.uvarov@linaro.org |
|---|---|
| State | Accepted |
| Commit | 90ac2ecbf8aec6d4f876d161b3844c199527c33e |
| Headers | show |
On 7 November 2016 at 10:49, Maxim Uvarov <maxim.uvarov@linaro.org> wrote: > Turn on linux-generic dpdk and pcap pktios with their validation > tests. > > Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org> Reviewed-by: Mike Holmes <mike.holmes@linaro.org> We need to make this complete and add netmap pktio to cover all the possibilities We could also do with a matrix to cover the different schedulers possibly. > --- > .travis.yml | 22 ++++++++++++++++++---- > 1 file changed, 18 insertions(+), 4 deletions(-) > > diff --git a/.travis.yml b/.travis.yml > index 0d1add3..1092cd0 100644 > --- a/.travis.yml > +++ b/.travis.yml > @@ -11,6 +11,7 @@ sudo: required > before_install: > - sudo apt-get -qq update > - sudo apt-get install automake autoconf libtool libssl-dev graphviz mscgen doxygen > + - sudo apt-get install libpcap-dev linux-headers-`uname -r` > - gem install asciidoctor > > # Install cunit for the validation tests because distro version is too old and fails C99 compile > @@ -24,12 +25,25 @@ before_install: > - sudo make install > - cd .. > - export LD_LIBRARY_PATH="/usr/local/lib:$LD_LIBRARY_PATH" > - > -install: > - - ./bootstrap > +# DPDK pktio > + - TARGET=${TARGET:-"x86_64-native-linuxapp-gcc"} > + - git clone http://dpdk.org/git/dpdk dpdk > + - pushd dpdk > + - git checkout -b bv16.07 v16.07 > + - make config T=${TARGET} O=${TARGET} > + - pushd ${TARGET} > + - sed -ri 's,(CONFIG_RTE_LIBRTE_PMD_PCAP=).*,\1y,' .config > + - popd > + - make install T=${TARGET} EXTRA_CFLAGS="-fPIC" > + - popd > > script: > - - ./configure --enable-test-cpp --enable-test-vald --enable-test-helper --enable-test-perf --enable-user-guides --enable-test-perf-proc --enable-test-example > + > + - ./bootstrap > + - ./configure --enable-test-cpp --enable-test-vald --enable-test-helper --enable-test-perf --enable-user-guides --enable-test-perf-proc --enable-test-example --with-dpdk-path=`pwd`/dpdk/${TARGET} > - make check > + - git clean -f -d -x && rm -rf dpdk > + - ./bootstrap > + - ./configure > - make doxygen-doc > - make distcheck > -- > 2.7.1.250.gff4ea60 > -- Mike Holmes Program Manager - Linaro Networking Group Linaro.org │ Open source software for ARM SoCs "Work should be fun and collaborative, the rest follows"
On 7 November 2016 at 16:49, Maxim Uvarov <maxim.uvarov@linaro.org> wrote: > Turn on linux-generic dpdk and pcap pktios with their validation > tests. > > Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org> > --- > .travis.yml | 22 ++++++++++++++++++---- > 1 file changed, 18 insertions(+), 4 deletions(-) > > diff --git a/.travis.yml b/.travis.yml > index 0d1add3..1092cd0 100644 > --- a/.travis.yml > +++ b/.travis.yml > @@ -11,6 +11,7 @@ sudo: required > before_install: > - sudo apt-get -qq update > - sudo apt-get install automake autoconf libtool libssl-dev graphviz mscgen doxygen > + - sudo apt-get install libpcap-dev linux-headers-`uname -r` > - gem install asciidoctor > > # Install cunit for the validation tests because distro version is too old and fails C99 compile > @@ -24,12 +25,25 @@ before_install: > - sudo make install > - cd .. > - export LD_LIBRARY_PATH="/usr/local/lib:$LD_LIBRARY_PATH" > - > -install: > - - ./bootstrap > +# DPDK pktio > + - TARGET=${TARGET:-"x86_64-native-linuxapp-gcc"} > + - git clone http://dpdk.org/git/dpdk dpdk > + - pushd dpdk > + - git checkout -b bv16.07 v16.07 > + - make config T=${TARGET} O=${TARGET} > + - pushd ${TARGET} > + - sed -ri 's,(CONFIG_RTE_LIBRTE_PMD_PCAP=).*,\1y,' .config > + - popd > + - make install T=${TARGET} EXTRA_CFLAGS="-fPIC" > + - popd why do we build DPDK from source and not just consume the deb package with apt-get install? Cheers, Anders > > script: > - - ./configure --enable-test-cpp --enable-test-vald --enable-test-helper --enable-test-perf --enable-user-guides --enable-test-perf-proc --enable-test-example > + > + - ./bootstrap > + - ./configure --enable-test-cpp --enable-test-vald --enable-test-helper --enable-test-perf --enable-user-guides --enable-test-perf-proc --enable-test-example --with-dpdk-path=`pwd`/dpdk/${TARGET} > - make check > + - git clean -f -d -x && rm -rf dpdk > + - ./bootstrap > + - ./configure > - make doxygen-doc > - make distcheck > -- > 2.7.1.250.gff4ea60 >
On 11/18/16 12:06, Anders Roxell wrote: > On 7 November 2016 at 16:49, Maxim Uvarov <maxim.uvarov@linaro.org> wrote: >> Turn on linux-generic dpdk and pcap pktios with their validation >> tests. >> >> Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org> >> --- >> .travis.yml | 22 ++++++++++++++++++---- >> 1 file changed, 18 insertions(+), 4 deletions(-) >> >> diff --git a/.travis.yml b/.travis.yml >> index 0d1add3..1092cd0 100644 >> --- a/.travis.yml >> +++ b/.travis.yml >> @@ -11,6 +11,7 @@ sudo: required >> before_install: >> - sudo apt-get -qq update >> - sudo apt-get install automake autoconf libtool libssl-dev graphviz mscgen doxygen >> + - sudo apt-get install libpcap-dev linux-headers-`uname -r` >> - gem install asciidoctor >> >> # Install cunit for the validation tests because distro version is too old and fails C99 compile >> @@ -24,12 +25,25 @@ before_install: >> - sudo make install >> - cd .. >> - export LD_LIBRARY_PATH="/usr/local/lib:$LD_LIBRARY_PATH" >> - >> -install: >> - - ./bootstrap >> +# DPDK pktio >> + - TARGET=${TARGET:-"x86_64-native-linuxapp-gcc"} >> + - git clone http://dpdk.org/git/dpdk dpdk >> + - pushd dpdk >> + - git checkout -b bv16.07 v16.07 >> + - make config T=${TARGET} O=${TARGET} >> + - pushd ${TARGET} >> + - sed -ri 's,(CONFIG_RTE_LIBRTE_PMD_PCAP=).*,\1y,' .config >> + - popd >> + - make install T=${TARGET} EXTRA_CFLAGS="-fPIC" >> + - popd > why do we build DPDK from source and not just consume the deb package > with apt-get install? > > Cheers, > Anders > my ubuntu does not have dpdk deb package in apt repository. Especially v16.07 with PMD_PCAP and -fPIC. Current script follows steps from README. But I don't object if you want speed up tests with pre built dpdk package. Maxim. >> script: >> - - ./configure --enable-test-cpp --enable-test-vald --enable-test-helper --enable-test-perf --enable-user-guides --enable-test-perf-proc --enable-test-example >> + >> + - ./bootstrap >> + - ./configure --enable-test-cpp --enable-test-vald --enable-test-helper --enable-test-perf --enable-user-guides --enable-test-perf-proc --enable-test-example --with-dpdk-path=`pwd`/dpdk/${TARGET} >> - make check >> + - git clean -f -d -x && rm -rf dpdk >> + - ./bootstrap >> + - ./configure >> - make doxygen-doc >> - make distcheck >> -- >> 2.7.1.250.gff4ea60 >>
Merged. On 11/17/16 22:56, Mike Holmes wrote: > On 7 November 2016 at 10:49, Maxim Uvarov <maxim.uvarov@linaro.org> wrote: >> Turn on linux-generic dpdk and pcap pktios with their validation >> tests. >> >> Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org> > Reviewed-by: Mike Holmes <mike.holmes@linaro.org> > > We need to make this complete and add netmap pktio to cover all the > possibilities > We could also do with a matrix to cover the different schedulers possibly. yes, or separate test for that. Maxim. > >> --- >> .travis.yml | 22 ++++++++++++++++++---- >> 1 file changed, 18 insertions(+), 4 deletions(-) >> >> diff --git a/.travis.yml b/.travis.yml >> index 0d1add3..1092cd0 100644 >> --- a/.travis.yml >> +++ b/.travis.yml >> @@ -11,6 +11,7 @@ sudo: required >> before_install: >> - sudo apt-get -qq update >> - sudo apt-get install automake autoconf libtool libssl-dev graphviz mscgen doxygen >> + - sudo apt-get install libpcap-dev linux-headers-`uname -r` >> - gem install asciidoctor >> >> # Install cunit for the validation tests because distro version is too old and fails C99 compile >> @@ -24,12 +25,25 @@ before_install: >> - sudo make install >> - cd .. >> - export LD_LIBRARY_PATH="/usr/local/lib:$LD_LIBRARY_PATH" >> - >> -install: >> - - ./bootstrap >> +# DPDK pktio >> + - TARGET=${TARGET:-"x86_64-native-linuxapp-gcc"} >> + - git clone http://dpdk.org/git/dpdk dpdk >> + - pushd dpdk >> + - git checkout -b bv16.07 v16.07 >> + - make config T=${TARGET} O=${TARGET} >> + - pushd ${TARGET} >> + - sed -ri 's,(CONFIG_RTE_LIBRTE_PMD_PCAP=).*,\1y,' .config >> + - popd >> + - make install T=${TARGET} EXTRA_CFLAGS="-fPIC" >> + - popd >> >> script: >> - - ./configure --enable-test-cpp --enable-test-vald --enable-test-helper --enable-test-perf --enable-user-guides --enable-test-perf-proc --enable-test-example >> + >> + - ./bootstrap >> + - ./configure --enable-test-cpp --enable-test-vald --enable-test-helper --enable-test-perf --enable-user-guides --enable-test-perf-proc --enable-test-example --with-dpdk-path=`pwd`/dpdk/${TARGET} >> - make check >> + - git clean -f -d -x && rm -rf dpdk >> + - ./bootstrap >> + - ./configure >> - make doxygen-doc >> - make distcheck >> -- >> 2.7.1.250.gff4ea60 >> > >
On 18 November 2016 at 14:05, Maxim Uvarov <maxim.uvarov@linaro.org> wrote: > On 11/18/16 12:06, Anders Roxell wrote: >> >> On 7 November 2016 at 16:49, Maxim Uvarov <maxim.uvarov@linaro.org> wrote: >>> >>> Turn on linux-generic dpdk and pcap pktios with their validation >>> tests. >>> >>> Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org> >>> --- >>> .travis.yml | 22 ++++++++++++++++++---- >>> 1 file changed, 18 insertions(+), 4 deletions(-) >>> >>> diff --git a/.travis.yml b/.travis.yml >>> index 0d1add3..1092cd0 100644 >>> --- a/.travis.yml >>> +++ b/.travis.yml >>> @@ -11,6 +11,7 @@ sudo: required >>> before_install: >>> - sudo apt-get -qq update >>> - sudo apt-get install automake autoconf libtool libssl-dev >>> graphviz mscgen doxygen >>> + - sudo apt-get install libpcap-dev linux-headers-`uname -r` >>> - gem install asciidoctor >>> >>> # Install cunit for the validation tests because distro version >>> is too old and fails C99 compile >>> @@ -24,12 +25,25 @@ before_install: >>> - sudo make install >>> - cd .. >>> - export LD_LIBRARY_PATH="/usr/local/lib:$LD_LIBRARY_PATH" >>> - >>> -install: >>> - - ./bootstrap >>> +# DPDK pktio >>> + - TARGET=${TARGET:-"x86_64-native-linuxapp-gcc"} >>> + - git clone http://dpdk.org/git/dpdk dpdk >>> + - pushd dpdk >>> + - git checkout -b bv16.07 v16.07 >>> + - make config T=${TARGET} O=${TARGET} >>> + - pushd ${TARGET} >>> + - sed -ri 's,(CONFIG_RTE_LIBRTE_PMD_PCAP=).*,\1y,' .config >>> + - popd >>> + - make install T=${TARGET} EXTRA_CFLAGS="-fPIC" >>> + - popd >> >> why do we build DPDK from source and not just consume the deb package >> with apt-get install? >> >> Cheers, >> Anders >> > my ubuntu does not have dpdk deb package in apt repository. Especially > v16.07 with PMD_PCAP and -fPIC. Why did you push this patch while we still discuss the patch? deb.opendataplane.org/... should have what you need. > > Current script follows steps from README. OK, so maybe we should update the README. > But I don't object if you want > speed up tests with pre built dpdk package. I guess someone want to do that. Cheers, Anders > > Maxim. > > >>> script: >>> - - ./configure --enable-test-cpp --enable-test-vald >>> --enable-test-helper --enable-test-perf --enable-user-guides >>> --enable-test-perf-proc --enable-test-example >>> + >>> + - ./bootstrap >>> + - ./configure --enable-test-cpp --enable-test-vald >>> --enable-test-helper --enable-test-perf --enable-user-guides >>> --enable-test-perf-proc --enable-test-example >>> --with-dpdk-path=`pwd`/dpdk/${TARGET} >>> - make check >>> + - git clean -f -d -x && rm -rf dpdk >>> + - ./bootstrap >>> + - ./configure >>> - make doxygen-doc >>> - make distcheck >>> -- >>> 2.7.1.250.gff4ea60 >>> >
On 11/18/16 22:29, Anders Roxell wrote: > On 18 November 2016 at 14:05, Maxim Uvarov <maxim.uvarov@linaro.org> wrote: >> On 11/18/16 12:06, Anders Roxell wrote: >>> On 7 November 2016 at 16:49, Maxim Uvarov <maxim.uvarov@linaro.org> wrote: >>>> Turn on linux-generic dpdk and pcap pktios with their validation >>>> tests. >>>> >>>> Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org> >>>> --- >>>> .travis.yml | 22 ++++++++++++++++++---- >>>> 1 file changed, 18 insertions(+), 4 deletions(-) >>>> >>>> diff --git a/.travis.yml b/.travis.yml >>>> index 0d1add3..1092cd0 100644 >>>> --- a/.travis.yml >>>> +++ b/.travis.yml >>>> @@ -11,6 +11,7 @@ sudo: required >>>> before_install: >>>> - sudo apt-get -qq update >>>> - sudo apt-get install automake autoconf libtool libssl-dev >>>> graphviz mscgen doxygen >>>> + - sudo apt-get install libpcap-dev linux-headers-`uname -r` >>>> - gem install asciidoctor >>>> >>>> # Install cunit for the validation tests because distro version >>>> is too old and fails C99 compile >>>> @@ -24,12 +25,25 @@ before_install: >>>> - sudo make install >>>> - cd .. >>>> - export LD_LIBRARY_PATH="/usr/local/lib:$LD_LIBRARY_PATH" >>>> - >>>> -install: >>>> - - ./bootstrap >>>> +# DPDK pktio >>>> + - TARGET=${TARGET:-"x86_64-native-linuxapp-gcc"} >>>> + - git clone http://dpdk.org/git/dpdk dpdk >>>> + - pushd dpdk >>>> + - git checkout -b bv16.07 v16.07 >>>> + - make config T=${TARGET} O=${TARGET} >>>> + - pushd ${TARGET} >>>> + - sed -ri 's,(CONFIG_RTE_LIBRTE_PMD_PCAP=).*,\1y,' .config >>>> + - popd >>>> + - make install T=${TARGET} EXTRA_CFLAGS="-fPIC" >>>> + - popd >>> why do we build DPDK from source and not just consume the deb package >>> with apt-get install? >>> >>> Cheers, >>> Anders >>> >> my ubuntu does not have dpdk deb package in apt repository. Especially >> v16.07 with PMD_PCAP and -fPIC. > > Why did you push this patch while we still discuss the patch? > > deb.opendataplane.org/... should have what you need. Sorry, I interpret your question as question, not as objection. Then I discussed that with Mike and we agreed that it's better to take what is in README. Testing deb packages will require some time. As well as README update, and update documentation how to build such debs from source. >> Current script follows steps from README. > OK, so maybe we should update the README. I'm not really know what is better. For me dpdk source code is better so I can jump into it with ctags. Let's discuss on Arch call if we should like .travis tests to debs or to source code. >> But I don't object if you want >> speed up tests with pre built dpdk package. > I guess someone want to do that. > > Cheers, > Anders > >> Maxim. >> >> >>>> script: >>>> - - ./configure --enable-test-cpp --enable-test-vald >>>> --enable-test-helper --enable-test-perf --enable-user-guides >>>> --enable-test-perf-proc --enable-test-example >>>> + >>>> + - ./bootstrap >>>> + - ./configure --enable-test-cpp --enable-test-vald >>>> --enable-test-helper --enable-test-perf --enable-user-guides >>>> --enable-test-perf-proc --enable-test-example >>>> --with-dpdk-path=`pwd`/dpdk/${TARGET} >>>> - make check >>>> + - git clean -f -d -x && rm -rf dpdk >>>> + - ./bootstrap >>>> + - ./configure >>>> - make doxygen-doc >>>> - make distcheck >>>> -- >>>> 2.7.1.250.gff4ea60 >>>>
diff --git a/.travis.yml b/.travis.yml index 0d1add3..1092cd0 100644 --- a/.travis.yml +++ b/.travis.yml @@ -11,6 +11,7 @@ sudo: required before_install: - sudo apt-get -qq update - sudo apt-get install automake autoconf libtool libssl-dev graphviz mscgen doxygen + - sudo apt-get install libpcap-dev linux-headers-`uname -r` - gem install asciidoctor # Install cunit for the validation tests because distro version is too old and fails C99 compile @@ -24,12 +25,25 @@ before_install: - sudo make install - cd .. - export LD_LIBRARY_PATH="/usr/local/lib:$LD_LIBRARY_PATH" - -install: - - ./bootstrap +# DPDK pktio + - TARGET=${TARGET:-"x86_64-native-linuxapp-gcc"} + - git clone http://dpdk.org/git/dpdk dpdk + - pushd dpdk + - git checkout -b bv16.07 v16.07 + - make config T=${TARGET} O=${TARGET} + - pushd ${TARGET} + - sed -ri 's,(CONFIG_RTE_LIBRTE_PMD_PCAP=).*,\1y,' .config + - popd + - make install T=${TARGET} EXTRA_CFLAGS="-fPIC" + - popd script: - - ./configure --enable-test-cpp --enable-test-vald --enable-test-helper --enable-test-perf --enable-user-guides --enable-test-perf-proc --enable-test-example + + - ./bootstrap + - ./configure --enable-test-cpp --enable-test-vald --enable-test-helper --enable-test-perf --enable-user-guides --enable-test-perf-proc --enable-test-example --with-dpdk-path=`pwd`/dpdk/${TARGET} - make check + - git clean -f -d -x && rm -rf dpdk + - ./bootstrap + - ./configure - make doxygen-doc - make distcheck
Turn on linux-generic dpdk and pcap pktios with their validation tests. Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org> --- .travis.yml | 22 ++++++++++++++++++---- 1 file changed, 18 insertions(+), 4 deletions(-) -- 2.7.1.250.gff4ea60