| Message ID | 20240706081104.14493-3-qasim.majeed20@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/4] Updating a deprecated use of strcpy from acpi_pad.c file. | expand |
On Sat, Jul 6, 2024 at 10:11 AM Muhammad Qasim Abdul Majeed <qasim.majeed20@gmail.com> wrote: > > Replacing strcpy with strscpy. > strcpy is a deprecated function. > It should be removed from the kernel source. > > Link: https://github.com/KSPP/linux/issues/88 > > Signed-off-by: Muhammad Qasim Abdul Majeed <qasim.majeed20@gmail.com> > --- > drivers/acpi/battery.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c > index b379401ff1c2..784f9234f1a4 100644 > --- a/drivers/acpi/battery.c > +++ b/drivers/acpi/battery.c > @@ -1193,8 +1193,8 @@ static int acpi_battery_add(struct acpi_device *device) > if (!battery) > return -ENOMEM; > battery->device = device; > - strcpy(acpi_device_name(device), ACPI_BATTERY_DEVICE_NAME); > - strcpy(acpi_device_class(device), ACPI_BATTERY_CLASS); > + strscpy(acpi_device_name(device), ACPI_BATTERY_DEVICE_NAME); > + strscpy(acpi_device_class(device), ACPI_BATTERY_CLASS); > device->driver_data = battery; > mutex_init(&battery->lock); > mutex_init(&battery->sysfs_lock); > -- Applied as 6.12 material with edited subject and changelog, thanks!
diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c index b379401ff1c2..784f9234f1a4 100644 --- a/drivers/acpi/battery.c +++ b/drivers/acpi/battery.c @@ -1193,8 +1193,8 @@ static int acpi_battery_add(struct acpi_device *device) if (!battery) return -ENOMEM; battery->device = device; - strcpy(acpi_device_name(device), ACPI_BATTERY_DEVICE_NAME); - strcpy(acpi_device_class(device), ACPI_BATTERY_CLASS); + strscpy(acpi_device_name(device), ACPI_BATTERY_DEVICE_NAME); + strscpy(acpi_device_class(device), ACPI_BATTERY_CLASS); device->driver_data = battery; mutex_init(&battery->lock); mutex_init(&battery->sysfs_lock);
Replacing strcpy with strscpy. strcpy is a deprecated function. It should be removed from the kernel source. Link: https://github.com/KSPP/linux/issues/88 Signed-off-by: Muhammad Qasim Abdul Majeed <qasim.majeed20@gmail.com> --- drivers/acpi/battery.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)