diff mbox series

[v4,05/16] x86/cpu: Remove redundant comment during feature setup

Message ID 20240710160655.3402786-6-alexander.shishkin@linux.intel.com
State New
Headers show
Series Enable Linear Address Space Separation support | expand

Commit Message

Alexander Shishkin July 10, 2024, 4:06 p.m. UTC
From: Sohil Mehta <sohil.mehta@intel.com>

The code below the comment is self explanatory. Instead of updating the
comment with the newly added LASS feature, it is better to just remove
it.

Signed-off-by: Sohil Mehta <sohil.mehta@intel.com>
Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
---
 arch/x86/kernel/cpu/common.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Borislav Petkov July 10, 2024, 5:21 p.m. UTC | #1
On Wed, Jul 10, 2024 at 07:06:41PM +0300, Alexander Shishkin wrote:
> From: Sohil Mehta <sohil.mehta@intel.com>
> 
> The code below the comment is self explanatory. Instead of updating the
> comment with the newly added LASS feature, it is better to just remove
> it.
> 
> Signed-off-by: Sohil Mehta <sohil.mehta@intel.com>
> Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
> ---
>  arch/x86/kernel/cpu/common.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
> index dcf61a66e462..33a76256a6f5 100644
> --- a/arch/x86/kernel/cpu/common.c
> +++ b/arch/x86/kernel/cpu/common.c
> @@ -1841,7 +1841,6 @@ static void identify_cpu(struct cpuinfo_x86 *c)
>  	/* Disable the PN if appropriate */
>  	squash_the_stupid_serial_number(c);
>  
> -	/* Set up SMEP/SMAP/UMIP */
>  	setup_smep(c);
>  	setup_smap(c);
>  	setup_umip(c);
> -- 

A separate patch just for that?! You're kidding, right?

Just merge it with the previous one.
diff mbox series

Patch

diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
index dcf61a66e462..33a76256a6f5 100644
--- a/arch/x86/kernel/cpu/common.c
+++ b/arch/x86/kernel/cpu/common.c
@@ -1841,7 +1841,6 @@  static void identify_cpu(struct cpuinfo_x86 *c)
 	/* Disable the PN if appropriate */
 	squash_the_stupid_serial_number(c);
 
-	/* Set up SMEP/SMAP/UMIP */
 	setup_smep(c);
 	setup_smap(c);
 	setup_umip(c);