| Message ID | 20240719120853.1924771-7-m.majewski2@samsung.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/6] drivers/thermal/exynos: use DEFINE_SIMPLE_DEV_PM_OPS | expand |
On Fri, Jul 19, 2024 at 7:10 AM Mateusz Majewski <m.majewski2@samsung.com> wrote: > > This is not true as of commit 5314b1543787 ("thermal/drivers/exynos: Use > set_trips ops"). > > Signed-off-by: Mateusz Majewski <m.majewski2@samsung.com> > --- Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org> > .../bindings/thermal/samsung,exynos-thermal.yaml | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/thermal/samsung,exynos-thermal.yaml b/Documentation/devicetree/bindings/thermal/samsung,exynos-thermal.yaml > index 4363ee625339..5a82764a4dbb 100644 > --- a/Documentation/devicetree/bindings/thermal/samsung,exynos-thermal.yaml > +++ b/Documentation/devicetree/bindings/thermal/samsung,exynos-thermal.yaml > @@ -40,11 +40,8 @@ properties: > interrupts: > description: | > The Exynos TMU supports generating interrupts when reaching given > - temperature thresholds. Number of supported thermal trip points depends > - on the SoC (only first trip points defined in DT will be configured):: > - - most of SoC: 4 > - - samsung,exynos5433-tmu: 8 > - - samsung,exynos7-tmu: 8 > + temperature thresholds. The trip points will be set dynamically in > + runtime, which means there is no limit on the number of trip points. > maxItems: 1 > > reg: > -- > 2.45.1 > >
On Fri, Jul 19, 2024 at 02:08:50PM +0200, Mateusz Majewski wrote: > This is not true as of commit 5314b1543787 ("thermal/drivers/exynos: Use > set_trips ops"). > > Signed-off-by: Mateusz Majewski <m.majewski2@samsung.com> > --- > .../bindings/thermal/samsung,exynos-thermal.yaml | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/thermal/samsung,exynos-thermal.yaml b/Documentation/devicetree/bindings/thermal/samsung,exynos-thermal.yaml > index 4363ee625339..5a82764a4dbb 100644 > --- a/Documentation/devicetree/bindings/thermal/samsung,exynos-thermal.yaml > +++ b/Documentation/devicetree/bindings/thermal/samsung,exynos-thermal.yaml > @@ -40,11 +40,8 @@ properties: > interrupts: > description: | > The Exynos TMU supports generating interrupts when reaching given > - temperature thresholds. Number of supported thermal trip points depends > - on the SoC (only first trip points defined in DT will be configured):: > - - most of SoC: 4 > - - samsung,exynos5433-tmu: 8 > - - samsung,exynos7-tmu: 8 > + temperature thresholds. The trip points will be set dynamically in > + runtime, which means there is no limit on the number of trip points. How can the hardware change how many trip points it supports? > maxItems: 1 > > reg: > -- > 2.45.1 >
Hi :) > > + temperature thresholds. The trip points will be set dynamically in > > + runtime, which means there is no limit on the number of trip points. > > How can the hardware change how many trip points it supports? Would just removing the whole "The trip points..." sentence be ok? I see how it is more confusing than helpful.
diff --git a/Documentation/devicetree/bindings/thermal/samsung,exynos-thermal.yaml b/Documentation/devicetree/bindings/thermal/samsung,exynos-thermal.yaml index 4363ee625339..5a82764a4dbb 100644 --- a/Documentation/devicetree/bindings/thermal/samsung,exynos-thermal.yaml +++ b/Documentation/devicetree/bindings/thermal/samsung,exynos-thermal.yaml @@ -40,11 +40,8 @@ properties: interrupts: description: | The Exynos TMU supports generating interrupts when reaching given - temperature thresholds. Number of supported thermal trip points depends - on the SoC (only first trip points defined in DT will be configured):: - - most of SoC: 4 - - samsung,exynos5433-tmu: 8 - - samsung,exynos7-tmu: 8 + temperature thresholds. The trip points will be set dynamically in + runtime, which means there is no limit on the number of trip points. maxItems: 1 reg:
This is not true as of commit 5314b1543787 ("thermal/drivers/exynos: Use set_trips ops"). Signed-off-by: Mateusz Majewski <m.majewski2@samsung.com> --- .../bindings/thermal/samsung,exynos-thermal.yaml | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)