diff mbox series

mmc-utils: create mandir during install

Message ID ZpxwXEKy1bAOCes_@378c8c72e398
State New
Headers show
Series mmc-utils: create mandir during install | expand

Commit Message

Rudi Heitbaum July 21, 2024, 2:20 a.m. UTC
fixes install faikure when mandir is not already created

  install -m 644 mmc.1 /usr/share/man/man1
  install: cannot create regular file '/usr/share/man/man1': No such file or directory

Signed-off-by: Rudi Heitbaum <rudi@heitbaum.com>
---
 Makefile | 1 +
 1 file changed, 1 insertion(+)

Comments

Avri Altman July 27, 2024, 5:25 p.m. UTC | #1
> fixes install faikure when mandir is not already created
                       ^^^^^^  failure 
> 
>   install -m 644 mmc.1 /usr/share/man/man1
>   install: cannot create regular file '/usr/share/man/man1': No such file or
> directory
> 
> Signed-off-by: Rudi Heitbaum <rudi@heitbaum.com>
Reviewed-by: Avri Altman <avri.altman@wdc.com>

> ---
>  Makefile | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Makefile b/Makefile
> index 9e14a5c..06ae0f7 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -53,6 +53,7 @@ clean:
>  install: $(progs)
>         $(INSTALL) -m755 -d $(DESTDIR)$(bindir)
>         $(INSTALL) $(progs) $(DESTDIR)$(bindir)
> +       $(INSTALL) -m755 -d $(DESTDIR)$(mandir)/man1
>         $(INSTALL) -m 644 mmc.1 $(DESTDIR)$(mandir)/man1
> 
>  -include $(foreach obj,$(objects), $(dir $(obj))/.$(notdir $(obj)).d)
> --
> 2.43.0
Ulf Hansson Aug. 1, 2024, 11:01 a.m. UTC | #2
On Sun, 21 Jul 2024 at 04:20, Rudi Heitbaum <rudi@heitbaum.com> wrote:
>
> fixes install faikure when mandir is not already created
>
>   install -m 644 mmc.1 /usr/share/man/man1
>   install: cannot create regular file '/usr/share/man/man1': No such file or directory
>
> Signed-off-by: Rudi Heitbaum <rudi@heitbaum.com>

Applied to git.kernel.org/pub/scm/utils/mmc/mmc-utils.git master, thanks!

Kind regards
Uffe


> ---
>  Makefile | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/Makefile b/Makefile
> index 9e14a5c..06ae0f7 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -53,6 +53,7 @@ clean:
>  install: $(progs)
>         $(INSTALL) -m755 -d $(DESTDIR)$(bindir)
>         $(INSTALL) $(progs) $(DESTDIR)$(bindir)
> +       $(INSTALL) -m755 -d $(DESTDIR)$(mandir)/man1
>         $(INSTALL) -m 644 mmc.1 $(DESTDIR)$(mandir)/man1
>
>  -include $(foreach obj,$(objects), $(dir $(obj))/.$(notdir $(obj)).d)
> --
> 2.43.0
>
diff mbox series

Patch

diff --git a/Makefile b/Makefile
index 9e14a5c..06ae0f7 100644
--- a/Makefile
+++ b/Makefile
@@ -53,6 +53,7 @@  clean:
 install: $(progs)
 	$(INSTALL) -m755 -d $(DESTDIR)$(bindir)
 	$(INSTALL) $(progs) $(DESTDIR)$(bindir)
+	$(INSTALL) -m755 -d $(DESTDIR)$(mandir)/man1
 	$(INSTALL) -m 644 mmc.1 $(DESTDIR)$(mandir)/man1
 
 -include $(foreach obj,$(objects), $(dir $(obj))/.$(notdir $(obj)).d)