| Message ID | 20240723134330.1327001-1-make24@iscas.ac.cn |
|---|---|
| State | Superseded |
| Headers | show |
| Series | wifi: iwlwifi: mvm: fix an error code in iwl_mvm_alloc_sta_after_restart() | expand |
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c b/drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c index d5a204e52076..477239a1ed83 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c @@ -644,12 +644,12 @@ static int iwl_mvm_alloc_sta_after_restart(struct iwl_mvm *mvm, lockdep_is_held(&mvm->mutex)); if (!link_conf) - continue; + return -EINVAL; mvm_link = mvmvif->link[link_conf->link_id]; if (!mvm_link || !mvm_link_sta) - continue; + return -EINVAL; sta_id = mvm_link_sta->sta_id; ret = iwl_mvm_mld_cfg_sta(mvm, sta, vif, link_sta,
This error path should return -EINVAL instead of success. Fixes: 57974a55d995 ("wifi: iwlwifi: mvm: refactor iwl_mvm_mac_sta_state_common()") Signed-off-by: Ma Ke <make24@iscas.ac.cn> --- drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)