diff mbox series

[28/40] lmb: config: make lmb config symbol def_bool

Message ID 20240724060224.3071065-29-sughosh.ganu@linaro.org
State New
Headers show
Series Make LMB memory map global and persistent | expand

Commit Message

Sughosh Ganu July 24, 2024, 6:02 a.m. UTC
The LMB module provides allocation/reservation API's, primarily for
loading images to memory. This is functionality which is used by all
boards. Make the config symbol used for the main U-Boot image as
def_bool and enable it by default.

Signed-off-by: Sughosh Ganu <sughosh.ganu@linaro.org>
---
Changes since rfc: New patch

 lib/Kconfig | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Tom Rini July 24, 2024, 8:55 p.m. UTC | #1
On Wed, Jul 24, 2024 at 11:32:12AM +0530, Sughosh Ganu wrote:

> The LMB module provides allocation/reservation API's, primarily for
> loading images to memory. This is functionality which is used by all
> boards. Make the config symbol used for the main U-Boot image as
> def_bool and enable it by default.
> 
> Signed-off-by: Sughosh Ganu <sughosh.ganu@linaro.org>
> ---
> Changes since rfc: New patch
> 
>  lib/Kconfig | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)

OK, I asked for this, but, some platforms had special enough uses where
they disabled it and so we get more growth here too, so, lets drop this
concept for now.
Michal Simek July 25, 2024, 6:22 a.m. UTC | #2
On 7/24/24 22:55, Tom Rini wrote:
> On Wed, Jul 24, 2024 at 11:32:12AM +0530, Sughosh Ganu wrote:
> 
>> The LMB module provides allocation/reservation API's, primarily for
>> loading images to memory. This is functionality which is used by all
>> boards. Make the config symbol used for the main U-Boot image as
>> def_bool and enable it by default.
>>
>> Signed-off-by: Sughosh Ganu <sughosh.ganu@linaro.org>
>> ---
>> Changes since rfc: New patch
>>
>>   lib/Kconfig | 4 +---
>>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> OK, I asked for this, but, some platforms had special enough uses where
> they disabled it and so we get more growth here too, so, lets drop this
> concept for now.

Our mini configurations are disabling it because it consumes a lot of space ad 
we don't need it. Commit message should be definitely updated.

Thanks,
Michal
diff mbox series

Patch

diff --git a/lib/Kconfig b/lib/Kconfig
index 6a9338390a..c7fa4bc77e 100644
--- a/lib/Kconfig
+++ b/lib/Kconfig
@@ -1099,9 +1099,7 @@  config LIB_ELF
 	  This supports for 32 bit and 64 bit versions.
 
 config LMB
-	bool "Enable the logical memory blocks library (lmb)"
-	default y if ARC || ARM || M68K || MICROBLAZE || MIPS || \
-		     NIOS2 || PPC || RISCV || SANDBOX || SH || X86 || XTENSA
+	def_bool y
 	help
 	  Support the library logical memory blocks. This will require
 	  a malloc() implementation for defining the data structures