| Message ID | 20240729195810.25040-1-anton@khirnov.net |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2] Bluetooth: hci_sync: avoid dup filtering when passive scanning with adv monitor | expand |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=874705 ---Test result--- Test Summary: CheckPatch PASS 0.48 seconds GitLint FAIL 0.51 seconds SubjectPrefix PASS 0.07 seconds BuildKernel PASS 29.84 seconds CheckAllWarning PASS 32.25 seconds CheckSparse PASS 38.01 seconds CheckSmatch PASS 102.65 seconds BuildKernel32 PASS 29.27 seconds TestRunnerSetup PASS 531.58 seconds TestRunner_l2cap-tester PASS 35.70 seconds TestRunner_iso-tester FAIL 46.15 seconds TestRunner_bnep-tester PASS 10.24 seconds TestRunner_mgmt-tester PASS 117.63 seconds TestRunner_rfcomm-tester PASS 7.49 seconds TestRunner_sco-tester PASS 32.95 seconds TestRunner_ioctl-tester PASS 7.98 seconds TestRunner_mesh-tester PASS 6.08 seconds TestRunner_smp-tester PASS 6.98 seconds TestRunner_userchan-tester PASS 5.06 seconds IncrementalBuild PASS 27.97 seconds Details ############################## Test: GitLint - FAIL Desc: Run gitlint Output: [v2] Bluetooth: hci_sync: avoid dup filtering when passive scanning with adv monitor WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search 1: T1 Title exceeds max length (84>80): "[v2] Bluetooth: hci_sync: avoid dup filtering when passive scanning with adv monitor" ############################## Test: TestRunner_iso-tester - FAIL Desc: Run iso-tester with test-runner Output: Total: 122, Passed: 117 (95.9%), Failed: 1, Not Run: 4 Failed Test Cases ISO Connect2 Suspend - Success Failed 4.230 seconds --- Regards, Linux Bluetooth
Hello: This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Mon, 29 Jul 2024 21:58:10 +0200 you wrote: > This restores behaviour (including the comment) from now-removed > hci_request.c, and also matches existing code for active scanning. > > Without this, the duplicates filter is always active when passive > scanning, which makes it impossible to work with devices that send > nontrivial dynamic data in their advertisement reports. > > [...] Here is the summary with links: - [v2] Bluetooth: hci_sync: avoid dup filtering when passive scanning with adv monitor https://git.kernel.org/bluetooth/bluetooth-next/c/2360f368524b You are awesome, thank you!
diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c index a31d39a821f4..e79cd40bd079 100644 --- a/net/bluetooth/hci_sync.c +++ b/net/bluetooth/hci_sync.c @@ -3019,6 +3019,20 @@ static int hci_passive_scan_sync(struct hci_dev *hdev) } else if (hci_is_adv_monitoring(hdev)) { window = hdev->le_scan_window_adv_monitor; interval = hdev->le_scan_int_adv_monitor; + + /* Disable duplicates filter when scanning for advertisement + * monitor for the following reasons. + * + * For HW pattern filtering (ex. MSFT), Realtek and Qualcomm + * controllers ignore RSSI_Sampling_Period when the duplicates + * filter is enabled. + * + * For SW pattern filtering, when we're not doing interleaved + * scanning, it is necessary to disable duplicates filter, + * otherwise hosts can only receive one advertisement and it's + * impossible to know if a peer is still in range. + */ + filter_dups = LE_SCAN_FILTER_DUP_DISABLE; } else { window = hdev->le_scan_window; interval = hdev->le_scan_interval;
This restores behaviour (including the comment) from now-removed hci_request.c, and also matches existing code for active scanning. Without this, the duplicates filter is always active when passive scanning, which makes it impossible to work with devices that send nontrivial dynamic data in their advertisement reports. Fixes: abfeea476c68 ("Bluetooth: hci_sync: Convert MGMT_OP_START_DISCOVERY") Signed-off-by: Anton Khirnov <anton@khirnov.net> --- net/bluetooth/hci_sync.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+)