diff mbox series

[v3,3/3] arm64: defconfig: Enable interconnect for SM4450

Message ID 20240801-sm4450_interconnect-v3-3-8e364d0faa99@quicinc.com
State Superseded
Headers show
Series interconnect: qcom: Add SM4450 interconnect | expand

Commit Message

Tengfei Fan Aug. 1, 2024, 8:54 a.m. UTC
Add the SM4450 interconnect driver as built-in.

Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
---
 arch/arm64/configs/defconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Krzysztof Kozlowski Aug. 2, 2024, 7:20 a.m. UTC | #1
On 01/08/2024 10:54, Tengfei Fan wrote:
> Add the SM4450 interconnect driver as built-in.

This we see from the diff. Tell us instead: why?

That's a standard requirement for every defconfig change. Damn, for
every change. Don't say what the diff is saying, unless it is
non-trivial. Say why you are doing things.

Best regards,
Krzysztof
Tengfei Fan Aug. 5, 2024, 1:51 a.m. UTC | #2
On 8/2/2024 3:20 PM, Krzysztof Kozlowski wrote:
> On 01/08/2024 10:54, Tengfei Fan wrote:
>> Add the SM4450 interconnect driver as built-in.
> 
> This we see from the diff. Tell us instead: why?
> 
> That's a standard requirement for every defconfig change. Damn, for
> every change. Don't say what the diff is saying, unless it is
> non-trivial. Say why you are doing things.
> 
> Best regards,
> Krzysztof
> 

In the next version of the patch series, I will describe in the comment 
message why this config needs to be enabled.
diff mbox series

Patch

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 831aa314bc9c..d6f50d31568e 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -1623,6 +1623,7 @@  CONFIG_INTERCONNECT_QCOM_SC8180X=y
 CONFIG_INTERCONNECT_QCOM_SC8280XP=y
 CONFIG_INTERCONNECT_QCOM_SDM845=y
 CONFIG_INTERCONNECT_QCOM_SDX75=y
+CONFIG_INTERCONNECT_QCOM_SM4450=y
 CONFIG_INTERCONNECT_QCOM_SM6115=y
 CONFIG_INTERCONNECT_QCOM_SM8150=y
 CONFIG_INTERCONNECT_QCOM_SM8250=y